-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed a bug in update #5336
fixed a bug in update #5336
Conversation
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @ndmckinley, please review this PR or find an appropriate assignee. |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 2 files changed, 59 insertions(+), 7 deletions(-)) |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeBackendBucket_backendBucketFullExample|TestAccComputeBackendBucket_withCdnPolicy|TestAccContainerCluster_withAddons|TestAccContainerCluster_withWorkloadIdentityConfigDeprecation|TestAccContainerCluster_withWorkloadIdentityConfig|TestAccServiceNetworkingPeeredDNSDomain_basic You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=211033 |
Tests failed during RECORDING mode: TestAccComputeBackendBucket_withCdnPolicy|TestAccServiceNetworkingPeeredDNSDomain_basic Please fix these to complete your PR |
Looks like the CDN test failed:
|
ea11feb
to
bc6f4ce
Compare
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 2 files changed, 59 insertions(+), 7 deletions(-)) |
Local test seems to be fine. Rebase and retry |
bc6f4ce
to
01d8e06
Compare
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 2 files changed, 59 insertions(+), 7 deletions(-)) |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeBackendBucket_withCdnPolicy|TestAccServiceNetworkingPeeredDNSDomain_basic|TestAccSqlUser_postgresIAM You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=211650 |
It looks like it's still failing in CI - I assume it's passing on your machine? |
Yes. pass on my machine @ndmckinley |
Read the logs of that test and it seems that it was destroyed, during the destroy step, by an external process. Just bad luck. I won't make you go through the debug loop again, I'm sure this works. Going to LGTM despite the failure. |
Thanks for the fix! Greatly appreciate it 🎉 |
Fixes hashicorp/terraform-provider-google#10332
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)