fixed a bug in update

[edwardmedia]

Fixes hashicorp/terraform-provider-google#10332

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: fixed a bug in updating multiple `ttl` fields on `google_compute_backend_bucket`

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@ndmckinley, please review this PR or find an appropriate assignee.

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 59 insertions(+), 7 deletions(-))
Terraform Beta: Diff ( 4 files changed, 61 insertions(+), 10 deletions(-))
TF Conversion: Diff ( 1 file changed, 5 insertions(+), 5 deletions(-))

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeBackendBucket_backendBucketFullExample|TestAccComputeBackendBucket_withCdnPolicy|TestAccContainerCluster_withAddons|TestAccContainerCluster_withWorkloadIdentityConfigDeprecation|TestAccContainerCluster_withWorkloadIdentityConfig|TestAccServiceNetworkingPeeredDNSDomain_basic You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=211033

[modular-magician]

Tests failed during RECORDING mode: TestAccComputeBackendBucket_withCdnPolicy|TestAccServiceNetworkingPeeredDNSDomain_basic Please fix these to complete your PR

[nat-henderson]

Looks like the CDN test failed:

=== RUN   TestAccComputeBackendBucket_withCdnPolicy
=== PAUSE TestAccComputeBackendBucket_withCdnPolicy
=== CONT  TestAccComputeBackendBucket_withCdnPolicy
provider_test.go:278: Step 5/8 error: Error running apply: exit status 1
There are some problems with the CLI configuration:
Error: The specified plugin cache dir /opt/teamcity-agent/work/2e51954ade9939a/.provider-cache cannot be opened: stat /opt/teamcity-agent/work/2e51954ade9939a/.provider-cache: no such file or directory
As a result of the above problems, Terraform may not behave as intended.
Error: Error updating BackendBucket "projects/ci-test-project-188019/global/backendBuckets/tf-test-zsj4hasea4": googleapi: Error 400: The resource 'projects/ci-test-project-188019/global/backendBuckets/tf-test-zsj4hasea4' is not ready, resourceNotReady
on terraform_plugin_test.tf line 2, in resource "google_compute_backend_bucket" "foobar":
2: resource "google_compute_backend_bucket" "foobar" {
--- FAIL: TestAccComputeBackendBucket_withCdnPolicy (42.32s)
FAIL

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 59 insertions(+), 7 deletions(-))
Terraform Beta: Diff ( 2 files changed, 59 insertions(+), 7 deletions(-))
TF Conversion: Diff ( 1 file changed, 5 insertions(+), 5 deletions(-))

[edwardmedia]

Local test seems to be fine. Rebase and retry

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 59 insertions(+), 7 deletions(-))
Terraform Beta: Diff ( 3 files changed, 60 insertions(+), 8 deletions(-))
TF Conversion: Diff ( 1 file changed, 5 insertions(+), 5 deletions(-))

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeBackendBucket_withCdnPolicy|TestAccServiceNetworkingPeeredDNSDomain_basic|TestAccSqlUser_postgresIAM You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=211650

[nat-henderson]

It looks like it's still failing in CI - I assume it's passing on your machine?

[edwardmedia]

Yes. pass on my machine @ndmckinley

[nat-henderson]

Read the logs of that test and it seems that it was destroyed, during the destroy step, by an external process. Just bad luck. I won't make you go through the debug loop again, I'm sure this works. Going to LGTM despite the failure.

[apottere]

Thanks for the fix! Greatly appreciate it 🎉