-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make database version required for google_sql_database_instance #5337
Make database version required for google_sql_database_instance #5337
Conversation
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 16 files changed, 128 insertions(+), 91 deletions(-)) |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceGoogleSQLCaCerts_basic|TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccCloudRunService_cloudRunServiceSqlExample|TestAccContainerCluster_withAddons|TestAccContainerCluster_withWorkloadIdentityConfigDeprecation|TestAccContainerCluster_withWorkloadIdentityConfig|TestAccServiceNetworkingPeeredDNSDomain_basic|TestAccSQLDatabase_sqlDatabaseBasicExample|TestAccSqlDatabaseInstance_basicSecondGen|TestAccSqlDatabaseInstance_basicMSSQL|TestAccSqlDatabaseInstance_settings_basic|TestAccSqlDatabaseInstance_settings_deletionProtection|TestAccSqlDatabaseInstance_slave|TestAccSqlDatabaseInstance_maintenance|TestAccSqlDatabaseInstance_diskspecs|TestAccSqlDatabaseInstance_settings_upgrade|TestAccSqlDatabaseInstance_settingsDowngrade|TestAccSqlDatabaseInstance_multipleOperations|TestAccSqlDatabaseInstance_authNets|TestAccSqlDatabaseInstance_basic_with_user_labels|TestAccSqlDatabaseInstance_withPrivateNetwork|TestAccSqlClientCert_postgres|TestAccSqlDatabase_basic|TestAccSqlDatabase_update|TestAccSqlClientCert_mysql You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=211185 |
Tests failed during RECORDING mode: TestAccSqlClientCert_postgres Please fix these to complete your PR |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 16 files changed, 127 insertions(+), 90 deletions(-)) |
/gcbrun |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 16 files changed, 127 insertions(+), 90 deletions(-)) |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccContainerNodePool_withGPU|TestAccServiceNetworkingPeeredDNSDomain_basic|TestAccSqlUser_postgresIAM You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=211341 |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 16 files changed, 127 insertions(+), 90 deletions(-)) |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComposerEnvironment_basic|TestAccComposerEnvironment_update|TestAccComposerEnvironment_ComposerV2|TestAccComputeBackendBucket_backendBucketFullExample|TestAccComputeBackendBucket_withCdnPolicy|TestAccContainerNodePool_withWorkloadIdentityConfig|TestAccDataprocCluster_withServiceAcc|TestAccProject_migrateParent|TestAccSqlUser_postgresIAM You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=212555 |
Fixes hashicorp/terraform-provider-google#5212
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)