Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the location field required in google_storage_bucket #5352

Merged
merged 3 commits into from
Oct 25, 2021

Conversation

shuyama1
Copy link
Member

fixes hashicorp/terraform-provider-google#4422

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

storage: changed the `location` field to `Required` in `google_storage_bucket ` resource

@google-cla google-cla bot added the cla: yes label Oct 20, 2021
@shuyama1 shuyama1 changed the title make location required in google_storage_bucket make the location field required in google_storage_bucket Oct 20, 2021
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 71 files changed, 400 insertions(+), 214 deletions(-))
Terraform Beta: Diff ( 73 files changed, 433 insertions(+), 231 deletions(-))
TF OiCS: Diff ( 11 files changed, 27 insertions(+), 19 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeForwardingRule_update|TestAccContainerNodePool_withGPU|TestAccSqlUser_postgresIAM You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=211603

@modular-magician
Copy link
Collaborator

Tests failed during RECORDING mode: TestAccSqlUser_postgresIAM Please fix these to complete your PR

Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait- I can't read, apparently, missed it while scrolling through the files.

That's a ton of changes to the tests, thanks!

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 71 files changed, 394 insertions(+), 212 deletions(-))
Terraform Beta: Diff ( 73 files changed, 429 insertions(+), 230 deletions(-))
TF OiCS: Diff ( 11 files changed, 27 insertions(+), 19 deletions(-))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storage Bucket with unspecified location may fail
3 participants