Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for vpc network configuration in google_service_directory_endpoint #5391

Merged
merged 4 commits into from
Nov 16, 2021

Conversation

lcaggio
Copy link
Contributor

@lcaggio lcaggio commented Oct 29, 2021

Add support for 'network' flag on ServiceDirectory Endpoint resource.

fixes hashicorp/terraform-provider-google#10057

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

serviceDirectory: add support for vpc network configuration in google_service_directory_endpoint.

@google-cla google-cla bot added the cla: yes label Oct 29, 2021
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@ndmckinley, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 49 insertions(+))
Terraform Beta: Diff ( 8 files changed, 147 insertions(+), 5 deletions(-))
TF OiCS: Diff ( 4 files changed, 136 insertions(+))

@rileykarson rileykarson requested review from a team and slevenick and removed request for nat-henderson and a team October 29, 2021 16:31
@slevenick
Copy link
Contributor

/gcbrun

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 49 insertions(+))
Terraform Beta: Diff ( 3 files changed, 146 insertions(+))
TF OiCS: Diff ( 4 files changed, 136 insertions(+))

@slevenick slevenick self-requested a review November 16, 2021 21:16
Copy link
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@slevenick slevenick merged commit b759eed into GoogleCloudPlatform:master Nov 16, 2021
betsy-lichtenberg pushed a commit to betsy-lichtenberg/magic-modules that referenced this pull request Apr 25, 2022
…_endpoint (GoogleCloudPlatform#5391)

* Servicedirectory: add 'network' attribute to endpoint resource.

* Update description

* Add tests

* Delete main.tf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support vpc network configuration in google_service_directory_endpoint
3 participants