Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Container Filesystem (GCFS) configuration support #5398

Merged
merged 9 commits into from
Nov 4, 2021

Conversation

paulbsch
Copy link
Contributor

Google Container Filesysem (GCFS) recently went GA and GcfsConfig is now available with the release of google-api-go-client v0.60.0:
https://github.com/googleapis/google-api-go-client/releases/tag/v0.60.0

If this PR is for Terraform, I acknowledge that I have:

  • [ X] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • [ X] Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • [X ] Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • [X ] Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • [X ] Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

container: added `gcfs_config` to `node_config` of `google_container_node_pool` resource

@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@rileykarson, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 101 insertions(+))
Terraform Beta: Diff ( 3 files changed, 101 insertions(+))

@paulbsch
Copy link
Contributor Author

Some of the checks are likely failing due to needing:
google.golang.org/api v0.60.0

@rileykarson
Copy link
Member

We'll need to update the copied go.sum alongside the change to go.mod.erb. To do that you can open one of the terraform-provider repos, run go get and go mod tidy, and copy over the new go.sum file replacing the existing one.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 116 insertions(+), 7 deletions(-))
Terraform Beta: Diff ( 5 files changed, 116 insertions(+), 7 deletions(-))

@rileykarson
Copy link
Member

/gcbrun

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 116 insertions(+), 7 deletions(-))
Terraform Beta: Diff ( 5 files changed, 116 insertions(+), 7 deletions(-))

@rileykarson
Copy link
Member

Hmm -let me try that again, the bot should have commented.

/gcbrun

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 116 insertions(+), 7 deletions(-))
Terraform Beta: Diff ( 5 files changed, 116 insertions(+), 7 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceComputeAddress|TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccAssuredWorkloadsWorkload_FullHandWritten|TestAccCloudFunctionsFunction_vpcConnector|TestAccComputeFirewallPolicyRule_update|TestAccComputeForwardingRule_update|TestAccComputeInstanceFromMachineImage_basic|TestAccComputeInstanceFromMachineImage_overrideMetadataDotStartupScript|TestAccComputeInstanceFromMachineImage_diffProject|TestAccComputeOrganizationSecurityPolicyAssociation_organizationSecurityPolicyAssociationBasicExample|TestAccComputeOrganizationSecurityPolicy_organizationSecurityPolicyUpdateExample|TestAccComputeOrganizationSecurityPolicyRule_organizationSecurityPolicyRuleUpdateExample|TestAccRegionInstanceGroupManager_stateful|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupAppengineExample|TestAccComputeRegionPerInstanceConfig_update|TestAccComputeRouterPeer_bfd|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccContainerCluster_withNodePoolResize|TestAccContainerNodePool_withWorkloadIdentityConfig|TestAccContainerNodePool_withGPU|TestAccContainerNodePool_gcfsConfig|TestAccContainerNodePool_ephemeralStorageConfig|TestAccContainerNodePool_resize|TestAccServiceNetworkingPeeredDNSDomain_basic|TestAccNotebooksInstance_notebookInstanceFullExample|TestAccNotebooksInstance_create_vm_image|TestAccNotebooksInstance_update|TestAccSqlDatabaseInstance_withPrivateNetwork|TestAccSqlUser_postgresIAM|TestAccStorageDefaultObjectAcl_basic|TestAccStorageDefaultObjectAcl_noRoleEntity|TestAccStorageDefaultObjectAcl_upgrade|TestAccStorageDefaultObjectAcl_downgrade|TestAccStorageDefaultObjectAcl_unordered You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=215087

@rileykarson
Copy link
Member

rileykarson commented Nov 4, 2021

Hmm- not sure how I feel about a couple of the errors that persisted after the recording step, running a test (https://ci-oss.hashicorp.engineering/buildConfiguration/GoogleCloudBeta_ProviderGoogleCloudBetaMmUpstream/215428?buildTab=overview)

They're not related to the GKE changes, but could be a result of the client update.

@rileykarson
Copy link
Member

Didn't fail on a subsequent run. Weird!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants