-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google Container Filesystem (GCFS) configuration support #5398
Conversation
…ailable. Add test functions and documentation.
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @rileykarson, please review this PR or find an appropriate assignee. |
Some of the checks are likely failing due to needing: |
We'll need to update the copied |
/gcbrun |
Hmm -let me try that again, the bot should have commented. /gcbrun |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceComputeAddress|TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccAssuredWorkloadsWorkload_FullHandWritten|TestAccCloudFunctionsFunction_vpcConnector|TestAccComputeFirewallPolicyRule_update|TestAccComputeForwardingRule_update|TestAccComputeInstanceFromMachineImage_basic|TestAccComputeInstanceFromMachineImage_overrideMetadataDotStartupScript|TestAccComputeInstanceFromMachineImage_diffProject|TestAccComputeOrganizationSecurityPolicyAssociation_organizationSecurityPolicyAssociationBasicExample|TestAccComputeOrganizationSecurityPolicy_organizationSecurityPolicyUpdateExample|TestAccComputeOrganizationSecurityPolicyRule_organizationSecurityPolicyRuleUpdateExample|TestAccRegionInstanceGroupManager_stateful|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupAppengineExample|TestAccComputeRegionPerInstanceConfig_update|TestAccComputeRouterPeer_bfd|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccContainerCluster_withNodePoolResize|TestAccContainerNodePool_withWorkloadIdentityConfig|TestAccContainerNodePool_withGPU|TestAccContainerNodePool_gcfsConfig|TestAccContainerNodePool_ephemeralStorageConfig|TestAccContainerNodePool_resize|TestAccServiceNetworkingPeeredDNSDomain_basic|TestAccNotebooksInstance_notebookInstanceFullExample|TestAccNotebooksInstance_create_vm_image|TestAccNotebooksInstance_update|TestAccSqlDatabaseInstance_withPrivateNetwork|TestAccSqlUser_postgresIAM|TestAccStorageDefaultObjectAcl_basic|TestAccStorageDefaultObjectAcl_noRoleEntity|TestAccStorageDefaultObjectAcl_upgrade|TestAccStorageDefaultObjectAcl_downgrade|TestAccStorageDefaultObjectAcl_unordered You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=215087 |
Hmm- not sure how I feel about a couple of the errors that persisted after the recording step, running a test (https://ci-oss.hashicorp.engineering/buildConfiguration/GoogleCloudBeta_ProviderGoogleCloudBetaMmUpstream/215428?buildTab=overview) They're not related to the GKE changes, but could be a result of the client update. |
Didn't fail on a subsequent run. Weird! |
Google Container Filesysem (GCFS) recently went GA and GcfsConfig is now available with the release of google-api-go-client v0.60.0:
https://github.com/googleapis/google-api-go-client/releases/tag/v0.60.0
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)