Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retries on unready subnetworks #5418

Merged

Conversation

rileykarson
Copy link
Member

@rileykarson rileykarson commented Nov 3, 2021

This is a pretty common error from the API these days, I suspect because there are more and more advanced subnetwork features. This probably happens to use more than our users- we run a massive number of operations at once in a single project, and are fairly likely to hit this issue in any given night (or apparently to hit it 60 times, like last night)

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

provider: added retries for the `resourceNotReady` error returned when attempting to add resources to a recently-modified subnetwork

@rileykarson rileykarson requested review from a team and slevenick and removed request for a team November 3, 2021 17:40
@google-cla google-cla bot added the cla: yes label Nov 3, 2021
@rileykarson rileykarson requested review from a team, nat-henderson and c2thorn and removed request for slevenick, a team and nat-henderson November 3, 2021 17:40
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 19 insertions(+))
Terraform Beta: Diff ( 1 file changed, 19 insertions(+))
TF Validator: Diff ( 1 file changed, 19 insertions(+))

@rileykarson
Copy link
Member Author

/gcbrun (for vcr)

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 19 insertions(+))
Terraform Beta: Diff ( 1 file changed, 19 insertions(+))
TF Validator: Diff ( 1 file changed, 19 insertions(+))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants