-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Network queue count support #5438
Network queue count support #5438
Conversation
/gcbrun |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccCloudFunctionsFunction_vpcConnector|TestAccComputeInstanceFromMachineImage_basic|TestAccComputeInstanceFromMachineImage_overrideMetadataDotStartupScript|TestAccComputeInstanceFromMachineImage_diffProject|TestAccComputeInstanceTemplate_queueCount|TestAccComputeInstance_queueCount|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupAppengineExample|TestAccSqlUser_postgresIAM You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=217052 |
Tests failed during RECORDING mode: TestAccComputeInstanceFromMachineImage_overrideMetadataDotStartupScript|TestAccComputeInstanceFromMachineImage_basic|TestAccComputeInstanceFromMachineImage_diffProject|TestAccCloudFunctionsFunction_vpcConnector|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupAppengineExample|TestAccSqlUser_postgresIAM Please fix these to complete your PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems reasonable. The failing tests in VCR seem unrelated. It looks like it breaks the TFV downstream; it's possible that updating the downstream tests to include this field new field in their test data might be sufficient but it may be that we need to update the TPG dependency downstream (in which case we would have to merge this first and update afterward).
It would be great if you could try to get the downstream working prior to merge.
Upgrading the version of TPG seems to fix it:
|
@slevenick great! 👍 would you like to make the downstream PR to do the upgrade? It basically requires adding a commit like hashicorp/terraform-provider-google@61e7a79 to a fork of the release branch you want to upgrade to, then using |
Yeah, I can do that. It requires merging this PR first and then making the release & upgrading TFV right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, you'd have to fix the downstream after the next release (or at least after the next release is cut) so this would need to be merged first.
* Add queue_number * Add network queue * Remove update test, add to instance template
Fixes: hashicorp/terraform-provider-google#9847
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)