Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add integration tests for validator to pipeline #5498

Merged
merged 3 commits into from
Nov 30, 2021
Merged

add integration tests for validator to pipeline #5498

merged 3 commits into from
Nov 30, 2021

Conversation

ScottSuarez
Copy link
Contributor

Release Note Template for Downstream PRs (will be copied)

@google-cla google-cla bot added the cla: yes label Nov 30, 2021
melinath
melinath approved these changes Nov 30, 2021
View reviewed changes
Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm apart from the one issue; I wonder if this might be time for us to make a shared bash functions file for handling posting comments and checking for go changes and whatnot

@ScottSuarez ScottSuarez merged commit 63513b3 into GoogleCloudPlatform:master Nov 30, 2021
@ScottSuarez ScottSuarez deleted the validator-tests-ci branch November 30, 2021 23:29
@ScottSuarez ScottSuarez mentioned this pull request Jan 6, 2022
Closed
betsy-lichtenberg pushed a commit to betsy-lichtenberg/magic-modules that referenced this pull request Apr 25, 2022
@ScottSuarez @betsy-lichtenberg
add integration tests for validator to pipeline (GoogleCloudPlatform#…
1aa217a 
…5498)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melinath melinath melinath approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ScottSuarez @melinath