Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made billing budget filter labels updatable #5545

Merged
merged 1 commit into from
Dec 16, 2021
Merged

Made billing budget filter labels updatable #5545

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions mmv1/products/billingbudget/terraform.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ overrides: !ruby/object:Overrides::ResourceOverrides
default_from_api: true
update_mask_fields:
- "budgetFilter.projects"
- "budgetFilter.labels"
budgetFilter.services: !ruby/object:Overrides::Terraform::PropertyOverride
default_from_api: true
budgetFilter.subaccounts: !ruby/object:Overrides::Terraform::PropertyOverride
Expand Down
7 changes: 7 additions & 0 deletions mmv1/third_party/terraform/tests/resource_billing_budget_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,9 @@ resource "google_billing_budget" "budget" {
budget_filter {
projects = ["projects/${data.google_project.project.number}"]
labels = {
label = "bar"
}
}
amount {
Expand Down Expand Up @@ -173,6 +176,7 @@ resource "google_billing_budget" "budget" {
budget_filter {
projects = []
labels = {}
}
amount {
Expand Down Expand Up @@ -218,6 +222,9 @@ resource "google_billing_budget" "budget" {
budget_filter {
projects = []
labels = {
label1 = "bar2"
}
}
amount {
Expand Down