Added maintenancePolicy attribute to redis instance

[jaceq]

Signed-off-by: Jacek Kikiewicz public@kikiewicz.com

Adds maintenance_policy as well as maintenance_schedule to redis instance.
Resolves: hashicorp/terraform-provider-google#9727

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

redis: added `maintenance_policy` and `maintenance_schedule` to `google_redis_instance`

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@ScottSuarez, please review this PR or find an appropriate assignee.

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 674 insertions(+))
Terraform Beta: Diff ( 4 files changed, 696 insertions(+), 22 deletions(-))
TF Validator: Diff ( 1 file changed, 214 insertions(+))
TF OiCS: Diff ( 1 file changed, 12 insertions(+))

[ScottSuarez]

/gcbrun

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 692 insertions(+), 18 deletions(-))
Terraform Beta: Diff ( 4 files changed, 692 insertions(+), 18 deletions(-))
TF Validator: Diff ( 1 file changed, 214 insertions(+))
TF OiCS: Diff ( 1 file changed, 12 insertions(+))

[jaceq]

Hi @ScottSuarez any update here?

[kwilczynski]

Hi @jaceq,

Thank you for working on this! Much appreciated!

@ScottSuarez, sorry to bother you, but would you have some time to review this patch? Having a proper maintenance policy support is something that a lot of organisations would be keen to have, I am quite positive. I have been looking for this myself before @jaceq's work here.

[ScottSuarez]

/gcbrun

[ScottSuarez]

some comments

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 674 insertions(+))
Terraform Beta: Diff ( 3 files changed, 674 insertions(+))
TF Validator: Diff ( 1 file changed, 214 insertions(+))
TF OiCS: Diff ( 1 file changed, 12 insertions(+))

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccApigeeEnvironmentIamMemberGenerated|TestAccApigeeEnvironmentIamPolicyGenerated|TestAccCloudFunctionsFunction_vpcConnector|TestAccComposerEnvironment_ComposerV2|TestAccComputeBackendService_withBackend|TestAccComputeBackendService_withBackendAndMaxUtilization|TestAccComputeBackendService_withBackendAndIAP|TestAccComputeBackendService_withMaxConnections|TestAccComputeBackendService_withMaxConnectionsPerInstance|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccInstanceGroupManager_basic|TestAccInstanceGroupManager_targetSizeZero|TestAccInstanceGroupManager_update|TestAccInstanceGroupManager_versions|TestAccInstanceGroupManager_autoHealingPolicies|TestAccInstanceGroupManager_stateful|TestAccInstanceGroupManager_waitForStatus|TestAccComputePerInstanceConfig_update|TestAccComputeRegionAutoscaler_update|TestAccComputeRegionAutoscaler_scaleDownControl|TestAccComputeRegionAutoscaler_scalingSchedule|TestAccComputeRegionAutoscaler_scaleInControl|TestAccComputeRegionBackendService_withBackendInternal|TestAccComputeRegionBackendService_withBackendInternalManaged|TestAccComputeRegionBackendService_withBackendMultiNic|TestAccRegionInstanceGroupManager_basic|TestAccRegionInstanceGroupManager_targetSizeZero|TestAccRegionInstanceGroupManager_update|TestAccRegionInstanceGroupManager_versions|TestAccRegionInstanceGroupManager_autoHealingPolicies|TestAccRegionInstanceGroupManager_distributionPolicy|TestAccRegionInstanceGroupManager_stateful|TestAccComputeRegionPerInstanceConfig_update|TestAccContainerNodePool_withInvalidUpgradeSettings|TestAccServiceNetworkingPeeredDNSDomain_basic|TestAccOSConfigPatchDeployment_osConfigPatchDeploymentBasicExample|TestAccOSConfigPatchDeployment_osConfigPatchDeploymentInstanceExample|TestAccOSConfigPatchDeployment_osConfigPatchDeploymentFullExample|TestAccRedisInstance_redisInstanceFullExample You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=237988

[ScottSuarez]

Everything looks good except for my last comments

[jaceq]

@ScottSuarez Made requested corrections - thanks for feedback.

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 692 insertions(+), 22 deletions(-))
Terraform Beta: Diff ( 3 files changed, 670 insertions(+))
TF Validator: Diff ( 1 file changed, 214 insertions(+))
TF OiCS: Diff ( 1 file changed, 12 insertions(+))

[ScottSuarez]

/gcbrun

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 670 insertions(+))
Terraform Beta: Diff ( 3 files changed, 670 insertions(+))
TF Validator: Diff ( 1 file changed, 214 insertions(+))
TF OiCS: Diff ( 1 file changed, 12 insertions(+))

[jaceq]

@ScottSuarez any update here?

[ScottSuarez]

I'm going to take a deeper look at this tomorrow. I have a good idea of whats going wrong and how to remedy it

[ScottSuarez]

okay I have a change that should unblock this #5641

talking to my coworker about it later today

[ScottSuarez]

/gcbrun

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 671 insertions(+))
Terraform Beta: Diff ( 3 files changed, 671 insertions(+))
TF Validator: Diff ( 1 file changed, 214 insertions(+))
TF OiCS: Diff ( 1 file changed, 12 insertions(+))

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccApigeeEnvironmentIamBindingGenerated|TestAccApigeeEnvironmentIamMemberGenerated|TestAccApigeeEnvironmentIamPolicyGenerated|TestAccCloudRunService_cloudRunServiceSecretVolumesExample|TestAccContainerCluster_withDNSConfig|TestAccContainerNodePool_withInvalidUpgradeSettings|TestAccServiceNetworkingPeeredDNSDomain_basic|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccPrivatecaCertificate_privatecaCertificateConfigExample|TestAccPrivatecaCertificate_privatecaCertificateNoAuthorityExample You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=248093

[ScottSuarez]

lgtm, thanks for your patience here !