Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support to pass a default_mode and mode for secrets #5561

Merged
merged 15 commits into from
Jan 14, 2022

Conversation

jeremiele
Copy link
Contributor

@jeremiele jeremiele commented Dec 15, 2021

The change introduces default_mode at the secret volume level to specify the
default permissions for files within the volume while mode is introduced at the
item level to specify permissions for a specific file.

If this PR is for Terraform, I acknowledge that I have:

  • [ X ] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • [ X ] Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • [ X ] Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • [ X ] Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • [ X ] Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

cloudrun: added support for `default_mode` and `mode` settings for created files within `secrets` in `google_cloud_run_service`

…naged.

The integration enables binding secret values to environment variables or
to the content of files.
The change introduces default_mode at the secret volume level to specify the
default permissions for files within the volume while mode is introduced at the
item level to specify permissions for a specific file.
…naged.

The integration enables binding secret values to environment variables or
to the content of files.
…naged.

The integration enables binding secret values to environment variables or
to the content of files.
Moves the support for environment variables and filesystem based secrets from
beta to ga since the feature is now generally available.
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@slevenick, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 111 insertions(+), 18 deletions(-))
Terraform Beta: Diff ( 4 files changed, 115 insertions(+), 22 deletions(-))
TF Validator: Diff ( 1 file changed, 22 insertions(+))

@slevenick
Copy link
Contributor

/gcbrun

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 111 insertions(+), 18 deletions(-))
Terraform Beta: Diff ( 3 files changed, 93 insertions(+))
TF Validator: Diff ( 1 file changed, 22 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccApigeeEnvironmentIamBindingGenerated|TestAccApigeeEnvironmentIamPolicyGenerated|TestAccCloudRunService_cloudRunServiceSecretVolumesExample|TestAccCloudFunctionsFunction_vpcConnector|TestAccComputeForwardingRule_update|TestAccContainerNodePool_withInvalidUpgradeSettings You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=232315

@jeremiele
Copy link
Contributor Author

Hello and happy new year!

I was wondering if there was a timeline for this change to be reviewed?

Thanks a lot!

Copy link
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, this looks good!

@slevenick slevenick merged commit a59445e into GoogleCloudPlatform:master Jan 14, 2022
lcaggio pushed a commit to lcaggio/magic-modules that referenced this pull request Mar 16, 2022
…dPlatform#5561)

* Added support for the integration with Secret Manager in Cloud Run Managed.
The integration enables binding secret values to environment variables or
to the content of files.

* Revert "Added support for the integration with Secret Manager in Cloud Run Managed."

This reverts commit 2170b50.

* Added support to pass a default_mode and mode for secrets.

The change introduces default_mode at the secret volume level to specify the
default permissions for files within the volume while mode is introduced at the
item level to specify permissions for a specific file.

* Added support for the integration with Secret Manager in Cloud Run Managed.
The integration enables binding secret values to environment variables or
to the content of files.

* Revert "Added support for the integration with Secret Manager in Cloud Run Managed."

This reverts commit 2170b50.

* Added support for the integration with Secret Manager in Cloud Run Managed.
The integration enables binding secret values to environment variables or
to the content of files.

* Revert "Added support for the integration with Secret Manager in Cloud Run Managed."

This reverts commit 2170b50.

* Moved Cloud Run secret support to ga.

Moves the support for environment variables and filesystem based secrets from
beta to ga since the feature is now generally available.

* Removed unncessary changes to cloudrun api.yaml.

* Fixed lines in cloudrun api.yaml.

* Removed redundant required: false.

* Removed empty section in volume example.
lcaggio pushed a commit to lcaggio/magic-modules that referenced this pull request Mar 17, 2022
…dPlatform#5561)

* Added support for the integration with Secret Manager in Cloud Run Managed.
The integration enables binding secret values to environment variables or
to the content of files.

* Revert "Added support for the integration with Secret Manager in Cloud Run Managed."

This reverts commit 2170b50.

* Added support to pass a default_mode and mode for secrets.

The change introduces default_mode at the secret volume level to specify the
default permissions for files within the volume while mode is introduced at the
item level to specify permissions for a specific file.

* Added support for the integration with Secret Manager in Cloud Run Managed.
The integration enables binding secret values to environment variables or
to the content of files.

* Revert "Added support for the integration with Secret Manager in Cloud Run Managed."

This reverts commit 2170b50.

* Added support for the integration with Secret Manager in Cloud Run Managed.
The integration enables binding secret values to environment variables or
to the content of files.

* Revert "Added support for the integration with Secret Manager in Cloud Run Managed."

This reverts commit 2170b50.

* Moved Cloud Run secret support to ga.

Moves the support for environment variables and filesystem based secrets from
beta to ga since the feature is now generally available.

* Removed unncessary changes to cloudrun api.yaml.

* Fixed lines in cloudrun api.yaml.

* Removed redundant required: false.

* Removed empty section in volume example.
betsy-lichtenberg pushed a commit to betsy-lichtenberg/magic-modules that referenced this pull request Apr 25, 2022
…dPlatform#5561)

* Added support for the integration with Secret Manager in Cloud Run Managed.
The integration enables binding secret values to environment variables or
to the content of files.

* Revert "Added support for the integration with Secret Manager in Cloud Run Managed."

This reverts commit 2170b50.

* Added support to pass a default_mode and mode for secrets.

The change introduces default_mode at the secret volume level to specify the
default permissions for files within the volume while mode is introduced at the
item level to specify permissions for a specific file.

* Added support for the integration with Secret Manager in Cloud Run Managed.
The integration enables binding secret values to environment variables or
to the content of files.

* Revert "Added support for the integration with Secret Manager in Cloud Run Managed."

This reverts commit 2170b50.

* Added support for the integration with Secret Manager in Cloud Run Managed.
The integration enables binding secret values to environment variables or
to the content of files.

* Revert "Added support for the integration with Secret Manager in Cloud Run Managed."

This reverts commit 2170b50.

* Moved Cloud Run secret support to ga.

Moves the support for environment variables and filesystem based secrets from
beta to ga since the feature is now generally available.

* Removed unncessary changes to cloudrun api.yaml.

* Fixed lines in cloudrun api.yaml.

* Removed redundant required: false.

* Removed empty section in volume example.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants