-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support to pass a default_mode and mode for secrets #5561
Conversation
…naged. The integration enables binding secret values to environment variables or to the content of files.
…d Run Managed." This reverts commit 2170b50.
The change introduces default_mode at the secret volume level to specify the default permissions for files within the volume while mode is introduced at the item level to specify permissions for a specific file.
…naged. The integration enables binding secret values to environment variables or to the content of files.
…d Run Managed." This reverts commit 2170b50.
…naged. The integration enables binding secret values to environment variables or to the content of files.
…d Run Managed." This reverts commit 2170b50.
Moves the support for environment variables and filesystem based secrets from beta to ga since the feature is now generally available.
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @slevenick, please review this PR or find an appropriate assignee. |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 4 files changed, 111 insertions(+), 18 deletions(-)) |
/gcbrun |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccApigeeEnvironmentIamBindingGenerated|TestAccApigeeEnvironmentIamPolicyGenerated|TestAccCloudRunService_cloudRunServiceSecretVolumesExample|TestAccCloudFunctionsFunction_vpcConnector|TestAccComputeForwardingRule_update|TestAccContainerNodePool_withInvalidUpgradeSettings You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=232315 |
Hello and happy new year! I was wondering if there was a timeline for this change to be reviewed? Thanks a lot! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, this looks good!
…dPlatform#5561) * Added support for the integration with Secret Manager in Cloud Run Managed. The integration enables binding secret values to environment variables or to the content of files. * Revert "Added support for the integration with Secret Manager in Cloud Run Managed." This reverts commit 2170b50. * Added support to pass a default_mode and mode for secrets. The change introduces default_mode at the secret volume level to specify the default permissions for files within the volume while mode is introduced at the item level to specify permissions for a specific file. * Added support for the integration with Secret Manager in Cloud Run Managed. The integration enables binding secret values to environment variables or to the content of files. * Revert "Added support for the integration with Secret Manager in Cloud Run Managed." This reverts commit 2170b50. * Added support for the integration with Secret Manager in Cloud Run Managed. The integration enables binding secret values to environment variables or to the content of files. * Revert "Added support for the integration with Secret Manager in Cloud Run Managed." This reverts commit 2170b50. * Moved Cloud Run secret support to ga. Moves the support for environment variables and filesystem based secrets from beta to ga since the feature is now generally available. * Removed unncessary changes to cloudrun api.yaml. * Fixed lines in cloudrun api.yaml. * Removed redundant required: false. * Removed empty section in volume example.
…dPlatform#5561) * Added support for the integration with Secret Manager in Cloud Run Managed. The integration enables binding secret values to environment variables or to the content of files. * Revert "Added support for the integration with Secret Manager in Cloud Run Managed." This reverts commit 2170b50. * Added support to pass a default_mode and mode for secrets. The change introduces default_mode at the secret volume level to specify the default permissions for files within the volume while mode is introduced at the item level to specify permissions for a specific file. * Added support for the integration with Secret Manager in Cloud Run Managed. The integration enables binding secret values to environment variables or to the content of files. * Revert "Added support for the integration with Secret Manager in Cloud Run Managed." This reverts commit 2170b50. * Added support for the integration with Secret Manager in Cloud Run Managed. The integration enables binding secret values to environment variables or to the content of files. * Revert "Added support for the integration with Secret Manager in Cloud Run Managed." This reverts commit 2170b50. * Moved Cloud Run secret support to ga. Moves the support for environment variables and filesystem based secrets from beta to ga since the feature is now generally available. * Removed unncessary changes to cloudrun api.yaml. * Fixed lines in cloudrun api.yaml. * Removed redundant required: false. * Removed empty section in volume example.
…dPlatform#5561) * Added support for the integration with Secret Manager in Cloud Run Managed. The integration enables binding secret values to environment variables or to the content of files. * Revert "Added support for the integration with Secret Manager in Cloud Run Managed." This reverts commit 2170b50. * Added support to pass a default_mode and mode for secrets. The change introduces default_mode at the secret volume level to specify the default permissions for files within the volume while mode is introduced at the item level to specify permissions for a specific file. * Added support for the integration with Secret Manager in Cloud Run Managed. The integration enables binding secret values to environment variables or to the content of files. * Revert "Added support for the integration with Secret Manager in Cloud Run Managed." This reverts commit 2170b50. * Added support for the integration with Secret Manager in Cloud Run Managed. The integration enables binding secret values to environment variables or to the content of files. * Revert "Added support for the integration with Secret Manager in Cloud Run Managed." This reverts commit 2170b50. * Moved Cloud Run secret support to ga. Moves the support for environment variables and filesystem based secrets from beta to ga since the feature is now generally available. * Removed unncessary changes to cloudrun api.yaml. * Fixed lines in cloudrun api.yaml. * Removed redundant required: false. * Removed empty section in volume example.
The change introduces default_mode at the secret volume level to specify the
default permissions for files within the volume while mode is introduced at the
item level to specify permissions for a specific file.
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)