Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade ACM version in test #5567

Merged
merged 2 commits into from
Dec 22, 2021
Merged

Conversation

shuyama1
Copy link
Member

@shuyama1 shuyama1 commented Dec 20, 2021

It appears that ACM versions < 1.7.0 are deprecated through acm hub controller, so upgrade the version to 1.7.0 in tests.
This fixes hashicorp/terraform-provider-google#10304.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

gke_hub: Only ACM versions >= 1.7.0 are supported and should be used in `version` field in `google_gke_hub_feature_membership`.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 40 insertions(+), 40 deletions(-))
Terraform Beta: Diff ( 1 file changed, 9 insertions(+), 9 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccApigeeEnvironmentIamBindingGenerated|TestAccApigeeEnvironmentIamMemberGenerated|TestAccApigeeEnvironmentIamPolicyGenerated|TestAccCloudFunctionsFunction_vpcConnector|TestAccContainerNodePool_withInvalidUpgradeSettings|TestAccServiceNetworkingPeeredDNSDomain_basic You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=233995

@modular-magician
Copy link
Collaborator

Tests failed during RECORDING mode: TestAccCloudFunctionsFunction_vpcConnector|TestAccContainerNodePool_withInvalidUpgradeSettings Please fix these to complete your PR

@shuyama1
Copy link
Member Author

@shuyama1 shuyama1 requested review from modular-magician, a team and ScottSuarez and removed request for modular-magician and a team December 21, 2021 20:32
@ScottSuarez
Copy link
Contributor

Should we pin it at version 1.9 so that this doesn't reoccur soon. I worry 1.7 could be also deprecated sometime.

@shuyama1
Copy link
Member Author

shuyama1 commented Dec 21, 2021

Should we pin it at version 1.9 so that this doesn't reoccur soon. I worry 1.7 could be also deprecated sometime.

Good point! Will work on it!

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform Beta: Diff ( 1 file changed, 9 insertions(+), 9 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccApigeeEnvironmentIamBindingGenerated|TestAccApigeeEnvironmentIamMemberGenerated|TestAccApigeeEnvironmentIamPolicyGenerated|TestAccCloudFunctionsFunction_vpcConnector|TestAccComputeForwardingRule_update|TestAccContainerNodePool_withInvalidUpgradeSettings|TestAccServiceNetworkingPeeredDNSDomain_basic You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=234596

@shuyama1 shuyama1 merged commit ee1ecc1 into GoogleCloudPlatform:master Dec 22, 2021
@shuyama1 shuyama1 deleted the fix_10304 branch December 22, 2021 10:50
xuchenma pushed a commit to xuchenma/magic-modules that referenced this pull request Jan 7, 2022
betsy-lichtenberg pushed a commit to betsy-lichtenberg/magic-modules that referenced this pull request Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing test(s): TestAccGkeHubFeatureMembership_gkehubFeatureAcm
3 participants