fixed scenario where region_instance_group_manager would not start update
#5582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For autopilot clusters, the networking is pre-configured. With container
gen-client, we want to send `IPAllocationPolicy.UseIpAliases` and `IPAllocationPolicy.UseRoutes` as false,
so that the service can pick the default IP allocation mode [1].
Only when the `networkingMode` is specifically set to "ROUTES",
`IPAllocationPolicy.UseRoutes` is passed with true.
This change fixes the following error when apply an autopilot cluster
```
resource "google_container_cluster" "tf-cluster" {
name = "tf-cluster"
location = "europe-west1"
project = "my-project"
enable_autopilot = "true"
release_channel {
channel = "REGULAR"
}
min_master_version = "1.21.5-gke.1302"
}
```
```
zgoogle_container_cluster.tf-cluster: Creating...
Error: googleapi: Error 400: Max pods constraint on node pools for Autopilot clusters should be 32., badRequest
on container_cluster.tf line 1, in resource "google_container_cluster" "tf-cluster":
1: resource "google_container_cluster" "tf-cluster" {
```
…-modules into fix-update-issue-for-region-igm
|
What's up w/ the PR title and history? |
ScottSuarez
changed the title
region_instance_group_manager would not start update
|
ooops, yes I branched this from another change I was working on and had to go about scrubbing that from the branch. I updated the title |
|
Do you mind isolating the change to a single commit as well? It probably won't matter w/ squash, but I've found branches with merges to be a little funky sometimes. |
|
sure @rileykarson closing this in favor of #5584 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes hashicorp/terraform-provider-google#10648 and hashicorp/terraform-provider-google#10792
duplicate pr of #5506 just against RIGM
Release Note Template for Downstream PRs (will be copied)