Network Connectivity Spoke

[c2thorn]

Closes hashicorp/terraform-provider-google#10514

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_network_connectivity_spoke`

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 221 insertions(+))
Terraform Beta: Diff ( 7 files changed, 1194 insertions(+), 22 deletions(-))

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccApigeeEnvironmentIamBindingGenerated|TestAccApigeeEnvironmentIamMemberGenerated|TestAccApigeeEnvironmentIamPolicyGenerated|TestAccContainerNodePool_withInvalidUpgradeSettings|TestAccServiceNetworkingPeeredDNSDomain_basic|TestAccNetworkConnectivitySpoke_RouterApplianceHandWritten You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=237603

[modular-magician]

Tests failed during RECORDING mode: TestAccApigeeEnvironmentIamBindingGenerated|TestAccContainerNodePool_withInvalidUpgradeSettings Please fix these to complete your PR

[c2thorn]

I ran make test and make lint on the generated downstream and couldn't figure out why they are failing in Cloudbuild. The logs are impossible to read right now with the Validator tests included

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 1172 insertions(+))
Terraform Beta: Diff ( 6 files changed, 1172 insertions(+))

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccApigeeEnvironmentIamBindingGenerated|TestAccApigeeEnvironmentIamMemberGenerated|TestAccApigeeEnvironmentIamPolicyGenerated|TestAccContainerNodePool_withInvalidUpgradeSettings You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=237977

[modular-magician]

Tests failed during RECORDING mode: TestAccContainerNodePool_withInvalidUpgradeSettings|TestAccApigeeEnvironmentIamBindingGenerated Please fix these to complete your PR

[slevenick]

Is basic_hub.id not valid for this?

[slevenick]

Looks like the name field at least has an incorrect format in the documentation

[slevenick]

I would also argue that the use of URIs in the documentation is incorrect. Many fields claim to require URIs, but they don't appear to actually require URIs. I don't think that resource long name == URI

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 1171 insertions(+))
Terraform Beta: Diff ( 7 files changed, 1189 insertions(+), 18 deletions(-))

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccApigeeEnvironmentIamBindingGenerated|TestAccApigeeEnvironmentIamMemberGenerated|TestAccApigeeEnvironmentIamPolicyGenerated|TestAccContainerNodePool_withInvalidUpgradeSettings|TestAccServiceNetworkingPeeredDNSDomain_basic|TestAccOsConfigOsPolicyAssignment_FixedOsPolicyAssignment|TestAccOsConfigOsPolicyAssignment_PercentOsPolicyAssignment You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=240664

[slevenick]

These should be upstreamed to the DCL rather than overrides specifically in Terraform I believe

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 9 files changed, 1194 insertions(+), 21 deletions(-))
Terraform Beta: Diff ( 8 files changed, 1176 insertions(+), 3 deletions(-))

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccApigeeEnvironmentIamBindingGenerated|TestAccApigeeEnvironmentIamMemberGenerated|TestAccCloudbuildWorkerPool_basic|TestAccComputeForwardingRule_update|TestAccContainerNodePool_withInvalidUpgradeSettings|TestAccServiceNetworkingPeeredDNSDomain_basic You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=241918

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 9 files changed, 1168 insertions(+), 21 deletions(-))
Terraform Beta: Diff ( 9 files changed, 1190 insertions(+), 43 deletions(-))

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccApigeeEnvironmentIamBindingGenerated|TestAccApigeeEnvironmentIamMemberGenerated|TestAccApigeeEnvironmentIamPolicyGenerated|TestAccCloudbuildWorkerPool_basic|TestAccContainerNodePool_withInvalidUpgradeSettings|TestAccNetworkConnectivitySpoke_RouterApplianceHandWritten You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=242312

[modular-magician]

Tests failed during RECORDING mode: TestAccCloudbuildWorkerPool_basic|TestAccContainerNodePool_withInvalidUpgradeSettings Please fix these to complete your PR

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 12 files changed, 3197 insertions(+), 916 deletions(-))
Terraform Beta: Diff ( 12 files changed, 3201 insertions(+), 920 deletions(-))

[c2thorn]

@slevenick there are large diffs for OSConfig because the DCL removed reused types in the resource and wrote out the fields regularly. I believe the end result is the same

[slevenick]

@slevenick there are large diffs for OSConfig because the DCL removed reused types in the resource and wrote out the fields regularly. I believe the end result is the same

Cool, as long as those tests still pass it should be fine

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccApigeeEnvironmentIamBindingGenerated|TestAccApigeeEnvironmentIamMemberGenerated|TestAccCloudbuildWorkerPool_basic|TestAccContainerNodePool_withInvalidUpgradeSettings|TestAccDataLossPreventionDeidentifyTemplate_dlpDeidentifyTemplateSkipCharactersExample You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=243864

[modular-magician]

Tests failed during RECORDING mode: TestAccCloudbuildWorkerPool_basic|TestAccContainerNodePool_withInvalidUpgradeSettings Please fix these to complete your PR