-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove computed keys from json #5595
Conversation
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccApigeeEnvironmentIamBindingGenerated|TestAccApigeeEnvironmentIamMemberGenerated|TestAccApigeeEnvironmentIamPolicyGenerated|TestAccContainerCluster_withBootDiskKmsKey|TestAccContainerNodePool_withInvalidUpgradeSettings|TestAccServiceNetworkingPeeredDNSDomain_basic|TestAccTags You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=240047 |
Tests failed during RECORDING mode: TestAccTags|TestAccServiceNetworkingPeeredDNSDomain_basic|TestAccContainerNodePool_withInvalidUpgradeSettings Please fix these to complete your PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changes the resource behaviour, given that fields not in config won't appear anymore so drift detection on them won't work. Do you feel this could be a breaking change? Should we document it in a warning on the resource?
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccApigeeEnvironmentIamBindingGenerated|TestAccApigeeEnvironmentIamMemberGenerated|TestAccApigeeEnvironmentIamPolicyGenerated|TestAccContainerNodePool_withInvalidUpgradeSettings|TestAccOsConfigOsPolicyAssignment_FixedOsPolicyAssignment|TestAccOsConfigOsPolicyAssignment_PercentOsPolicyAssignment You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=240549 |
Tests failed during RECORDING mode: TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccContainerNodePool_withInvalidUpgradeSettings Please fix these to complete your PR |
@rileykarson @megan07 what is the status of this PR? |
Ah, we'd lost track of this- @c2thorn can you take a look? |
This is targeted for 5.0.0 release, but will need someone to take it over and rebase. I'll tentatively take it. |
closing in favor of #9065 |
Fixes hashicorp/terraform-provider-google#9976
Fixes hashicorp/terraform-provider-google#7242 as well, I think
I chose this approach because that second issue seemed to show there were more fields than just the one showing up in the test that were computed, and I think this should cover them all, but it's also possible I'm overlooking a potential issue.
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)