vpc access connector use self_link or name

[drandell]

This change allows users to supply the self_link or name (instead of just name) to the vpc_access_connector resource.

fixes {https://github.com/hashicorp/terraform-provider-google/issues/8683}

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

vpc_access_connector: Updated field `network` to accept self_link or name

[modular-magician]

Oops! It looks like you're using an unknown release-note type in your changelog entries:

• REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@rileykarson, please review this PR or find an appropriate assignee.

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 12 insertions(+), 8 deletions(-))
Terraform Beta: Diff ( 2 files changed, 12 insertions(+), 8 deletions(-))
TF Validator: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

[drandell]

@rileykarson hi, I don't think I'll be able to run the acceptance tests. Hopefully did everything else correct but let me know if not

[rileykarson]

Actually, let me double-check the tests aren't unhappy first before merging

/gcbrun

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 12 insertions(+), 8 deletions(-))
Terraform Beta: Diff ( 2 files changed, 12 insertions(+), 8 deletions(-))
TF Validator: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccApigeeEnvironmentIamBindingGenerated|TestAccApigeeEnvironmentIamMemberGenerated|TestAccApigeeEnvironmentIamPolicyGenerated|TestAccCloudbuildWorkerPool_basic|TestAccContainerNodePool_withInvalidUpgradeSettings You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=248105

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 12 insertions(+), 8 deletions(-))
Terraform Beta: Diff ( 2 files changed, 12 insertions(+), 8 deletions(-))
TF Validator: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

[drandell]

I think those tests failed because i was out of date with master, but i've updated my branch (can't view that link but did a search and dont seem to see anything related).

[rileykarson]

Oh, the failures are unrelated! Merging.

Thanks for your contribution!