Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cloud Run Resource to make containerPort be optional #5677

Conversation

ccogan-lh
Copy link
Contributor

@ccogan-lh ccogan-lh commented Feb 3, 2022

Updating Cloud Run resource to mark containerPort as optional. Discovered this when I tried to specify h2c only and let GCP tell my app which port to use.

See documentation here - https://cloud.google.com/run/docs/reference/rest/v1/Container#ContainerPort

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

cloudrun: updated `containers.ports.container_port` to be optional instead of required on `google_cloud_run_service`

@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@megan07, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 10 insertions(+), 10 deletions(-))
Terraform Beta: Diff ( 2 files changed, 10 insertions(+), 10 deletions(-))
TF Validator: Diff ( 2 files changed, 10 insertions(+), 10 deletions(-))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 8 insertions(+), 8 deletions(-))
Terraform Beta: Diff ( 2 files changed, 8 insertions(+), 8 deletions(-))
TF Validator: Diff ( 2 files changed, 8 insertions(+), 8 deletions(-))

Copy link
Contributor

@megan07 megan07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@megan07
Copy link
Contributor

megan07 commented Feb 4, 2022

/gcbrun

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 8 insertions(+), 8 deletions(-))
Terraform Beta: Diff ( 2 files changed, 8 insertions(+), 8 deletions(-))
TF Validator: Diff ( 2 files changed, 8 insertions(+), 8 deletions(-))

@megan07 megan07 merged commit 1461e93 into GoogleCloudPlatform:master Feb 4, 2022
@ccogan-lh ccogan-lh deleted the update_cloud_run_container_port_requirement branch February 4, 2022 19:47
lcaggio pushed a commit to lcaggio/magic-modules that referenced this pull request Mar 16, 2022
lcaggio pushed a commit to lcaggio/magic-modules that referenced this pull request Mar 17, 2022
betsy-lichtenberg pushed a commit to betsy-lichtenberg/magic-modules that referenced this pull request Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants