-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Cloud Run Resource to make containerPort be optional #5677
Update Cloud Run Resource to make containerPort be optional #5677
Conversation
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @megan07, please review this PR or find an appropriate assignee. |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 2 files changed, 10 insertions(+), 10 deletions(-)) |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 2 files changed, 8 insertions(+), 8 deletions(-)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
/gcbrun |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 2 files changed, 8 insertions(+), 8 deletions(-)) |
…oudPlatform#5677) * change to optional per docs * fix formatting issues
…oudPlatform#5677) * change to optional per docs * fix formatting issues
…oudPlatform#5677) * change to optional per docs * fix formatting issues
Updating Cloud Run resource to mark containerPort as optional. Discovered this when I tried to specify h2c only and let GCP tell my app which port to use.
See documentation here - https://cloud.google.com/run/docs/reference/rest/v1/Container#ContainerPort
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)