Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded Eventarc trigger #5704

Merged
merged 2 commits into from
Feb 14, 2022
Merged

Upgraded Eventarc trigger #5704

merged 2 commits into from
Feb 14, 2022

Conversation

avinash84
Copy link
Contributor

@avinash84 avinash84 commented Feb 11, 2022

Upgrading Eventarc trigger

Changes-

  1. edits in field documentation

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

eventarc: changes in field documentation for eventarc_trigger resource

@modular-magician
Copy link
Collaborator

Oops! It looks like you're using an unknown release-note type in your changelog entries:

  • REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@c2thorn, please review this PR or find an appropriate assignee.

Co-authored-by: Cameron Thornton <camthornton@google.com>
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 11 insertions(+), 8 deletions(-))
Terraform Beta: Diff ( 5 files changed, 14 insertions(+), 10 deletions(-))
TF Validator: Diff ( 2 files changed, 5 insertions(+), 31 deletions(-))

@avinash84
Copy link
Contributor Author

/gcbrun

1 similar comment
@c2thorn
Copy link
Member

c2thorn commented Feb 14, 2022

/gcbrun

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 11 insertions(+), 8 deletions(-))
Terraform Beta: Diff ( 5 files changed, 14 insertions(+), 10 deletions(-))
TF Validator: Diff ( 2 files changed, 5 insertions(+), 31 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccApigeeEnvironmentIamBindingGenerated|TestAccApigeeEnvironmentIamMemberGenerated|TestAccCloudbuildWorkerPool_basic|TestAccComputeForwardingRule_update|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccEventarcTrigger_BasicHandWritten You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=256682

Copy link
Member

@c2thorn c2thorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly documentation fixes - also eventarc VCR test has passed. LGTM

@c2thorn c2thorn merged commit 2f178a5 into GoogleCloudPlatform:master Feb 14, 2022
slevenick added a commit that referenced this pull request Feb 22, 2022
slevenick added a commit that referenced this pull request Feb 23, 2022
lcaggio pushed a commit to lcaggio/magic-modules that referenced this pull request Mar 16, 2022
lcaggio pushed a commit to lcaggio/magic-modules that referenced this pull request Mar 16, 2022
lcaggio pushed a commit to lcaggio/magic-modules that referenced this pull request Mar 17, 2022
lcaggio pushed a commit to lcaggio/magic-modules that referenced this pull request Mar 17, 2022
betsy-lichtenberg pushed a commit to betsy-lichtenberg/magic-modules that referenced this pull request Apr 25, 2022
betsy-lichtenberg pushed a commit to betsy-lichtenberg/magic-modules that referenced this pull request Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants