-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add endpointAttachment in Apigee #5717
Conversation
Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @c2thorn, please review this PR or find an appropriate assignee. |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 5 files changed, 645 insertions(+), 2 deletions(-)) |
I ran the Terraform test case locally, and it was able to CREATE, GET, DELETE this resource. However the test returns this error:
I'm not sure what might go wrong here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am still working on reproducing your issue, but running into difficulties with rate limiting in our testing environment.
While that is pending, I can immediately identify an issue: the resource names in your example file will need to be wrapped in ruby tags and referenced in the terraform.yaml
.
This is for multiple reasons, but the primary one being so that we can append a random suffix to resource names to avoid collisions while testing our entire suite.
mmv1/templates/terraform/examples/apigee_endpoint_attachment_basic.tf.erb
Show resolved
Hide resolved
That might not be needed for Apigee resources, because for Apigee, each test creates its own GCP project, run the test, and delete the project. So collisions won't happen. I see tests for other Apigee resources are all written this way (no ruby tags). |
I updated |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 5 files changed, 660 insertions(+), 2 deletions(-)) |
/gcbrun |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 5 files changed, 660 insertions(+), 2 deletions(-)) |
Tests were added that did not run in TeamCity:
|
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccApigeeEnvironmentIamMemberGenerated|TestAccApigeeEnvironmentIamPolicyGenerated|TestAccCloudbuildWorkerPool_basic|TestAccComputeInstanceTemplate_reservationAffinities|TestAccContainerCluster_withAuthenticatorGroupsConfig You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=260291 |
VCR test passed from what is available, but apparently we need to skip VCR for the main test. Running the primary example test directly in our testing environment |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 5 files changed, 678 insertions(+), 2 deletions(-)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation LGTM, noting we still need to have a passing test, which is running now.
…s on compute service
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 5 files changed, 681 insertions(+), 2 deletions(-)) |
manual test succeeded! |
This PR adds a new resource EndpointAttachment in Apigee (hashicorp/terraform-provider-google#11118)
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)