Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataproc job - add presto config #5739

Merged

Conversation

DrFaust92
Copy link
Contributor

@DrFaust92 DrFaust92 commented Feb 23, 2022

Closes hashicorp/terraform-provider-google#11159

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

dataproc: adds `presto_config` to `dataproc_job`

@modular-magician
Copy link
Collaborator

Oops! It looks like you're using an unknown release-note type in your changelog entries:

  • REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@slevenick, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Oops! It looks like you're using an unknown release-note type in your changelog entries:

  • REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

1 similar comment
@modular-magician
Copy link
Collaborator

Oops! It looks like you're using an unknown release-note type in your changelog entries:

  • REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

@DrFaust92 DrFaust92 changed the title Dataproc job - add presto job Dataproc job - add presto config Feb 24, 2022
@DrFaust92 DrFaust92 force-pushed the dataproc-job-validations branch from 2f0ae97 to c140741 Compare February 24, 2022 07:25
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 233 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 3 files changed, 233 insertions(+), 6 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@DrFaust92 DrFaust92 marked this pull request as ready for review February 24, 2022 10:24
@slevenick
Copy link
Contributor

/gcbrun

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 233 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 3 files changed, 233 insertions(+), 6 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccCloudbuildWorkerPool_basic|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccDataprocJob_Presto You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=261584

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 231 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 3 files changed, 231 insertions(+), 6 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@DrFaust92
Copy link
Contributor Author

fixed failing acctest @slevenick

@slevenick
Copy link
Contributor

/gcbrun

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 231 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 3 files changed, 231 insertions(+), 6 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@DrFaust92
Copy link
Contributor Author

slevenick i cant see logs so cant tell where the error is 😢

@DrFaust92
Copy link
Contributor Author

I double checked with rebasing latest code base that tests pass:

--- PASS: TestAccDataprocJob_PySpark (208.71s)
--- PASS: TestAccDataprocJob_updatable (225.55s)
--- PASS: TestAccDataprocJob_Hive (229.52s)
--- PASS: TestAccDataprocJob_Pig (230.64s)
--- PASS: TestAccDataprocJob_SparkSql (231.17s)
--- PASS: TestAccDataprocJob_Hadoop (250.78s)
--- PASS: TestAccDataprocJob_Presto (258.64s)
--- PASS: TestAccDataprocJob_Spark (271.79s)

slevenick

@DrFaust92 DrFaust92 force-pushed the dataproc-job-validations branch from 59eca7d to 8d3adf5 Compare March 17, 2022 15:43
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 231 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 3 files changed, 231 insertions(+), 6 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@slevenick
Copy link
Contributor

/gcbrun

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 231 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 3 files changed, 231 insertions(+), 6 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccDataSourceSqlDatabaseInstance_basic|TestAccApikeysKey_AndroidKey|TestAccApikeysKey_BasicKey|TestAccApikeysKey_IosKey|TestAccApikeysKey_ServerKey|TestAccApikeysKey_MinimalKey|TestAccArtifactRegistryRepository_create_mvn_snapshot|TestAccArtifactRegistryRepository_create_mvn_release|TestAccBigqueryReservationAssignment_BasicHandWritten|TestAccCGCSnippet_sqlMysqlInstanceBackupExample|TestAccCGCSnippet_sqlPostgresInstanceBackupExample|TestAccCGCSnippet_sqlSqlserverInstanceBackupExample|TestAccCGCSnippet_sqlMysqlInstanceAuthorizedNetworkExample|TestAccCGCSnippet_sqlSqlserverInstanceBackupLocationExample|TestAccCloudBuildTrigger_cloudbuildTriggerPubsubConfigExample|TestAccCloudBuildTrigger_cloudbuildTriggerWebhookConfigExample|TestAccCloudBuildTrigger_cloudbuildTriggerManualExample|TestAccCloudBuildTrigger_cloudbuildTriggerFilenameExample|TestAccCloudBuildTrigger_cloudbuildTriggerBuildExample|TestAccCloudBuildTrigger_basic|TestAccCloudBuildTrigger_available_secrets_config|TestAccCloudBuildTrigger_cloudbuildTriggerServiceAccountExample|TestAccCloudBuildTrigger_fullStep|TestAccCloudBuildTrigger_disable|TestAccCloudFunctionsFunction_secretEnvVar|TestAccContainerAwsCluster_BasicHandWritten|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccContainerNodePool_gvnic|TestAccDataprocCluster_nonPreemptibleSecondary|TestAccDataprocCluster_updatable|TestAccDataprocCluster_withConfigOverrides|TestAccDataprocJob_Presto|TestAccLoggingLogView_BasicHandWritten|TestAccNetworkServicesEdgeCacheOrigin_networkServicesEdgeCacheOriginAdvancedExample|TestAccNetworkServicesEdgeCacheOrigin_updateAndImport|TestAccNetworkServicesEdgeCacheService_networkServicesEdgeCacheServiceAdvancedExample|TestAccNetworkServicesEdgeCacheService_updateAndImport|TestAccOSConfigPatchDeployment_osConfigPatchDeploymentDailyMidnightExample You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=271210

@DrFaust92
Copy link
Contributor Author

cant login to the above
Screen Shot 2022-03-23 at 10 08 51

the only related fail is TestAccDataprocJob_Presto ill check again as its does pass for me

@DrFaust92 DrFaust92 force-pushed the dataproc-job-validations branch from 8d3adf5 to c561f41 Compare March 26, 2022 18:51
@DrFaust92
Copy link
Contributor Author

Rebasing Again,

run the following:

make terraform VERSION=ga OUTPUT_PATH="$GOPATH/src/github.com/hashicorp/terraform-provider-google" PRODUCT=dataproc

and then test using:

make testacc TEST=./google TESTARGS='-run=TestAccDataprocJob_Presto'

with results being:

--- PASS: TestAccDataprocJob_Presto (320.78s)

Cant repro any error and as stated can see the tests runs above /:

1 similar comment
@DrFaust92
Copy link
Contributor Author

Rebasing Again,

run the following:

make terraform VERSION=ga OUTPUT_PATH="$GOPATH/src/github.com/hashicorp/terraform-provider-google" PRODUCT=dataproc

and then test using:

make testacc TEST=./google TESTARGS='-run=TestAccDataprocJob_Presto'

with results being:

--- PASS: TestAccDataprocJob_Presto (320.78s)

Cant repro any error and as stated can see the tests runs above /:

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 231 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 3 files changed, 231 insertions(+), 6 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@slevenick slevenick merged commit ef461c2 into GoogleCloudPlatform:main Apr 1, 2022
betsy-lichtenberg pushed a commit to betsy-lichtenberg/magic-modules that referenced this pull request Apr 25, 2022
* dataproc-job-log-level

* add presto job

* fmt

* desc for presto props

* docs

* docs

* actually add presto config

* presto test

* presto test actually

* docs

* presto expand/flatten

* presto expand/flatten

* fix test

* Update resource_dataproc_job_test.go.erb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dataproc job - Support for presto config
3 participants