Add gc_rules to BigTable's Garbage Collection policy TF resource. #5800

hoangpham95 · 2022-03-08T18:39:30Z

If this PR is for Terraform, I acknowledge that I have:

Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read the Release Notes Guide before writing my release note below.
Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).

Release Note Template for Downstream PRs (will be copied)

bigtable: added `gc_rules` to `google_bigtable_gc_policy` resource.

modular-magician · 2022-03-08T18:39:46Z

Oops! It looks like you're using an unknown release-note type in your changelog entries:

REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

modular-magician · 2022-03-08T18:40:28Z

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@shuyama1, please review this PR or find an appropriate assignee.

modular-magician · 2022-03-08T18:52:12Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 137 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 2 files changed, 137 insertions(+), 2 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2022-03-08T21:25:19Z

Oops! It looks like you're using an unknown release-note type in your changelog entries:

REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

modular-magician · 2022-03-08T21:39:30Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 141 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 2 files changed, 141 insertions(+), 6 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2022-03-09T03:06:19Z

Oops! It looks like you're using an unknown release-note type in your changelog entries:

REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

modular-magician · 2022-03-09T03:20:29Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 143 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 2 files changed, 143 insertions(+), 6 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2022-03-09T03:37:21Z

Oops! It looks like you're using an unknown release-note type in your changelog entries:

REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

modular-magician · 2022-03-09T03:50:05Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 152 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 2 files changed, 152 insertions(+), 6 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2022-03-09T14:01:35Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 215 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 3 files changed, 215 insertions(+), 6 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2022-03-09T16:09:05Z

Tests were added that did not run in TeamCity:

TestAccBigtableGCPolicy_gcRulesPolicy

modular-magician · 2022-03-09T16:09:06Z

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceSqlDatabaseInstance_basic|TestAccBigqueryReservationAssignment_BasicHandWritten|TestAccCGCSnippet_sqlMysqlInstanceBackupExample|TestAccCGCSnippet_sqlPostgresInstanceBackupExample|TestAccCGCSnippet_sqlSqlserverInstanceBackupExample|TestAccCGCSnippet_sqlSqlserverInstanceAuthorizedNetworkExample|TestAccCGCSnippet_sqlPostgresInstanceAuthorizedNetworkExample|TestAccCloudBuildTrigger_cloudbuildTriggerPubsubConfigExample|TestAccCloudBuildTrigger_cloudbuildTriggerWebhookConfigExample|TestAccCloudBuildTrigger_cloudbuildTriggerManualExample|TestAccCloudBuildTrigger_cloudbuildTriggerFilenameExample|TestAccCloudBuildTrigger_cloudbuildTriggerBuildExample|TestAccCloudBuildTrigger_basic|TestAccCloudBuildTrigger_available_secrets_config|TestAccCloudBuildTrigger_cloudbuildTriggerServiceAccountExample|TestAccCloudBuildTrigger_disable|TestAccCloudBuildTrigger_fullStep|TestAccCloudFunctionsFunction_secretEnvVar|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccContainerNodePool_gvnic|TestAccDataprocCluster_nonPreemptibleSecondary|TestAccDataprocCluster_updatable|TestAccDataprocCluster_withConfigOverrides You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=266455

modular-magician · 2022-03-09T16:37:47Z

Tests failed during RECORDING mode: TestAccContainerCluster_withAuthenticatorGroupsConfig Please fix these to complete your PR

modular-magician · 2022-03-09T21:03:10Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 284 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 3 files changed, 284 insertions(+), 6 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2022-03-09T23:09:10Z

Tests were added that did not run in TeamCity:

TestAccBigtableGCPolicy_gcRulesPolicy

modular-magician · 2022-03-09T23:09:12Z

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccArtifactRegistryRepository_create_mvn_snapshot|TestAccArtifactRegistryRepository_create_mvn_release|TestAccContainerCluster_withAuthenticatorGroupsConfig You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=266500

modular-magician · 2022-03-10T15:23:46Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 320 insertions(+), 7 deletions(-))
Terraform Beta: Diff ( 3 files changed, 320 insertions(+), 7 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2022-03-10T17:27:57Z

Tests were added that did not run in TeamCity:

TestAccBigtableGCPolicy_gcRulesPolicy

modular-magician · 2022-03-10T17:27:59Z

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccApikeysKey_AndroidKey|TestAccApikeysKey_BasicKey|TestAccApikeysKey_IosKey|TestAccApikeysKey_MinimalKey|TestAccApikeysKey_ServerKey|TestAccComputeForwardingRule_update|TestAccContainerAwsCluster_BasicHandWritten|TestAccContainerCluster_withAuthenticatorGroupsConfig You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=266964

modular-magician · 2022-03-28T22:20:28Z

Tests were added that did not run in TeamCity:

TestAccBigtableGCPolicy_gcRulesPolicy

modular-magician · 2022-03-28T22:20:30Z

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataprocMetastoreServiceDatasource_basic|TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccFirebaserulesRelease_BasicRelease|TestAccSpannerDatabase_postgres You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=273404

modular-magician · 2022-03-28T22:46:09Z

Tests failed during RECORDING mode: TestAccContainerCluster_withAuthenticatorGroupsConfig Please fix these to complete your PR

hoangpham95 · 2022-04-01T15:30:36Z

@shuyama1 hi Shuya, any update?

modular-magician · 2022-04-01T15:50:28Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 400 insertions(+), 9 deletions(-))
Terraform Beta: Diff ( 3 files changed, 400 insertions(+), 9 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2022-04-01T18:00:38Z

Tests were added that did not run in TeamCity:

TestAccBigtableGCPolicy_gcRulesPolicy

modular-magician · 2022-04-01T18:00:39Z

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccCloudBuildTrigger_cloudbuildTriggerManualExample|TestAccCloudBuildTrigger_basic|TestAccCloudBuildTrigger_available_secrets_config|TestAccCloudBuildTrigger_disable|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccFirebaserulesRelease_BasicRelease You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=275417

shuyama1 · 2022-04-05T17:53:50Z

/gcbrun

modular-magician · 2022-04-05T18:08:43Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 400 insertions(+), 9 deletions(-))
Terraform Beta: Diff ( 3 files changed, 400 insertions(+), 9 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2022-04-05T18:46:31Z

Tests count:
Total tests: 1966
Passed tests 1725
Skipped tests: 238
Failed tests: 3

modular-magician · 2022-04-05T18:46:31Z

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccAccessContextManager|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccBigQueryDatasetAccess_allUsers

modular-magician · 2022-04-05T18:51:38Z

Tests passed during RECORDING mode:
TestAccBigQueryDatasetAccess_allUsers

Tests failed during RECORDING mode:
TestAccAccessContextManager
TestAccContainerCluster_withAuthenticatorGroupsConfig

Please fix these to complete your PR
You can view the build log here: https://storage.cloud.google.com/vcr-test-logs/beta/refs/heads/auto-pr-5800/artifacts/067325ad-1ee4-4618-a7b4-3e81a522a8ae/build-log/recording_test.log and the debug log for each test here: https://console.cloud.google.com/storage/browser/vcr-test-logs/beta/refs/heads/auto-pr-5800/artifacts/067325ad-1ee4-4618-a7b4-3e81a522a8ae/recording

shuyama1 · 2022-04-06T17:20:43Z

Tests skipped in VCR, triggered an independent run and tests passed: https://ci-oss.hashicorp.engineering/buildConfiguration/GoogleCloudBeta_ProviderGoogleCloudBetaMmUpstream/277015

mmv1/third_party/terraform/tests/resource_bigtable_gc_policy_test.go

mmv1/third_party/terraform/website/docs/r/bigtable_gc_policy.html.markdown

modular-magician · 2022-04-12T14:03:02Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 405 insertions(+), 9 deletions(-))
Terraform Beta: Diff ( 3 files changed, 405 insertions(+), 9 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2022-04-12T14:41:16Z

Tests analytics

Total tests: 1981
Passed tests 1738
Skipped tests: 241
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccServiceNetworkingPeeredDNSDomain_basic|TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic

modular-magician · 2022-04-12T14:52:42Z

Tests passed during RECORDING mode:
TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic[view]
TestAccServiceNetworkingPeeredDNSDomain_basic[view]

All tests passed
View the build log or the debug log for each test

modular-magician · 2022-04-12T16:15:15Z

Tests were added that did not run in TeamCity:

TestAccBigtableGCPolicy_gcRulesPolicy

modular-magician · 2022-04-12T16:15:16Z

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=279052

shuyama1 · 2022-04-12T20:44:23Z

Test passed: https://ci-oss.hashicorp.engineering/buildConfiguration/GoogleCloudBeta_ProviderGoogleCloudBetaMmUpstream/279054?buildTab=tests&status=passed

shuyama1

LGTM! Thank you so much!

…ogleCloudPlatform#5800)

add gc_rules to BigTable's TF resource.

160314a

modular-magician requested a review from shuyama1 March 8, 2022 18:40

Format

0be3213

Fix test.

b76eb86

Fix lint.

4a00b73

Update doc

aa98872

hoangpham95 marked this pull request as ready for review March 9, 2022 13:48

hoangpham95 changed the title ~~add gc_rules to BigTable's TF resource.~~ Add gc_rules to BigTable's Garbage Collection policy TF resource. Mar 9, 2022

hoangpham95 added 2 commits March 9, 2022 15:47

Add more tests

96300e5

Reformat.

26a04f7

Add update for GC policy.

0844239

hoangpham95 requested a review from shuyama1 April 1, 2022 15:33

Method name change

6ede42b

shuyama1 requested changes Apr 6, 2022

View reviewed changes

mmv1/third_party/terraform/tests/resource_bigtable_gc_policy_test.go Outdated Show resolved Hide resolved

mmv1/third_party/terraform/website/docs/r/bigtable_gc_policy.html.markdown Outdated Show resolved Hide resolved

Address review comments.

3bca8cb

shuyama1 self-requested a review April 12, 2022 16:02

shuyama1 approved these changes Apr 12, 2022

View reviewed changes

shuyama1 merged commit d5eee11 into GoogleCloudPlatform:main Apr 12, 2022

This was referenced Apr 12, 2022

Add gc_rules to BigTable's Garbage Collection policy TF resource. hashicorp/terraform-provider-google#11481

Merged

Add gc_rules to BigTable's Garbage Collection policy TF resource. hashicorp/terraform-provider-google-beta#4212

Merged

betsy-lichtenberg pushed a commit to betsy-lichtenberg/magic-modules that referenced this pull request Apr 25, 2022

Add gc_rules to BigTable's Garbage Collection policy TF resource. (Go…

29a5d58

…ogleCloudPlatform#5800)

Add gc_rules to BigTable's Garbage Collection policy TF resource. #5800

Add gc_rules to BigTable's Garbage Collection policy TF resource. #5800

Conversation

hoangpham95 commented Mar 8, 2022 • edited by shuyama1 Loading

modular-magician commented Mar 8, 2022

modular-magician commented Mar 8, 2022

modular-magician commented Mar 8, 2022

Diff report:

modular-magician commented Mar 8, 2022

modular-magician commented Mar 8, 2022

Diff report:

modular-magician commented Mar 9, 2022

modular-magician commented Mar 9, 2022

Diff report:

modular-magician commented Mar 9, 2022

modular-magician commented Mar 9, 2022

Diff report:

modular-magician commented Mar 9, 2022

Diff report:

modular-magician commented Mar 9, 2022

modular-magician commented Mar 9, 2022

modular-magician commented Mar 9, 2022

modular-magician commented Mar 9, 2022

Diff report:

modular-magician commented Mar 9, 2022

modular-magician commented Mar 9, 2022

modular-magician commented Mar 10, 2022

Diff report:

modular-magician commented Mar 10, 2022

modular-magician commented Mar 10, 2022

modular-magician commented Mar 28, 2022

modular-magician commented Mar 28, 2022

modular-magician commented Mar 28, 2022

hoangpham95 commented Apr 1, 2022

modular-magician commented Apr 1, 2022

Diff report:

modular-magician commented Apr 1, 2022

modular-magician commented Apr 1, 2022

shuyama1 commented Apr 5, 2022

modular-magician commented Apr 5, 2022

Diff report:

modular-magician commented Apr 5, 2022

modular-magician commented Apr 5, 2022

modular-magician commented Apr 5, 2022

shuyama1 commented Apr 6, 2022 • edited Loading

modular-magician commented Apr 12, 2022

Diff report:

modular-magician commented Apr 12, 2022

Tests analytics

Action taken

modular-magician commented Apr 12, 2022

modular-magician commented Apr 12, 2022

modular-magician commented Apr 12, 2022

shuyama1 commented Apr 12, 2022

shuyama1 left a comment

Choose a reason for hiding this comment

hoangpham95 commented Mar 8, 2022 •

edited by shuyama1

Loading

shuyama1 commented Apr 6, 2022 •

edited

Loading