Allow recurring_schedule.time_of_day to be set to 00:00

[shuyama1]

Fixes hashicorp/terraform-provider-google#11213

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

osconfig: fixed a bug where `recurring_schedule.time_of_day` can not be set to 12am exact time in `google_os_config_patch_deployment` resource

[modular-magician]

Oops! It looks like you're using an unknown release-note type in your changelog entries:

• REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

[shuyama1]

/gcbrun

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 82 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 3 files changed, 82 insertions(+), 4 deletions(-))
TF Validator: Diff ( 3 files changed, 4 insertions(+), 4 deletions(-))
TF OiCS: Diff ( 4 files changed, 121 insertions(+))

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 82 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 3 files changed, 82 insertions(+), 4 deletions(-))
TF Validator: Diff ( 3 files changed, 4 insertions(+), 4 deletions(-))
TF OiCS: Diff ( 4 files changed, 121 insertions(+))

[shuyama1]

/gcbrun

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 82 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 3 files changed, 82 insertions(+), 4 deletions(-))
TF Validator: Diff ( 3 files changed, 4 insertions(+), 4 deletions(-))
TF OiCS: Diff ( 4 files changed, 121 insertions(+))

[shuyama1]

/gcbrun

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 82 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 3 files changed, 82 insertions(+), 4 deletions(-))
TF Validator: Diff ( 3 files changed, 4 insertions(+), 4 deletions(-))
TF OiCS: Diff ( 4 files changed, 121 insertions(+))

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccDataSourceSqlDatabaseInstance_basic|TestAccApikeysKey_AndroidKey|TestAccApikeysKey_BasicKey|TestAccApikeysKey_IosKey|TestAccApikeysKey_MinimalKey|TestAccApikeysKey_ServerKey|TestAccArtifactRegistryRepository_create_mvn_snapshot|TestAccArtifactRegistryRepository_create_mvn_release|TestAccBigqueryReservationAssignment_BasicHandWritten|TestAccCGCSnippet_sqlMysqlInstanceBackupExample|TestAccCGCSnippet_sqlPostgresInstanceBackupExample|TestAccCGCSnippet_sqlSqlserverInstanceBackupExample|TestAccCGCSnippet_sqlMysqlInstanceAuthorizedNetworkExample|TestAccCGCSnippet_sqlSqlserverInstanceBackupLocationExample|TestAccCloudBuildTrigger_cloudbuildTriggerFilenameExample|TestAccCloudBuildTrigger_cloudbuildTriggerPubsubConfigExample|TestAccCloudBuildTrigger_cloudbuildTriggerWebhookConfigExample|TestAccCloudBuildTrigger_cloudbuildTriggerManualExample|TestAccCloudBuildTrigger_cloudbuildTriggerBuildExample|TestAccCloudBuildTrigger_basic|TestAccCloudBuildTrigger_available_secrets_config|TestAccCloudBuildTrigger_cloudbuildTriggerServiceAccountExample|TestAccCloudBuildTrigger_disable|TestAccCloudBuildTrigger_fullStep|TestAccCloudFunctionsFunction_secretEnvVar|TestAccContainerAwsCluster_BasicHandWritten|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccContainerNodePool_gvnic|TestAccDataprocCluster_nonPreemptibleSecondary|TestAccDataprocCluster_updatable|TestAccDataprocCluster_withConfigOverrides|TestAccServiceNetworkingPeeredDNSDomain_basic|TestAccLoggingLogView_BasicHandWritten|TestAccNetworkServicesEdgeCacheOrigin_networkServicesEdgeCacheOriginAdvancedExample|TestAccNetworkServicesEdgeCacheOrigin_updateAndImport|TestAccNetworkServicesEdgeCacheService_networkServicesEdgeCacheServiceAdvancedExample|TestAccNetworkServicesEdgeCacheService_updateAndImport|TestAccOSConfigPatchDeployment_osConfigPatchDeploymentDailyMidnightExample You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=269099

[modular-magician]

Tests failed during RECORDING mode: TestAccContainerCluster_withAuthenticatorGroupsConfig Please fix these to complete your PR

[slevenick]

Can this be done with send_empty on the fields instead?

[shuyama1]

Can this be done with send_empty on the fields instead?

I did add send_empty_value on the fields. The reason of using a custom flattener is that the API does not return the value when all of the subfields of time_of_day are set to zero, and it will cause a permadiff.

[slevenick]

Can this be done with send_empty on the fields instead?

I did add send_empty_value on the fields. The reason of using a custom flattener is that the API does not return the value when all of the subfields of time_of_day are set to zero, and it will cause a permadiff.

Oh gosh, that's unfortunate. So even when we send the values as 0 the API returns nothing?

[shuyama1]

Can this be done with send_empty on the fields instead?

I did add send_empty_value on the fields. The reason of using a custom flattener is that the API does not return the value when all of the subfields of time_of_day are set to zero, and it will cause a permadiff.

Oh gosh, that's unfortunate. So even when we send the values as 0 the API returns nothing?

Yeah! It will return an empty time_of_day block without any subfield values returned.