-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add enable_exactly_once_delivery
to google_pubsub_subscription
#5849
Add enable_exactly_once_delivery
to google_pubsub_subscription
#5849
Conversation
Co-authored-by: upodroid <cy@borg.dev>
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @ScottSuarez, please review this PR or find an appropriate assignee. |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 3 files changed, 48 insertions(+), 7 deletions(-)) |
/gcbrun |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 3 files changed, 48 insertions(+), 7 deletions(-)) |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccCGCSnippet_sqlSqlserverInstanceBackupLocationExample|TestAccComputeSecurityPolicy_basic|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccPubsubSubscription_update You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=272333 |
Would be awesome to have this one figured out. My team is currently discussing configuring exactly-once via gcloud after the subscription is created by TF, which is a little ugly. |
Bump @ScottSuarez |
…oogleCloudPlatform#5849) Co-authored-by: upodroid <cy@borg.dev>
Fixes: hashicorp/terraform-provider-google#11286
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)