Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deploymentType and apiProxyType to ApigeeEnvironment #5884

Merged
merged 31 commits into from
Apr 4, 2022

Conversation

xuchenma
Copy link
Contributor

@xuchenma xuchenma commented Apr 1, 2022

Add deploymentType and apiProxyType to ApigeeEnvironment. This PR solves hashicorp/terraform-provider-google#11379

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

Add deploymentType and apiProxyType to ApigeeEnvironment.

xuchenma and others added 30 commits October 3, 2021 07:17
Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@c2thorn, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 183 insertions(+))
Terraform Beta: Diff ( 3 files changed, 183 insertions(+))
TF Validator: Diff ( 3 files changed, 23 insertions(+), 3 deletions(-))

@c2thorn
Copy link
Member

c2thorn commented Apr 1, 2022

/gcbrun

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 183 insertions(+))
Terraform Beta: Diff ( 3 files changed, 183 insertions(+))
TF Validator: Diff ( 3 files changed, 23 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests were added that did not run in TeamCity:

  • TestAccApigeeEnvironment_apigeeEnvironmentBasicDeploymentApiproxyTypeTestExample

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample|TestAccContainerCluster_withAuthenticatorGroupsConfig You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=275414

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 183 insertions(+))
Terraform Beta: Diff ( 3 files changed, 183 insertions(+))
TF Validator: Diff ( 3 files changed, 23 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests rerun

@modular-magician
Copy link
Collaborator

Tests count:
Total tests: 1959
Passed tests 1711
Skipped tests: 234
Failed tests: 14

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccCloudBuildTrigger_cloudbuildTriggerManualExample|TestAccCloudBuildTrigger_disable|TestAccCloudBuildTrigger_pubsub_config|TestAccCloudBuildTrigger_available_secrets_config|TestAccBinaryAuthorizationAttestor_binaryAuthorizationAttestorBasicExample|TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample|TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample|TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample|TestAccCloudBuildTrigger_basic|TestAccBigQueryDataTable_bigtable|TestAccFirebaserulesRelease_BasicRelease|TestAccNetworkServicesEdgeCacheService_networkServicesEdgeCacheServiceAdvancedExample|TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic

@c2thorn c2thorn merged commit 59a8759 into GoogleCloudPlatform:main Apr 4, 2022
@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic
TestAccCloudBuildTrigger_available_secrets_config
TestAccNetworkServicesEdgeCacheService_networkServicesEdgeCacheServiceAdvancedExample
TestAccFirebaserulesRelease_BasicRelease
TestAccCloudBuildTrigger_disable
TestAccCloudBuildTrigger_pubsub_config
TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample
TestAccCloudBuildTrigger_basic
TestAccCloudBuildTrigger_cloudbuildTriggerManualExample
TestAccBinaryAuthorizationAttestor_binaryAuthorizationAttestorBasicExample
TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample
TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample
TestAccBigQueryDataTable_bigtable

Tests failed during RECORDING mode:
TestAccContainerCluster_withAuthenticatorGroupsConfig

Please fix these to complete your PR
You can view the build log here: https://storage.cloud.google.com/vcr-test-logs/beta/refs/heads/auto-pr-5884/artifacts/6593e71a-6995-42f9-ae58-522b6addffb7/build-log/recording_test.log and the debug log for each test here: https://console.cloud.google.com/storage/browser/vcr-test-logs/beta/refs/heads/auto-pr-5884/artifacts/6593e71a-6995-42f9-ae58-522b6addffb7/recording

@modular-magician
Copy link
Collaborator

Tests were added that did not run in TeamCity:

  • TestAccApigeeEnvironment_apigeeEnvironmentBasicDeploymentApiproxyTypeTestExample

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccBigQueryDataTable_bigtable|TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample|TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample|TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample|TestAccCloudBuildTrigger_cloudbuildTriggerManualExample|TestAccCloudBuildTrigger_basic|TestAccCloudBuildTrigger_available_secrets_config|TestAccCloudBuildTrigger_disable|TestAccComputeForwardingRule_update|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccServiceNetworkingPeeredDNSDomain_basic|TestAccNetworkServicesEdgeCacheService_networkServicesEdgeCacheServiceAdvancedExample You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=275979

@xuchenma xuchenma deleted the new_types branch April 5, 2022 00:07
betsy-lichtenberg pushed a commit to betsy-lichtenberg/magic-modules that referenced this pull request Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants