-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from an explicit default to O+C for redis readReplicasMode #5899
Switch from an explicit default to O+C for redis readReplicasMode #5899
Conversation
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 2 files changed, 2 insertions(+), 3 deletions(-)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. For our future reference:
- This default was originally added in Redis MRR Support #5449 as a beta-only field
- It was promoted to GA in GA several redis fields #5838
- This implementation matches changes proposed in Add support to enable read replicas on existing redis instances #5793 (which also contains changes to a related field) which were going to be made to prevent a similar issue in beta.
Tests count: |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccAccessApprovalSettings|TestAccAccessContextManager|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccRedisInstance_downgradeRedisVersion|TestAccRedisInstance_redisInstanceAuthEnabled|TestAccRedisInstance_regionFromLocation|TestAccServiceNetworkingPeeredDNSDomain_basic|TestAccComputeForwardingRule_update|TestAccFirebaserulesRelease_BasicRelease|TestAccCGCSnippet_flaskGoogleCloudQuickstartExample|TestAccRedisInstance_redisInstanceFullExample|TestAccRedisInstance_redisInstanceBasicExample|TestAccRedisInstance_update|TestAccRedisInstanceDatasource_basic |
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
Fixes hashicorp/terraform-provider-google#11410
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)