-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix location in dialogflow #5903
Conversation
/gcbrun |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 8 files changed, 356 insertions(+), 2 deletions(-)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccAccessContextManager|TestAccServiceNetworkingPeeredDNSDomain_basic|TestAccFirebaserulesRelease_BasicRelease|TestAccDialogflowCXVersion_dialogflowcxVersionFullExample|TestAccDialogflowCXPage_dialogflowcxPageFullExample|TestAccDialogflowCXIntent_dialogflowcxIntentFullExample|TestAccDialogflowCXFlow_dialogflowcxFlowFullExample|TestAccDialogflowCXEnvironment_dialogflowcxEnvironmentFullExample|TestAccDialogflowCXEntityType_dialogflowcxEntityTypeFullExample|TestAccDialogflowCXAgent_dialogflowcxAgentFullExample|TestAccDialogflowCXVersion_update|TestAccDialogflowCXPage_update|TestAccDialogflowCXIntent_update|TestAccDialogflowCXEntityType_update|TestAccDialogflowCXFlow_update|TestAccDialogflowCXAgent_update|TestAccDialogflowCXEnvironment_update|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccComputeGlobalForwardingRule_externalCdnLbWithBackendBucketExample|TestAccBigQueryDataTable_bigtable|TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic |
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccAccessContextManager|TestAccComputeGlobalForwardingRule_externalCdnLbWithBackendBucketExample|TestAccComputeForwardingRule_update|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccDialogflowCXAgent_dialogflowcxAgentFullExample|TestAccDialogflowCXEntityType_dialogflowcxEntityTypeFullExample|TestAccDialogflowCXEnvironment_dialogflowcxEnvironmentFullExample|TestAccDialogflowCXIntent_dialogflowcxIntentFullExample|TestAccDialogflowCXFlow_dialogflowcxFlowFullExample|TestAccDialogflowCXPage_dialogflowcxPageFullExample|TestAccDialogflowCXVersion_dialogflowcxVersionFullExample|TestAccDialogflowCXEntityType_update|TestAccDialogflowCXAgent_update|TestAccDialogflowCXIntent_update|TestAccDialogflowCXFlow_update|TestAccDialogflowCXPage_update|TestAccDialogflowCXEnvironment_update|TestAccDialogflowCXVersion_update|TestAccFirebaserulesRelease_BasicRelease You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=277652 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor q on operations!
Closing in favor of #5922 as I can't update this |
New PR based on #5108 as the VCR steps have gotten out of date
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)