Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix location in dialogflow #5903

Closed
wants to merge 3 commits into from

Conversation

slevenick
Copy link
Contributor

New PR based on #5108 as the VCR steps have gotten out of date

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

dialogflow: added support for location based dialogflow resources

@slevenick
Copy link
Contributor Author

/gcbrun

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 8 files changed, 356 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 8 files changed, 356 insertions(+), 2 deletions(-))
TF Validator: Diff ( 10 files changed, 25 insertions(+), 25 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1971
Passed tests 1713
Skipped tests: 237
Failed tests: 21

Action taken

Triggering VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccAccessContextManager|TestAccServiceNetworkingPeeredDNSDomain_basic|TestAccFirebaserulesRelease_BasicRelease|TestAccDialogflowCXVersion_dialogflowcxVersionFullExample|TestAccDialogflowCXPage_dialogflowcxPageFullExample|TestAccDialogflowCXIntent_dialogflowcxIntentFullExample|TestAccDialogflowCXFlow_dialogflowcxFlowFullExample|TestAccDialogflowCXEnvironment_dialogflowcxEnvironmentFullExample|TestAccDialogflowCXEntityType_dialogflowcxEntityTypeFullExample|TestAccDialogflowCXAgent_dialogflowcxAgentFullExample|TestAccDialogflowCXVersion_update|TestAccDialogflowCXPage_update|TestAccDialogflowCXIntent_update|TestAccDialogflowCXEntityType_update|TestAccDialogflowCXFlow_update|TestAccDialogflowCXAgent_update|TestAccDialogflowCXEnvironment_update|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccComputeGlobalForwardingRule_externalCdnLbWithBackendBucketExample|TestAccBigQueryDataTable_bigtable|TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic[view]
TestAccDialogflowCXAgent_update[view]
TestAccServiceNetworkingPeeredDNSDomain_basic[view]
TestAccFirebaserulesRelease_BasicRelease[view]
TestAccDialogflowCXVersion_update[view]
TestAccDialogflowCXPage_update[view]
TestAccDialogflowCXIntent_update[view]
TestAccDialogflowCXFlow_update[view]
TestAccDialogflowCXEnvironment_update[view]
TestAccDialogflowCXEntityType_update[view]
TestAccDialogflowCXEnvironment_dialogflowcxEnvironmentFullExample[view]
TestAccDialogflowCXVersion_dialogflowcxVersionFullExample[view]
TestAccDialogflowCXPage_dialogflowcxPageFullExample[view]
TestAccDialogflowCXIntent_dialogflowcxIntentFullExample[view]
TestAccDialogflowCXEntityType_dialogflowcxEntityTypeFullExample[view]
TestAccDialogflowCXAgent_dialogflowcxAgentFullExample[view]
TestAccBigQueryDataTable_bigtable[view]
TestAccDialogflowCXFlow_dialogflowcxFlowFullExample[view]

Tests failed during RECORDING mode:
TestAccAccessContextManager[view]
TestAccContainerCluster_withAuthenticatorGroupsConfig[view]
TestAccComputeGlobalForwardingRule_externalCdnLbWithBackendBucketExample[view]

Please fix these to complete your PR
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccAccessContextManager|TestAccComputeGlobalForwardingRule_externalCdnLbWithBackendBucketExample|TestAccComputeForwardingRule_update|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccDialogflowCXAgent_dialogflowcxAgentFullExample|TestAccDialogflowCXEntityType_dialogflowcxEntityTypeFullExample|TestAccDialogflowCXEnvironment_dialogflowcxEnvironmentFullExample|TestAccDialogflowCXIntent_dialogflowcxIntentFullExample|TestAccDialogflowCXFlow_dialogflowcxFlowFullExample|TestAccDialogflowCXPage_dialogflowcxPageFullExample|TestAccDialogflowCXVersion_dialogflowcxVersionFullExample|TestAccDialogflowCXEntityType_update|TestAccDialogflowCXAgent_update|TestAccDialogflowCXIntent_update|TestAccDialogflowCXFlow_update|TestAccDialogflowCXPage_update|TestAccDialogflowCXEnvironment_update|TestAccDialogflowCXVersion_update|TestAccFirebaserulesRelease_BasicRelease You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=277652

@slevenick slevenick requested review from a team and rileykarson and removed request for a team April 8, 2022 16:47
Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor q on operations!

mmv1/provider/terraform/custom_code.rb Show resolved Hide resolved
mmv1/products/dialogflowcx/api.yaml Show resolved Hide resolved
@slevenick slevenick mentioned this pull request Apr 11, 2022
5 tasks
@slevenick
Copy link
Contributor Author

Closing in favor of #5922 as I can't update this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants