-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include 'Exceed Redirect Options' in security policy rules #5946
Include 'Exceed Redirect Options' in security policy rules #5946
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). For more information, open the CLA check for this pull request. |
Oops! It looks like you're using an unknown release-note type in your changelog entries:
Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md. |
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @melinath, please review this PR or find an appropriate assignee. |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform Beta: Diff ( 2 files changed, 85 insertions(+), 14 deletions(-)) |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform Beta: Diff ( 2 files changed, 85 insertions(+), 14 deletions(-)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeSecurityPolicy_withRateLimitWithRedirectOptions|TestAccServiceNetworkingPeeredDNSDomain_basic |
Hello, I apologize, I'm not able to build and test the modules. "make build" fails after fmt on the generated "ga" and "beta" provider codebases; some imports appear missing (time, encoding/json) from seemingly unrelated files (google/gke_hub_operation.go). I was trying to use the "Cloud Shell" in a personal account to build and test - I can not run tests in my work environment. Thank you, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a reasonable implementation - the underlying redirect options object is the same in both cases. There's a new test that exercises the field, and it's passing. The code is also properly gated since this is only available in beta.
fixes hashicorp/terraform-provider-google#11471
Pass the "exceed redirect options" to security policy rules. Applies to action taken when "throttle" rule is implemented with action of type "redirect".
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)