Add locality_lb_policies field to google_compute_backend_service #5947

temawi · 2022-04-15T20:16:21Z

This is a new optional field that allows configuring custom load balancer
policies in gRPC clients.

The field has been promoted to production, but at the moment requires a
GCP project to be allowlisted for it to be used. I have run the test I defined
for the field against an allowlisted test project.

part of hashicorp/terraform-provider-google#11519

If this PR is for Terraform, I acknowledge that I have:

[ X ] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
[ X ] Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
[ X ] Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
[ X ] Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
[ X ] Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: added `locality_lb_policies` field to `google_compute_backend_service`

modular-magician · 2022-04-15T20:17:23Z

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@rileykarson, please review this PR or find an appropriate assignee.

modular-magician · 2022-04-15T20:32:21Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 717 insertions(+))
Terraform Beta: Diff ( 5 files changed, 717 insertions(+))
TF Validator: Diff ( 4 files changed, 187 insertions(+), 3 deletions(-))

modular-magician · 2022-04-15T21:18:26Z

Tests analytics

Total tests: 1987
Passed tests 1743
Skipped tests: 240
Failed tests: 4

Action taken

Triggering VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccFirebaserulesRelease_BasicRelease|TestAccComputeBackendService_trafficDirectorLbPolicies|TestAccServiceNetworkingPeeredDNSDomain_basic|TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic

modular-magician · 2022-04-15T21:30:37Z

Tests passed during RECORDING mode:
TestAccServiceNetworkingPeeredDNSDomain_basic[view]
TestAccFirebaserulesRelease_BasicRelease[view]

Tests failed during RECORDING mode:
TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic[view]
TestAccComputeBackendService_trafficDirectorLbPolicies[view]

Please fix these to complete your PR
View the build log or the debug log for each test

rileykarson

It looks like this is failing against the API- you should have logs access for the failed test case.

mmv1/products/compute/api.yaml

modular-magician · 2023-01-17T23:50:21Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 708 insertions(+))
Terraform Beta: Diff ( 5 files changed, 708 insertions(+))
TF Validator: Diff ( 4 files changed, 187 insertions(+), 3 deletions(-))

modular-magician · 2023-01-17T23:52:22Z

Tests analytics

Total tests: 0
Passed tests 0
Skipped tests: 0
Failed tests: 0

Errors occurred during REPLAYING mode. Please fix them to complete your PR
View the build log

modular-magician · 2023-01-18T00:15:30Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 708 insertions(+))
Terraform Beta: Diff ( 5 files changed, 708 insertions(+))
TF Validator: Diff ( 4 files changed, 187 insertions(+), 3 deletions(-))

modular-magician · 2023-01-18T00:17:31Z

Tests analytics

Total tests: 0
Passed tests 0
Skipped tests: 0
Failed tests: 0

Errors occurred during REPLAYING mode. Please fix them to complete your PR
View the build log

modular-magician · 2023-01-19T00:04:01Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 715 insertions(+))
Terraform Beta: Diff ( 5 files changed, 715 insertions(+))
TF Validator: Diff ( 4 files changed, 187 insertions(+), 3 deletions(-))

modular-magician · 2023-01-19T00:51:34Z

Tests analytics

Total tests: 2425
Passed tests 2170
Skipped tests: 253
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccServiceNetworkingPeeredDNSDomain_basic|TestAccComputeBackendService_trafficDirectorLbPolicies

modular-magician · 2023-01-19T00:58:36Z

Tests passed during RECORDING mode:
TestAccServiceNetworkingPeeredDNSDomain_basic[Debug log]

Tests failed during RECORDING mode:
TestAccComputeBackendService_trafficDirectorLbPolicies[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2023-01-19T16:56:43Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 715 insertions(+))
Terraform Beta: Diff ( 5 files changed, 715 insertions(+))
TF Validator: Diff ( 4 files changed, 187 insertions(+), 3 deletions(-))

modular-magician · 2023-01-19T17:42:06Z

Tests analytics

Total tests: 2425
Passed tests 2166
Skipped tests: 253
Failed tests: 6

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccRegionInstanceGroupManager_stateful|TestAccComputeBackendService_trafficDirectorLbPolicies|TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample|TestAccVertexAIIndex_updated|TestAccFirebaserulesRelease_BasicRelease|TestAccLoggingBucketConfigProject_cmekSettings

modular-magician · 2023-01-19T18:30:41Z

Tests passed during RECORDING mode:
TestAccVertexAIIndex_updated[Debug log]
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]

Tests failed during RECORDING mode:
TestAccRegionInstanceGroupManager_stateful[Error message] [Debug log]
TestAccComputeBackendService_trafficDirectorLbPolicies[Error message] [Debug log]
TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2023-01-19T19:02:32Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 715 insertions(+))
Terraform Beta: Diff ( 5 files changed, 715 insertions(+))
TF Validator: Diff ( 4 files changed, 187 insertions(+), 3 deletions(-))

modular-magician · 2023-01-19T19:52:46Z

Tests analytics

Total tests: 2426
Passed tests 2170
Skipped tests: 253
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccRegionInstanceGroupManager_stateful|TestAccComputeBackendService_trafficDirectorLbPolicies|TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample

modular-magician · 2023-01-19T19:56:28Z

Tests failed during RECORDING mode:
TestAccRegionInstanceGroupManager_stateful[Error message] [Debug log]
TestAccComputeBackendService_trafficDirectorLbPolicies[Error message] [Debug log]
TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2023-01-19T20:53:53Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 719 insertions(+))
Terraform Beta: Diff ( 5 files changed, 719 insertions(+))
TF Validator: Diff ( 4 files changed, 187 insertions(+), 3 deletions(-))

modular-magician · 2023-01-19T21:42:57Z

Tests analytics

Total tests: 2426
Passed tests 2169
Skipped tests: 253
Failed tests: 4

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccRegionInstanceGroupManager_stateful|TestAccComputeBackendService_trafficDirectorLbPolicies|TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample

modular-magician · 2023-01-19T21:47:11Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccRegionInstanceGroupManager_stateful[Debug log]

Tests failed during RECORDING mode:
TestAccComputeBackendService_trafficDirectorLbPolicies[Error message] [Debug log]
TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

temawi · 2023-01-25T19:25:07Z

Is this field updatable? Should an update test be added if it is the case.

The field is updatable, I added an update test as well.

modular-magician · 2023-01-25T19:37:00Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 788 insertions(+))
Terraform Beta: Diff ( 5 files changed, 788 insertions(+))
TF Validator: Diff ( 4 files changed, 187 insertions(+), 3 deletions(-))

modular-magician · 2023-01-25T20:19:08Z

Tests analytics

Total tests: 2431
Passed tests 2175
Skipped tests: 254
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccComputeBackendService_trafficDirectorUpdateLbPolicies

modular-magician · 2023-01-25T20:21:01Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccComputeBackendService_trafficDirectorUpdateLbPolicies[Debug log]

All tests passed
View the build log or the debug log for each test

mmv1/third_party/terraform/tests/resource_compute_backend_service_test.go.erb

modular-magician · 2023-01-25T21:19:17Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 765 insertions(+))
Terraform Beta: Diff ( 5 files changed, 765 insertions(+))
TF Validator: Diff ( 4 files changed, 187 insertions(+), 3 deletions(-))

modular-magician · 2023-01-25T21:59:39Z

Tests analytics

Total tests: 2430
Passed tests 2176
Skipped tests: 254
Failed tests: 0

All tests passed in REPLAYING mode
View the build log

hao-nan-li · 2023-01-25T22:05:26Z

LGTM in general.

Waiting on @rileykarson to sign off.

mmv1/third_party/terraform/tests/resource_compute_backend_service_test.go.erb

modular-magician · 2023-01-27T19:51:11Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 6 files changed, 872 insertions(+))
Terraform Beta: Diff ( 6 files changed, 872 insertions(+))
TF Validator: Diff ( 4 files changed, 187 insertions(+), 3 deletions(-))

modular-magician · 2023-01-27T20:36:07Z

Tests analytics

Total tests: 2438
Passed tests 2181
Skipped tests: 254
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccComputeRegionBackendService_trafficDirectorUpdateLbPolicies|TestAccContainerCluster_failedCreation|TestAccRegionInstanceGroupManager_stateful

modular-magician · 2023-01-27T20:51:26Z

Tests passed during RECORDING mode:
TestAccContainerCluster_failedCreation[Debug log]

Tests failed during RECORDING mode:
TestAccComputeRegionBackendService_trafficDirectorUpdateLbPolicies[Error message] [Debug log]
TestAccRegionInstanceGroupManager_stateful[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

This reverts commit e938671.

modular-magician · 2023-01-27T22:09:49Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 435 insertions(+))
Terraform Beta: Diff ( 3 files changed, 435 insertions(+))
TF Validator: Diff ( 3 files changed, 95 insertions(+), 3 deletions(-))

modular-magician · 2023-01-27T22:53:54Z

Tests analytics

Total tests: 2440
Passed tests 2184
Skipped tests: 254
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccRegionInstanceGroupManager_stateful|TestAccContainerCluster_failedCreation

modular-magician · 2023-01-27T23:09:05Z

Tests passed during RECORDING mode:
TestAccContainerCluster_failedCreation[Debug log]

Tests failed during RECORDING mode:
TestAccRegionInstanceGroupManager_stateful[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

…gleCloudPlatform#5947)

modular-magician requested a review from rileykarson April 15, 2022 20:17

rileykarson reviewed Apr 19, 2022

View reviewed changes

mmv1/products/compute/api.yaml Show resolved Hide resolved

mmv1/products/compute/api.yaml Show resolved Hide resolved

Add locality_lb_policies field to BackendService

7571b83

temawi force-pushed the backendservice_locality_lb_policies branch from 79d49f0 to 7571b83 Compare January 17, 2023 23:33

modular-magician requested a review from rileykarson January 17, 2023 23:34

Make policy and customPolicy names required

c4f7582

Add missing health check

9c6e3e6

Proper escaping in the data string

e80c7ef

Add missing quotes

7b88d76

temawi marked this pull request as draft January 19, 2023 21:58

temawi added 2 commits January 25, 2023 11:02

RegionBackendService name fields also required

90913bd

Add an update test

c9d9ae3

hao-nan-li reviewed Jan 25, 2023

View reviewed changes

mmv1/third_party/terraform/tests/resource_compute_backend_service_test.go.erb Outdated Show resolved Hide resolved

Remove unnecessary test

8275658

rileykarson reviewed Jan 27, 2023

View reviewed changes

mmv1/third_party/terraform/tests/resource_compute_backend_service_test.go.erb Show resolved Hide resolved

Add test for region backend service

e938671

modular-magician requested a review from rileykarson January 27, 2023 19:34

temawi added 2 commits January 27, 2023 13:43

Revert "Add test for region backend service"

4575a83

This reverts commit e938671.

Remove nonapplicable regional backend service

345ad21

rileykarson approved these changes Jan 30, 2023

View reviewed changes

rileykarson merged commit 62c9b73 into GoogleCloudPlatform:main Jan 30, 2023

temawi deleted the backendservice_locality_lb_policies branch January 30, 2023 22:20

melinath added the service/compute label Feb 7, 2023

ericayyliu pushed a commit to ericayyliu/magic-modules that referenced this pull request Jul 26, 2023

Add locality_lb_policies field to google_compute_backend_service (Goo…

b76cb7a

…gleCloudPlatform#5947)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add locality_lb_policies field to google_compute_backend_service #5947

Add locality_lb_policies field to google_compute_backend_service #5947

temawi commented Apr 15, 2022

modular-magician commented Apr 15, 2022

modular-magician commented Apr 15, 2022

modular-magician commented Apr 15, 2022

modular-magician commented Apr 15, 2022

rileykarson left a comment

modular-magician commented Jan 17, 2023

modular-magician commented Jan 17, 2023

modular-magician commented Jan 18, 2023

modular-magician commented Jan 18, 2023

modular-magician commented Jan 19, 2023

modular-magician commented Jan 19, 2023

modular-magician commented Jan 19, 2023

modular-magician commented Jan 19, 2023

modular-magician commented Jan 19, 2023

modular-magician commented Jan 19, 2023

modular-magician commented Jan 19, 2023

modular-magician commented Jan 19, 2023

modular-magician commented Jan 19, 2023

modular-magician commented Jan 19, 2023

modular-magician commented Jan 19, 2023

modular-magician commented Jan 19, 2023

temawi commented Jan 25, 2023 •

edited

Loading

modular-magician commented Jan 25, 2023

modular-magician commented Jan 25, 2023

modular-magician commented Jan 25, 2023

modular-magician commented Jan 25, 2023

modular-magician commented Jan 25, 2023

hao-nan-li commented Jan 25, 2023 •

edited

Loading

modular-magician commented Jan 27, 2023

modular-magician commented Jan 27, 2023

modular-magician commented Jan 27, 2023

modular-magician commented Jan 27, 2023

modular-magician commented Jan 27, 2023

modular-magician commented Jan 27, 2023

Add locality_lb_policies field to google_compute_backend_service #5947

Add locality_lb_policies field to google_compute_backend_service #5947

Conversation

temawi commented Apr 15, 2022

modular-magician commented Apr 15, 2022

modular-magician commented Apr 15, 2022

Diff report:

modular-magician commented Apr 15, 2022

Tests analytics

Action taken

modular-magician commented Apr 15, 2022

rileykarson left a comment

Choose a reason for hiding this comment

modular-magician commented Jan 17, 2023

Diff report

modular-magician commented Jan 17, 2023

Tests analytics

modular-magician commented Jan 18, 2023

Diff report

modular-magician commented Jan 18, 2023

Tests analytics

modular-magician commented Jan 19, 2023

Diff report

modular-magician commented Jan 19, 2023

Tests analytics

Action taken

modular-magician commented Jan 19, 2023

modular-magician commented Jan 19, 2023

Diff report

modular-magician commented Jan 19, 2023

Tests analytics

Action taken

modular-magician commented Jan 19, 2023

modular-magician commented Jan 19, 2023

Diff report

modular-magician commented Jan 19, 2023

Tests analytics

Action taken

modular-magician commented Jan 19, 2023

modular-magician commented Jan 19, 2023

Diff report

modular-magician commented Jan 19, 2023

Tests analytics

Action taken

modular-magician commented Jan 19, 2023

temawi commented Jan 25, 2023 • edited Loading

modular-magician commented Jan 25, 2023

Diff report

modular-magician commented Jan 25, 2023

Tests analytics

Action taken

modular-magician commented Jan 25, 2023

modular-magician commented Jan 25, 2023

Diff report

modular-magician commented Jan 25, 2023

Tests analytics

hao-nan-li commented Jan 25, 2023 • edited Loading

modular-magician commented Jan 27, 2023

Diff report

modular-magician commented Jan 27, 2023

Tests analytics

Action taken

modular-magician commented Jan 27, 2023

modular-magician commented Jan 27, 2023

Diff report

modular-magician commented Jan 27, 2023

Tests analytics

Action taken

modular-magician commented Jan 27, 2023

temawi commented Jan 25, 2023 •

edited

Loading

hao-nan-li commented Jan 25, 2023 •

edited

Loading