Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add support for Cloud Deploy resources" #5968

Merged
merged 1 commit into from
Apr 22, 2022

Conversation

slevenick
Copy link
Contributor

@slevenick slevenick commented Apr 22, 2022

Reverts #5710

I was contacted by the Cloud Deploy service team that wishes to manage the integration for these Cloud Deploy resources themselves. We are looking at reverting these resources to pull them from the current release to allow the Cloud Deploy team to release them without having to worry about backwards compatibility requirements. We expect the resources managed by their team to be available by next week

Overall we prefer to let the team manage these resources to ensure that features are available faster, with less delay between the feature release and it's availability in Terraform

cc @louisjimenez

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 13 files changed, 2 insertions(+), 2237 deletions(-))
Terraform Beta: Diff ( 13 files changed, 2 insertions(+), 2237 deletions(-))
TF Validator: Diff ( 5 files changed, 3 insertions(+), 407 deletions(-))

@slevenick
Copy link
Contributor Author

FYI @upodroid this has some context on why the resources won't be in the next release

@slevenick slevenick merged commit 4850507 into main Apr 22, 2022
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1985
Passed tests 1742
Skipped tests: 240
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccServiceNetworkingPeeredDNSDomain_basic|TestAccFirebaserulesRelease_BasicRelease|TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic[view]
TestAccFirebaserulesRelease_BasicRelease[view]

Tests failed during RECORDING mode:
TestAccServiceNetworkingPeeredDNSDomain_basic[view]

Please fix these to complete your PR
View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants