Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Terraform]: Make google_project_iam_policy authoritative. #605

Conversation

rileykarson
Copy link
Member

@rileykarson rileykarson commented Oct 23, 2018

Supersedes #581 because of the tpg/tpgb split

Part of hashicorp/terraform-provider-google#1167, hashicorp/terraform-provider-google#1203

Remove the getProject feature - policy is really really dangerous now and users probably do not want to use this resource on their primary/provider project, so let's make them explicitly specify it if they do.


[all]

[terraform]

Make google_project_iam_policy authoritative.

[terraform-beta]

[ansible]

[inspec]

@modular-magician
Copy link
Collaborator

I am a robot that works on MagicModules PRs!

I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#25
depends: hashicorp/terraform-provider-google#2315

@modular-magician
Copy link
Collaborator

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit 20760a0) have been included in your existing downstream PRs.

chrisst pushed a commit to chrisst/magic-modules that referenced this pull request Oct 26, 2018
…ogleCloudPlatform#605)

* disk cleanup

* fix attached disk test

* allow disk sources from name or url

* parse disk source better on read

* update docs

* fix boot disk source url
@rileykarson rileykarson requested review from danawillow and removed request for paddycarver October 30, 2018 14:57
@modular-magician
Copy link
Collaborator

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit a360582) have been included in your existing downstream PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants