Add Dataplex Lake to tpg built from their DCL resources

[saurabh-net]

part of hashicorp/terraform-provider-google#11648

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

`google_dataplex_lake`

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @slevenick, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

---

Your assigned reviewer will help review your code by:

• Ensuring it's backwards compatible, covers common error cases, etc.
• Summarizing the change into a user-facing changelog note.
• Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

---

[saurabh-net]

@slevenick, I've closed an existing pull request (#6049) and am splitting that one into 3 separate pull requests.

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 12 files changed, 634 insertions(+), 11 deletions(-))
Terraform Beta: Diff ( 11 files changed, 630 insertions(+), 7 deletions(-))
TF Validator: Diff ( 3 files changed, 6 insertions(+), 5 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2022
Passed tests 1792
Skipped tests: 226
Failed tests: 4

Action taken

Triggering VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccServiceNetworkingPeeredDNSDomain_basic|TestAccFirebaserulesRelease_BasicRelease|TestAccCloudAssetFolderFeed_cloudAssetFolderFeedExample|TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic

[modular-magician]

Tests passed during RECORDING mode:
TestAccServiceNetworkingPeeredDNSDomain_basic[view]
TestAccFirebaserulesRelease_BasicRelease[view]

Tests failed during RECORDING mode:
TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic[view]
TestAccCloudAssetFolderFeed_cloudAssetFolderFeedExample[view]

Please fix these to complete your PR
View the build log or the debug log for each test

[saurabh-net]

I believe the failing tests are unrelated to this pull request.

[slevenick]

I'm not seeing any tests generated by this. I believe the samples should go under tpgtools/overrides/datalake/samples rather than tpgtools/api which should trigger test generation

[saurabh-net]

I think the tests are supposed to be under tpgtools/api but under a samples directory. I'm using https://github.com/GoogleCloudPlatform/magic-modules/pull/5999/files# as a reference.

I've changed my samples to be in line with this reference pull request. Let me know if it looks fine now.

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 15 files changed, 927 insertions(+), 9 deletions(-))
Terraform Beta: Diff ( 14 files changed, 925 insertions(+), 7 deletions(-))
TF Validator: Diff ( 3 files changed, 6 insertions(+), 5 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2023
Passed tests 1794
Skipped tests: 226
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccFirebaserulesRelease_BasicRelease|TestAccDataplexLake_BasicLake|TestAccCloudAssetFolderFeed_cloudAssetFolderFeedExample

[modular-magician]

Tests passed during RECORDING mode:
TestAccCloudAssetFolderFeed_cloudAssetFolderFeedExample[view]
TestAccFirebaserulesRelease_BasicRelease[view]

Tests failed during RECORDING mode:
TestAccDataplexLake_BasicLake[view]

Please fix these to complete your PR
View the build log or the debug log for each test

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 15 files changed, 933 insertions(+), 13 deletions(-))
Terraform Beta: Diff ( 15 files changed, 939 insertions(+), 19 deletions(-))
TF Validator: Diff ( 3 files changed, 6 insertions(+), 5 deletions(-))

[slevenick]

Looks mostly good. The name field description coming from the DCL is incorrect, so we should fix that prior to release.

https://github.com/modular-magician/terraform-provider-google-beta/compare/auto-pr-6055-old..auto-pr-6055#diff-28f548553b92b83fa060dea95c0a470d0cbdfd311d90d1d3291fdcc237f5ea03R57

It shouldn't say Output only (because it isn't) and shouldn't claim to require the long-form name

[saurabh-net]

I've made the changes to DCL. I'll test the changes here again after DCL cuts a new version to 1.7.1.
I'm not sure what triggers new versions, but I hope we can do that before Monday afternoon.

[modular-magician]

Tests analytics

Total tests: 2023
Passed tests 1795
Skipped tests: 226
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccFirebaserulesRelease_BasicRelease|TestAccDataplexLake_BasicLake

[modular-magician]

Tests passed during RECORDING mode:
TestAccDataplexLake_BasicLake[view]
TestAccFirebaserulesRelease_BasicRelease[view]

All tests passed
View the build log or the debug log for each test

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 13 files changed, 927 insertions(+), 5 deletions(-))
Terraform Beta: Diff ( 13 files changed, 927 insertions(+), 5 deletions(-))
TF Validator: Diff ( 3 files changed, 6 insertions(+), 5 deletions(-))

[slevenick]

Unfortunately DCL version 1.8.0 contains a regression and I don't believe we can upgrade to it at this time, we may need to wait for a fix

[modular-magician]

Tests analytics

Total tests: 2023
Passed tests 1794
Skipped tests: 226
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccIAM2DenyPolicy_iamDenyPolicyBasicExample|TestAccEventarcTrigger_BasicHandWritten|TestAccCloudRunService_eventarcBasicTfExample

[modular-magician]

Tests passed during RECORDING mode:
TestAccCloudRunService_eventarcBasicTfExample[view]
TestAccIAM2DenyPolicy_iamDenyPolicyBasicExample[view]

Tests failed during RECORDING mode:
TestAccEventarcTrigger_BasicHandWritten[view]

Please fix these to complete your PR
View the build log or the debug log for each test

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 15 files changed, 1007 insertions(+), 83 deletions(-))
Terraform Beta: Diff ( 15 files changed, 1007 insertions(+), 83 deletions(-))
TF Validator: Diff ( 3 files changed, 6 insertions(+), 5 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2023
Passed tests 1794
Skipped tests: 226
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccEventarcTrigger_BasicHandWritten|TestAccCloudRunService_eventarcBasicTfExample

[modular-magician]

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[view]

Tests failed during RECORDING mode:
TestAccCloudRunService_eventarcBasicTfExample[view]
TestAccEventarcTrigger_BasicHandWritten[view]

Please fix these to complete your PR
View the build log or the debug log for each test

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 13 files changed, 931 insertions(+), 5 deletions(-))
Terraform Beta: Diff ( 13 files changed, 931 insertions(+), 5 deletions(-))
TF Validator: Diff ( 3 files changed, 6 insertions(+), 5 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2024
Passed tests 1795
Skipped tests: 226
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccEventarcTrigger_BasicHandWritten|TestAccFirebaserulesRelease_BasicRelease|TestAccCloudRunService_eventarcBasicTfExample

[modular-magician]

Tests passed during RECORDING mode:
TestAccCloudRunService_eventarcBasicTfExample[view]
TestAccFirebaserulesRelease_BasicRelease[view]

Tests failed during RECORDING mode:
TestAccEventarcTrigger_BasicHandWritten[view]

Please fix these to complete your PR
View the build log or the debug log for each test

[slevenick]

Looks good, only test failure is unrelated and will be fixed with #6066