Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make provisioned_iops Computed true #6222

Merged
merged 2 commits into from
Jul 8, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions mmv1/products/compute/terraform.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -633,6 +633,9 @@ overrides: !ruby/object:Overrides::ResourceOverrides
required: false
default_from_api: true
custom_flatten: 'templates/terraform/custom_flatten/name_from_self_link.erb'
provisionedIops: !ruby/object:Overrides::Terraform::PropertyOverride
required: false
default_from_api: true
sourceImage: !ruby/object:Overrides::Terraform::PropertyOverride
name: image
diff_suppress_func: 'diskImageDiffSuppress'
Expand Down
31 changes: 31 additions & 0 deletions mmv1/third_party/terraform/tests/resource_compute_disk_test.go.erb
Original file line number Diff line number Diff line change
Expand Up @@ -442,6 +442,27 @@ func TestAccComputeDisk_deleteDetachIGM(t *testing.T) {
})
}

func TestProvisionedIopDisk_basic(t *testing.T) {
edwardmedia marked this conversation as resolved.
Show resolved Hide resolved
t.Parallel()

diskName := fmt.Sprintf("tf-test-%s", randString(t, 10))

vcrTest(t, resource.TestCase{
PreCheck: func() { testAccPreCheck(t) },
Providers: testAccProviders,
Steps: []resource.TestStep{
{
Config: testProvisionedIopsDisk_basic(diskName),
edwardmedia marked this conversation as resolved.
Show resolved Hide resolved
},
{
ResourceName: "google_compute_disk.foobar",
ImportState: true,
ImportStateVerify: true,
},
},
})
}

<% unless version == 'ga' -%>
func TestAccComputeDisk_resourcePolicies(t *testing.T) {
t.Parallel()
Expand Down Expand Up @@ -775,6 +796,16 @@ resource "google_compute_instance_group_manager" "manager" {
`, diskName, mgrName)
}

func testProvisionedIopsDisk_basic(diskName string) string {
return fmt.Sprintf(`
resource "google_compute_disk" "foobar" {
name = "%s"
type = "pd-extreme"
size = 1
}
`, diskName)
}

<% unless version == 'ga' -%>
func testAccComputeDisk_resourcePolicies(diskName, policyName string) string {
return fmt.Sprintf(`
Expand Down