Added network and subnetwork fields to regional NEG resource

[rosmo]

Added network and subnetwork fields to google_compute_region_network_endpoint_group for PSC. These are required when creating a PSC-type NEG that points to a service attachment.

Link to GA API: https://cloud.google.com/compute/docs/reference/rest/v1/regionNetworkEndpointGroups/insert

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: Added `network` and `subnetwork` fields to `google_compute_region_network_endpoint_group` for PSC.

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @slevenick, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

---

Your assigned reviewer will help review your code by:

• Ensuring it's backwards compatible, covers common error cases, etc.
• Summarizing the change into a user-facing changelog note.
• Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

---

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 95 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 3 files changed, 95 insertions(+), 4 deletions(-))
TF Validator: Diff ( 3 files changed, 31 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2106
Passed tests 1875
Skipped tests: 226
Failed tests: 5

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccPrivatecaCertificateAuthority_subordinateCaActivatedByFirstPartyIssuerOnCreation|TestAccSqlUser_mysqlDisabled|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccDataSourceGoogleServiceAccountAccessToken_basic

[modular-magician]

Tests passed during RECORDING mode:
TestAccDataSourceGoogleServiceAccountAccessToken_basic[view]
TestAccSqlUser_mysqlDisabled[view]
TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[view]
TestAccFirebaserulesRelease_BasicRelease[view]

Tests failed during RECORDING mode:
TestAccPrivatecaCertificateAuthority_subordinateCaActivatedByFirstPartyIssuerOnCreation[view]

Please fix these to complete your PR
View the build log or the debug log for each test

[rosmo]

@slevenick Hey, I don't think the failures have anything to do with my changes - looks like flaky tests?

[slevenick]

@slevenick Hey, I don't think the failures have anything to do with my changes - looks like flaky tests?

Yeah, likely flaky tests, you can ignore the unrelated ones.

Can you add a test that uses these fields that you've added? It can either be generated or handwritten in the existing test file

[rosmo]

Hey @slevenick, let me see what I can do wrt testing - there's a ton of resources to set up which makes me a bit wary. I did test things work with provider_overrides, but let me try to figure out whether it's feasible to automatically test it or not (there's a bunch of stuff in the PSC attachment backend that needs to be set).

[rosmo]

@slevenick I added a test for the new fields.

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 254 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 3 files changed, 254 insertions(+), 4 deletions(-))
TF Validator: Diff ( 3 files changed, 31 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 168 insertions(+))

[modular-magician]

Tests analytics

Total tests: 2115
Passed tests 1884
Skipped tests: 226
Failed tests: 5

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample|TestAccComputeInstance_soleTenantNodeAffinities|TestAccPrivatecaCertificateAuthority_subordinateCaActivatedByFirstPartyIssuerOnCreation|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample

[modular-magician]

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[view]
TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample[view]

Tests failed during RECORDING mode:
TestAccComputeInstance_soleTenantNodeAffinities[view]
TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[view]
TestAccPrivatecaCertificateAuthority_subordinateCaActivatedByFirstPartyIssuerOnCreation[view]

Please fix these to complete your PR
View the build log or the debug log for each test

[slevenick]

Thanks!

[rosmo]

@slevenick Thanks for the merge! I checked the results on the provider side and it does seem something went wrong with the code generation (not sure what): hashicorp/terraform-provider-google@471031b

Just wanted to point that out so there not a broken release.

[slevenick]

That's super weird. Looks like it deleted a bunch of files which were then added back in the next merge

Hopefully it's all fine now!