[Terraform]: Make google_storage_default_object_acl authoritative. #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisst
approved these changes
Oct 26, 2018
| } | ||
| } else { | ||
| res.DefaultObjectAcl = defaultObjectAcl | ||
| _, err = config.clientStorage.Buckets.Update(bucket, res).Do() |
There was a problem hiding this comment.
Tiny race condition perhaps? If changes are made the the bucket itself during this update then would this override them?
There was a problem hiding this comment.
You're right! Looks like we can use metadatageneration to stop it - fixed.
|
I am a robot that works on MagicModules PRs! I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
|
I am (still) a robot that works on MagicModules PRs! I just wanted to let you know that your changes (as of commit 63a3ff0) have been included in your existing downstream PRs. |
Tracked submodules are build/terraform-beta build/terraform build/ansible build/inspec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of hashicorp/terraform-provider-google#1167
Originally was gonna look a lot more like #606 but it turns out it doesn't need to (and #606 can likely be simplified too w/o a breaking change)
[all]
[terraform]
Make google_storage_default_object_acl authoritative.
[terraform-beta]
[ansible]
[inspec]