Add the vertex endpoint resource.

[trodge]

Add the google_vertex_ai_endpoint resource.

part of hashicorp/terraform-provider-google#9298

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

google_vertex_ai_endpoint

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @shuyama1, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

---

Your assigned reviewer will help review your code by:

• Ensuring it's backwards compatible, covers common error cases, etc.
• Summarizing the change into a user-facing changelog note.
• Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

---

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 1190 insertions(+))
Terraform Beta: Diff ( 5 files changed, 1204 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2116
Passed tests 1883
Skipped tests: 226
Failed tests: 7

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccDataSourceGoogleServiceAccountJwt|TestAccFirebaserulesRelease_BasicRelease|TestAccComputeInstance_soleTenantNodeAffinities|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccVertexAiEndpoint_NetworkHandWritten|TestAccVertexAiEndpoint_BasicEndpoint|TestAccPrivatecaCertificateAuthority_subordinateCaActivatedByFirstPartyIssuerOnCreation

[modular-magician]

Tests passed during RECORDING mode:
TestAccDataSourceGoogleServiceAccountJwt[view]
TestAccFirebaserulesRelease_BasicRelease[view]

Tests failed during RECORDING mode:
TestAccPrivatecaCertificateAuthority_subordinateCaActivatedByFirstPartyIssuerOnCreation[view]
TestAccVertexAiEndpoint_NetworkHandWritten[view]
TestAccVertexAiEndpoint_BasicEndpoint[view]
TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[view]
TestAccComputeInstance_soleTenantNodeAffinities[view]

Please fix these to complete your PR
View the build log or the debug log for each test

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 1191 insertions(+))
Terraform Beta: Diff ( 6 files changed, 1205 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2128
Passed tests 1891
Skipped tests: 226
Failed tests: 11

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccContainerCluster_withMeshCertificatesConfig|TestAccVertexAiEndpoint_NetworkHandWritten|TestAccVertexAiEndpoint_BasicEndpoint|TestAccComputeInstance_soleTenantNodeAffinities|TestAccFirebaserulesRelease_BasicRelease|TestAccCGCSnippet_eventarcWorkflowsExample|TestAccActiveDirectoryPeering_activeDirectoryPeeringBasicExample|TestAccActiveDirectoryDomain_update|TestAccActiveDirectoryDomain_activeDirectoryDomainBasicExample|TestAccPrivatecaCertificateAuthority_subordinateCaActivatedByFirstPartyIssuerOnCreation|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample

[modular-magician]

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[view]
TestAccVertexAiEndpoint_NetworkHandWritten[view]
TestAccVertexAiEndpoint_BasicEndpoint[view]
TestAccCGCSnippet_eventarcWorkflowsExample[view]

Tests failed during RECORDING mode:
TestAccActiveDirectoryDomain_activeDirectoryDomainBasicExample[view]
TestAccPrivatecaCertificateAuthority_subordinateCaActivatedByFirstPartyIssuerOnCreation[view]
TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[view]
TestAccContainerCluster_withMeshCertificatesConfig[view]
TestAccComputeInstance_soleTenantNodeAffinities[view]
TestAccActiveDirectoryPeering_activeDirectoryPeeringBasicExample[view]
TestAccActiveDirectoryDomain_update[view]

Please fix these to complete your PR
View the build log or the debug log for each test

[trodge]

/gcbrun

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 1191 insertions(+))
Terraform Beta: Diff ( 6 files changed, 1205 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2128
Passed tests 1894
Skipped tests: 226
Failed tests: 8

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccContainerCluster_withMeshCertificatesConfig|TestAccComputeInstance_soleTenantNodeAffinities|TestAccActiveDirectoryDomain_update|TestAccActiveDirectoryDomain_activeDirectoryDomainBasicExample|TestAccActiveDirectoryPeering_activeDirectoryPeeringBasicExample|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccPrivatecaCertificateAuthority_subordinateCaActivatedByFirstPartyIssuerOnCreation

[modular-magician]

Tests passed during RECORDING mode:
TestAccContainerCluster_withMeshCertificatesConfig[view]
TestAccFirebaserulesRelease_BasicRelease[view]

Tests failed during RECORDING mode:
TestAccActiveDirectoryDomain_activeDirectoryDomainBasicExample[view]
TestAccPrivatecaCertificateAuthority_subordinateCaActivatedByFirstPartyIssuerOnCreation[view]
TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[view]
TestAccActiveDirectoryPeering_activeDirectoryPeeringBasicExample[view]
TestAccComputeInstance_soleTenantNodeAffinities[view]
TestAccActiveDirectoryDomain_update[view]

Please fix these to complete your PR
View the build log or the debug log for each test

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 1191 insertions(+))
Terraform Beta: Diff ( 6 files changed, 1205 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2127
Passed tests 1891
Skipped tests: 226
Failed tests: 10

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccCloudfunctions2function_cloudfunctions2BasicAuditlogsExample|TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample|TestAccCloudFunctions2Function_fullUpdate|TestAccCloudRunService_cloudRunServiceStaticOutboundExample|TestAccCGCSnippet_eventarcWorkflowsExample|TestAccComputeInstance_soleTenantNodeAffinities|TestAccActiveDirectoryDomain_activeDirectoryDomainBasicExample|TestAccActiveDirectoryPeering_activeDirectoryPeeringBasicExample|TestAccActiveDirectoryDomain_update

[modular-magician]

Tests passed during RECORDING mode:
TestAccCloudFunctions2Function_fullUpdate[view]
TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[view]
TestAccCloudfunctions2function_cloudfunctions2BasicAuditlogsExample[view]
TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample[view]
TestAccCGCSnippet_eventarcWorkflowsExample[view]

Tests failed during RECORDING mode:
TestAccActiveDirectoryDomain_activeDirectoryDomainBasicExample[view]
TestAccComputeInstance_soleTenantNodeAffinities[view]
TestAccCloudRunService_cloudRunServiceStaticOutboundExample[view]
TestAccActiveDirectoryPeering_activeDirectoryPeeringBasicExample[view]
TestAccActiveDirectoryDomain_update[view]

Please fix these to complete your PR
View the build log or the debug log for each test

[shuyama1]

Looks like beta-only fields shared_resources and enable_container_logging are not generated in the documentation.

Also found that both enable_container_logging and disable_container_logging are implement in tpgb. From the API documentation, it looks like that the field is consistent across v1 and v1beta1 APIs. disableContainerLogging in v1 and enableContainerLogging in v1beta1

[trodge]

Looks like beta-only fields shared_resources and enable_container_logging are not generated in the documentation.

Also found that both enable_container_logging and disable_container_logging are implement in tpgb. From the API documentation, it looks like that the field is consistent across v1 and v1beta1 APIs. disableContainerLogging in v1 and enableContainerLogging in v1beta1

None of the subfields of output-only objects are currently being generated because the template for resource documentation only generates objects that are either Required or Optional. Should this be changed? I can't find any examples of mmv1 resources with output-only object fields.

I've omitted both the enable_container_logging and disable_container_logging fields from the model_deployment resource. I don't see any issue with leaving them in the endpoint resource since they are output-only here and therefore can't be set in a version where they don't exist.

[shuyama1]

Looks like beta-only fields shared_resources and enable_container_logging are not generated in the documentation.
Also found that both enable_container_logging and disable_container_logging are implement in tpgb. From the API documentation, it looks like that the field is consistent across v1 and v1beta1 APIs. disableContainerLogging in v1 and enableContainerLogging in v1beta1

None of the subfields of output-only objects are currently being generated because the template for resource documentation only generates objects that are either Required or Optional. Should this be changed? I can't find any examples of mmv1 resources with output-only object fields.

I've omitted both the enable_container_logging and disable_container_logging fields from the model_deployment resource. I don't see any issue with leaving them in the endpoint resource since they are output-only here and therefore can't be set in a version where they don't exist.

Correct me if I'm wrong. My understanding is that users should be able to access values by using these output-only fields. Are they able to get correct values for enable_container_logging or disable_container_logging even in a version where they don't exist?

[trodge]

Looks like beta-only fields shared_resources and enable_container_logging are not generated in the documentation.
Also found that both enable_container_logging and disable_container_logging are implement in tpgb. From the API documentation, it looks like that the field is consistent across v1 and v1beta1 APIs. disableContainerLogging in v1 and enableContainerLogging in v1beta1

None of the subfields of output-only objects are currently being generated because the template for resource documentation only generates objects that are either Required or Optional. Should this be changed? I can't find any examples of mmv1 resources with output-only object fields.
I've omitted both the enable_container_logging and disable_container_logging fields from the model_deployment resource. I don't see any issue with leaving them in the endpoint resource since they are output-only here and therefore can't be set in a version where they don't exist.

Correct me if I'm wrong. My understanding is that users should be able to access values by using these output-only fields. Are they able to get correct values for enable_container_logging or disable_container_logging even in a version where they don't exist?

I think in the case where the field doesn't exist terraform will just return false, which may or may not be the correct value.

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 6 files changed, 1184 insertions(+))
Terraform Beta: Diff ( 6 files changed, 1198 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[trodge]

I have removed the disable_container_logging field from the spec and updated the DCL.

[modular-magician]

Tests analytics

Total tests: 2142
Passed tests 1903
Skipped tests: 228
Failed tests: 11

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccComputeInstance_networkPerformanceConfig|TestAccComputeInstance_soleTenantNodeAffinities|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample|TestAccCloudfunctions2function_cloudfunctions2BasicAuditlogsExample|TestAccCloudRunService_cloudRunServiceStaticOutboundExample|TestAccCloudFunctions2Function_fullUpdate|TestAccCGCSnippet_eventarcWorkflowsExample|TestAccSqlDatabaseInstance_SqlServerAuditConfig|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange

[modular-magician]

Tests passed during RECORDING mode:
TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample[view]
TestAccCloudfunctions2function_cloudfunctions2BasicAuditlogsExample[view]
TestAccCloudFunctions2Function_fullUpdate[view]
TestAccCGCSnippet_eventarcWorkflowsExample[view]

Tests failed during RECORDING mode:
TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[view]
TestAccComputeInstance_networkPerformanceConfig[view]
TestAccComputeInstance_soleTenantNodeAffinities[view]
TestAccComputeGlobalForwardingRule_internalLoadBalancing[view]
TestAccCloudRunService_cloudRunServiceStaticOutboundExample[view]
TestAccSqlDatabaseInstance_SqlServerAuditConfig[view]
TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange[view]

Please fix these to complete your PR
View the build log or the debug log for each test

[shuyama1]

Thanks @trodge. Starting the review.

[melinath]

closing - this will be implemented in mmv1 instead.