-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Capacity Intelligence Autoscaling #6370
Conversation
Hello! I am a robot who works on Magic Modules PRs. I've detected that you're a community contributor. @melinath, a repository maintainer, has been assigned to assist you and help review your changes. ❓ First time contributing? Click here for more detailsYour assigned reviewer will help review your code by:
You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails. If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox. |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 5 files changed, 225 insertions(+), 24 deletions(-)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccComputeInstanceFromTemplate_overrideMetadataDotStartupScript|TestAccComputeInstance_networkTier|TestAccComputeRegionAutoscaler_update|TestAccComputeRoute_hopInstance|TestAccContainerCluster_withNodePoolAutoscaling|TestAccContainerNodePool_totalSize|TestAccContainerNodePool_autoscaling|TestAccContainerNodePool_regionalAutoscaling|TestAccComputeTargetPool_basic|TestAccComputeTargetPool_update|TestAccComputeSnapshot_encryption|TestAccComputeResourcePolicy_attached|TestAccRegionInstanceGroupManager_update|TestAccRegionInstanceGroupManager_targetSizeZero|TestAccRegionInstanceGroupManager_basic|TestAccComputeRegionDisk_basicUpdate|TestAccComputeRegionDisk_basic|TestAccComputeRegionBackendService_withBackendMultiNic|TestAccComputeRegionBackendService_withBackendInternalManaged|TestAccComputeRegionBackendService_withBackendInternal|TestAccComputeRegionBackendService_ilbUpdateFull|TestAccComputeRegionPerInstanceConfig_update|TestAccComputeInstance_updateTerminated_desiredStatusRunning_notAllowStoppingForUpdate|TestAccComputeRegionAutoscaler_scaleInControl|TestAccComputeRegionDisk_deleteDetach|TestAccComputeRegionAutoscaler_scalingSchedule|TestAccRegionInstanceGroupManager_stateful|TestAccComputeRegionAutoscaler_scaleDownControl|TestAccComputeRegionDisk_encryption|TestAccComputeInstance_updateTerminated_desiredStatusRunning_allowStoppingForUpdate|TestAccRegionInstanceGroupManager_distributionPolicy|TestAccComputeInstance_updateTerminated_desiredStatusTerminated_notAllowStoppingForUpdate|TestAccComputeInstance_updateTerminated_desiredStatusNotSet_notAllowStoppingForUpdate|TestAccRegionInstanceGroupManager_autoHealingPolicies|TestAccComputeInstance_updateTerminated_desiredStatusTerminated_allowStoppingForUpdate|TestAccComputeInstance_minCpuPlatform|TestAccRegionInstanceGroupManager_versions|TestAccComputeInstance_updateTerminated_desiredStatusNotSet_allowStoppingForUpdate|TestAccComputeInstance_guestAcceleratorSkip|TestAccComputeInstance_guestAccelerator|TestAccComputeInstance_updateRunning_desiredStatusTerminated_notAllowStoppingForUpdate|TestAccComputeInstance_forceNewAndChangeMetadata|TestAccComputeInstance_basic2|TestAccComputeInstance_scratchDisk|TestAccComputeInstance_multiNic|TestAccComputeInstance_forceChangeMachineTypeManually|TestAccComputeInstance_updateRunning_desiredStatusRunning_notAllowStoppingForUpdate|TestAccComputeInstance_bootDisk_mode|TestAccComputeInstance_updateRunning_desiredStatusNotSet_notAllowStoppingForUpdate|TestAccComputeInstance_updateRunning_desiredStatusTerminated_allowStoppingForUpdate|TestAccComputeInstance_networkPerformanceConfig|TestAccComputeInstance_private_image_family|TestAccComputeInstance_bootDisk_type|TestAccComputeInstance_updateRunning_desiredStatusRunning_allowStoppingForUpdate|TestAccComputeInstance_desiredStatusTerminatedUpdateFields|TestAccComputeInstance_network_ip_custom|TestAccComputeInstance_networkIPAuto|TestAccComputeInstance_desiredStatusUpdateBasic|TestAccComputeInstance_subnet_custom|TestAccComputeInstance_subnet_auto|TestAccComputeInstance_desiredStatusOnCreation|TestAccComputeInstance_bootDisk_sourceUrl|TestAccComputeInstance_reservationAffinities|TestAccComputeInstance_bootDisk_source|TestAccComputeInstance_attachedDiskUpdate|TestAccComputeInstance_soleTenantNodeAffinities|TestAccComputeInstance_attachedDisk_modeRo|TestAccComputeInstance_attachedDisk_sourceUrl|TestAccComputeInstance_hostname|TestAccComputeInstance_attachedDisk|TestAccComputeInstance_secondaryAliasIpRange|TestAccComputeInstance_resourcePolicyUpdate|TestAccComputeInstance_primaryAliasIpRange|TestAccComputeInstance_basic1|TestAccComputeInstance_deletionProtectionExplicitTrueAndUpdateFalse|TestAccComputeInstance_kmsDiskEncryption|TestAccComputeInstance_diskEncryptionRestart|TestAccComputeInstanceTemplate_spot|TestAccComputeInstance_deletionProtectionExplicitFalse|TestAccComputeInstance_scheduling|TestAccComputeInstanceTemplate_managedEnvoy|TestAccComputeInstanceTemplate_queueCount|TestAccComputeInstance_diskEncryption|TestAccComputeInstance_serviceAccount_updated0to1to0scopes|TestAccComputeInstance_spotVM_update|TestAccComputeInstance_PTRRecord|TestAccComputeInstanceTemplate_secondaryAliasIpRange|TestAccComputeInstance_serviceAccount_updated|TestAccComputeInstance_IPv6|TestAccComputeInstanceTemplate_primaryAliasIpRange|TestAccComputeInstance_serviceAccount|TestAccComputeInstance_IP|TestAccComputeInstance_queueCount|TestAccComputeInstance_basic5|TestAccComputeInstanceTemplate_metadata_startup_script|TestAccComputeInstance_stopInstanceToUpdate|TestAccComputeInstance_subnetworkUpdate|TestAccComputeInstanceTemplate_resourcePolicies|TestAccComputeInstanceTemplate_subnet_custom|TestAccComputeInstance_basic4|TestAccComputeInstance_resourcePolicyCollocate|TestAccComputeInstance_update|TestAccComputeInstance_basic3|TestAccComputeInstanceTemplate_subnet_auto|TestAccComputeInstanceTemplate_regionDisks|TestAccComputeInstanceTemplate_disksInvalid|TestAccComputeInstanceTemplate_disks|TestAccComputeInstanceTemplate_networkIPAddress|TestAccComputeInstanceTemplate_networkIP|TestAccComputeInstanceTemplate_reservationAffinities|TestAccComputeInstanceTemplate_networkTier|TestAccComputeInstanceTemplate_soleTenantNodeAffinities|TestAccComputeInstanceTemplate_IPv6|TestAccComputeInstanceTemplate_minCpuPlatform|TestAccInstanceGroupManager_versions|TestAccComputeInstanceTemplate_EncryptKMS|TestAccComputeInstanceTemplate_guestAcceleratorSkip|TestAccComputeInstanceTemplate_IP|TestAccInstanceGroupManager_update|TestAccComputeInstanceTemplate_guestAccelerator|TestAccComputeInstanceTemplate_preemptible|TestAccInstanceGroupManager_targetSizeZero|TestAccInstanceGroupManager_basic|TestAccComputeInstanceTemplate_basic|TestAccComputeInstanceFromTemplate_012_removableFields|TestAccComputeInstanceFromTemplate_overrideScheduling|TestAccComputeInstanceFromTemplate_overrideScratchDisk|TestAccComputeInstanceIamPolicy|TestAccComputeInstanceFromTemplate_overrideAttachedDisk|TestAccComputeInstanceFromTemplate_overrideBootDisk|TestAccComputeInstanceFromTemplate_basic|TestAccInstanceGroupManager_waitForStatus|TestAccInstanceGroupManager_stateful|TestAccInstanceGroupManager_autoHealingPolicies|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccCloudfunctions2function_cloudfunctions2BasicAuditlogsExample|TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample|TestAccCloudFunctions2Function_fullUpdate|TestAccCloudRunService_cloudRunServiceStaticOutboundExample|TestAccActiveDirectoryDomain_activeDirectoryDomainBasicExample|TestAccActiveDirectoryPeering_activeDirectoryPeeringBasicExample|TestAccActiveDirectoryDomain_update|TestAccDataSourceGoogleComputeInstanceGroup_fromIGM|TestAccDataSourceGoogleComputeInstanceGroup_withNamedPort|TestAccDataSourceGoogleComputeInstanceGroup_basic|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccFirebaserulesRelease_BasicRelease|TestAccNetworkManagementConnectivityTest_update |
The provider crashed while running the VCR tests in RECORDING mode |
timed out - failures were probably related to a separate issue. rerunning /gcbrun |
oh - you'll actually need to fix the merge conflict before tests can rerun @kisieland |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
marking changes requested - see above.
Rebased, but I still see the following errors, while running make test (that are also present on main):
this blocks running acceptance and unit tests |
@melinath PTAL at the above comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The generate-diffs failure should be resolved by #6376 - try rebasing on main one more time.
Yup, this fixed the main, I was able to rebase and fix some of mine misconfigurations and now both tests and lint are working! |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 5 files changed, 232 insertions(+), 28 deletions(-)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccContainerNodePool_regionalAutoscaling|TestAccComputeInstance_networkPerformanceConfig|TestAccComputeInstance_soleTenantNodeAffinities|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccCloudRunService_cloudRunServiceStaticOutboundExample|TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample|TestAccCloudfunctions2function_cloudfunctions2BasicAuditlogsExample|TestAccCloudFunctions2Function_fullUpdate|TestAccActiveDirectoryPeering_activeDirectoryPeeringBasicExample|TestAccActiveDirectoryDomain_update|TestAccActiveDirectoryDomain_activeDirectoryDomainBasicExample |
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
It looks like this maybe got recorded in a previous run and is now passing in VCR? But running a manual test just to be sure: https://ci-oss.hashicorp.engineering/buildConfiguration/GoogleCloudBeta_ProviderGoogleCloudBetaMmUpstream/322368 LGTM assuming that passes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kisieland could you read through https://github.com/GoogleCloudPlatform/magic-modules/blob/main/.ci/RELEASE_NOTES_GUIDE.md and format your release notes accordingly? They should be marked as enhancements, so check out that section, and there should be one block per release note so that they get parsed correctly by our automation. There are also some changes needed to match the style guide.
@melinath updated the release notes PTAL.
PS. sorry for the late response, I was on 2 weeks vacation :) |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 3 files changed, 185 insertions(+), 19 deletions(-)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccSqlUser_mysqlDisabled|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccSqlDatabaseInstance_SqlServerAuditConfig|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange|TestAccComputeInstance_soleTenantNodeAffinities|TestAccComputeInstance_networkPerformanceConfig|TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccCloudFunctions2Function_fullUpdate|TestAccCloudRunService_cloudRunServiceStaticOutboundExample|TestAccCloudfunctions2function_cloudfunctions2BasicAuditlogsExample|TestAccCGCSnippet_eventarcWorkflowsExample |
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
one more test run - https://ci-oss.hashicorp.engineering/buildConfiguration/GoogleCloud_ProviderGoogleCloudMmUpstream/328776 just to be paranoid :-) It looks like this should be fine - no (related) failures in the CI pipeline. I'm not able to reproduce the testAccCheckActiveDirectoryDomainDestroyProducer issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah - I just realized that since this is changing schemaNodePool
, you'll need to add tests & docs for container_cluster as well, since it reuses this variable. Apologies for not catching this sooner!
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 4 files changed, 296 insertions(+), 19 deletions(-)) |
I've added the test to container_cluster, but I did not see any mention of the nodepool autoscaling in the cluster documentation, so I did not add it there. I've re-run the tests and those seem to work correctly. @melinath PTAL :) |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 4 files changed, 299 insertions(+), 19 deletions(-)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccSqlDatabaseInstance_SqlServerAuditConfig|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange|TestAccFirebaserulesRelease_BasicRelease|TestAccComputeInstance_soleTenantNodeAffinities|TestAccContainerCluster_withNodePoolCIA|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccCloudFunctions2Function_fullUpdate|TestAccCGCSnippet_eventarcWorkflowsExample|TestAccCloudRunService_cloudRunServiceStaticOutboundExample|TestAccCloudfunctions2function_cloudfunctions2BasicAuditlogsExample|TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample|TestAccSqlUser_mysqlDisabled|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample |
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
b6aa2db
to
540ef71
Compare
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 4 files changed, 299 insertions(+), 19 deletions(-)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccFirebaserulesRelease_BasicRelease|TestAccContainerCluster_withNodePoolCIA|TestAccComputeInstance_soleTenantNodeAffinities|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccCloudRunService_cloudRunServiceStaticOutboundExample|TestAccSqlDatabaseInstance_SqlServerAuditConfig|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange |
* Location Policy * Total Min and Max size
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 4 files changed, 302 insertions(+), 19 deletions(-)) |
I had a couple of hiccups with |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccSqlDatabaseInstance_SqlServerAuditConfig|TestAccFirebaserulesRelease_BasicRelease|TestAccContainerCluster_withNodePoolCIA|TestAccComputeInstance_soleTenantNodeAffinities|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccCloudRunService_cloudRunServiceStaticOutboundExample|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample |
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
This looks good - running new tests manually once out of paranoia: https://ci-oss.hashicorp.engineering/buildConfiguration/GoogleCloudBeta_ProviderGoogleCloudBetaMmUpstream/331626 |
np, take your time :) |
@melinath Any progress? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for the delay, looks like tests passed
…rm#6370) * Location Policy * Total Min and Max size
Location Policy is a GKE Autoscaling feature that allows users to specify VM distribution between zones.
Total Min and Max size is a complementary GKE Autoscaling feature that allows users to specify total max and min sizes for nodepools (rather than current per zone limits).
Both features are in GA.
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)