Add support for Capacity Intelligence Autoscaling

[kisieland]

Location Policy is a GKE Autoscaling feature that allows users to specify VM distribution between zones.
Total Min and Max size is a complementary GKE Autoscaling feature that allows users to specify total max and min sizes for nodepools (rather than current per zone limits).
Both features are in GA.

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

container: added `autoscaling.total_min_node_count`, `autoscaling.total_max_node_count`, and `autoscaling.location_policy` to `google_container_node_pool` resource

container: added `autoscaling.total_min_node_count`, `autoscaling.total_max_node_count`, and `autoscaling.location_policy` to `google_container_cluster.node_pool`

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @melinath, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

---

Your assigned reviewer will help review your code by:

• Ensuring it's backwards compatible, covers common error cases, etc.
• Summarizing the change into a user-facing changelog note.
• Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

---

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 225 insertions(+), 24 deletions(-))
Terraform Beta: Diff ( 5 files changed, 225 insertions(+), 24 deletions(-))
TF Validator: Diff ( 2 files changed, 54 insertions(+), 29 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2127
Passed tests 1753
Skipped tests: 226
Failed tests: 148

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccComputeInstanceFromTemplate_overrideMetadataDotStartupScript|TestAccComputeInstance_networkTier|TestAccComputeRegionAutoscaler_update|TestAccComputeRoute_hopInstance|TestAccContainerCluster_withNodePoolAutoscaling|TestAccContainerNodePool_totalSize|TestAccContainerNodePool_autoscaling|TestAccContainerNodePool_regionalAutoscaling|TestAccComputeTargetPool_basic|TestAccComputeTargetPool_update|TestAccComputeSnapshot_encryption|TestAccComputeResourcePolicy_attached|TestAccRegionInstanceGroupManager_update|TestAccRegionInstanceGroupManager_targetSizeZero|TestAccRegionInstanceGroupManager_basic|TestAccComputeRegionDisk_basicUpdate|TestAccComputeRegionDisk_basic|TestAccComputeRegionBackendService_withBackendMultiNic|TestAccComputeRegionBackendService_withBackendInternalManaged|TestAccComputeRegionBackendService_withBackendInternal|TestAccComputeRegionBackendService_ilbUpdateFull|TestAccComputeRegionPerInstanceConfig_update|TestAccComputeInstance_updateTerminated_desiredStatusRunning_notAllowStoppingForUpdate|TestAccComputeRegionAutoscaler_scaleInControl|TestAccComputeRegionDisk_deleteDetach|TestAccComputeRegionAutoscaler_scalingSchedule|TestAccRegionInstanceGroupManager_stateful|TestAccComputeRegionAutoscaler_scaleDownControl|TestAccComputeRegionDisk_encryption|TestAccComputeInstance_updateTerminated_desiredStatusRunning_allowStoppingForUpdate|TestAccRegionInstanceGroupManager_distributionPolicy|TestAccComputeInstance_updateTerminated_desiredStatusTerminated_notAllowStoppingForUpdate|TestAccComputeInstance_updateTerminated_desiredStatusNotSet_notAllowStoppingForUpdate|TestAccRegionInstanceGroupManager_autoHealingPolicies|TestAccComputeInstance_updateTerminated_desiredStatusTerminated_allowStoppingForUpdate|TestAccComputeInstance_minCpuPlatform|TestAccRegionInstanceGroupManager_versions|TestAccComputeInstance_updateTerminated_desiredStatusNotSet_allowStoppingForUpdate|TestAccComputeInstance_guestAcceleratorSkip|TestAccComputeInstance_guestAccelerator|TestAccComputeInstance_updateRunning_desiredStatusTerminated_notAllowStoppingForUpdate|TestAccComputeInstance_forceNewAndChangeMetadata|TestAccComputeInstance_basic2|TestAccComputeInstance_scratchDisk|TestAccComputeInstance_multiNic|TestAccComputeInstance_forceChangeMachineTypeManually|TestAccComputeInstance_updateRunning_desiredStatusRunning_notAllowStoppingForUpdate|TestAccComputeInstance_bootDisk_mode|TestAccComputeInstance_updateRunning_desiredStatusNotSet_notAllowStoppingForUpdate|TestAccComputeInstance_updateRunning_desiredStatusTerminated_allowStoppingForUpdate|TestAccComputeInstance_networkPerformanceConfig|TestAccComputeInstance_private_image_family|TestAccComputeInstance_bootDisk_type|TestAccComputeInstance_updateRunning_desiredStatusRunning_allowStoppingForUpdate|TestAccComputeInstance_desiredStatusTerminatedUpdateFields|TestAccComputeInstance_network_ip_custom|TestAccComputeInstance_networkIPAuto|TestAccComputeInstance_desiredStatusUpdateBasic|TestAccComputeInstance_subnet_custom|TestAccComputeInstance_subnet_auto|TestAccComputeInstance_desiredStatusOnCreation|TestAccComputeInstance_bootDisk_sourceUrl|TestAccComputeInstance_reservationAffinities|TestAccComputeInstance_bootDisk_source|TestAccComputeInstance_attachedDiskUpdate|TestAccComputeInstance_soleTenantNodeAffinities|TestAccComputeInstance_attachedDisk_modeRo|TestAccComputeInstance_attachedDisk_sourceUrl|TestAccComputeInstance_hostname|TestAccComputeInstance_attachedDisk|TestAccComputeInstance_secondaryAliasIpRange|TestAccComputeInstance_resourcePolicyUpdate|TestAccComputeInstance_primaryAliasIpRange|TestAccComputeInstance_basic1|TestAccComputeInstance_deletionProtectionExplicitTrueAndUpdateFalse|TestAccComputeInstance_kmsDiskEncryption|TestAccComputeInstance_diskEncryptionRestart|TestAccComputeInstanceTemplate_spot|TestAccComputeInstance_deletionProtectionExplicitFalse|TestAccComputeInstance_scheduling|TestAccComputeInstanceTemplate_managedEnvoy|TestAccComputeInstanceTemplate_queueCount|TestAccComputeInstance_diskEncryption|TestAccComputeInstance_serviceAccount_updated0to1to0scopes|TestAccComputeInstance_spotVM_update|TestAccComputeInstance_PTRRecord|TestAccComputeInstanceTemplate_secondaryAliasIpRange|TestAccComputeInstance_serviceAccount_updated|TestAccComputeInstance_IPv6|TestAccComputeInstanceTemplate_primaryAliasIpRange|TestAccComputeInstance_serviceAccount|TestAccComputeInstance_IP|TestAccComputeInstance_queueCount|TestAccComputeInstance_basic5|TestAccComputeInstanceTemplate_metadata_startup_script|TestAccComputeInstance_stopInstanceToUpdate|TestAccComputeInstance_subnetworkUpdate|TestAccComputeInstanceTemplate_resourcePolicies|TestAccComputeInstanceTemplate_subnet_custom|TestAccComputeInstance_basic4|TestAccComputeInstance_resourcePolicyCollocate|TestAccComputeInstance_update|TestAccComputeInstance_basic3|TestAccComputeInstanceTemplate_subnet_auto|TestAccComputeInstanceTemplate_regionDisks|TestAccComputeInstanceTemplate_disksInvalid|TestAccComputeInstanceTemplate_disks|TestAccComputeInstanceTemplate_networkIPAddress|TestAccComputeInstanceTemplate_networkIP|TestAccComputeInstanceTemplate_reservationAffinities|TestAccComputeInstanceTemplate_networkTier|TestAccComputeInstanceTemplate_soleTenantNodeAffinities|TestAccComputeInstanceTemplate_IPv6|TestAccComputeInstanceTemplate_minCpuPlatform|TestAccInstanceGroupManager_versions|TestAccComputeInstanceTemplate_EncryptKMS|TestAccComputeInstanceTemplate_guestAcceleratorSkip|TestAccComputeInstanceTemplate_IP|TestAccInstanceGroupManager_update|TestAccComputeInstanceTemplate_guestAccelerator|TestAccComputeInstanceTemplate_preemptible|TestAccInstanceGroupManager_targetSizeZero|TestAccInstanceGroupManager_basic|TestAccComputeInstanceTemplate_basic|TestAccComputeInstanceFromTemplate_012_removableFields|TestAccComputeInstanceFromTemplate_overrideScheduling|TestAccComputeInstanceFromTemplate_overrideScratchDisk|TestAccComputeInstanceIamPolicy|TestAccComputeInstanceFromTemplate_overrideAttachedDisk|TestAccComputeInstanceFromTemplate_overrideBootDisk|TestAccComputeInstanceFromTemplate_basic|TestAccInstanceGroupManager_waitForStatus|TestAccInstanceGroupManager_stateful|TestAccInstanceGroupManager_autoHealingPolicies|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccCloudfunctions2function_cloudfunctions2BasicAuditlogsExample|TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample|TestAccCloudFunctions2Function_fullUpdate|TestAccCloudRunService_cloudRunServiceStaticOutboundExample|TestAccActiveDirectoryDomain_activeDirectoryDomainBasicExample|TestAccActiveDirectoryPeering_activeDirectoryPeeringBasicExample|TestAccActiveDirectoryDomain_update|TestAccDataSourceGoogleComputeInstanceGroup_fromIGM|TestAccDataSourceGoogleComputeInstanceGroup_withNamedPort|TestAccDataSourceGoogleComputeInstanceGroup_basic|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccFirebaserulesRelease_BasicRelease|TestAccNetworkManagementConnectivityTest_update

[modular-magician]

The provider crashed while running the VCR tests in RECORDING mode
Please fix it to complete your PR
View the build log

[melinath]

timed out - failures were probably related to a separate issue. rerunning /gcbrun

[melinath]

oh - you'll actually need to fix the merge conflict before tests can rerun @kisieland

[melinath]

marking changes requested - see above.

[kisieland]

Rebased, but I still see the following errors, while running make test (that are also present on main):

go: finding module for package github.com/hashicorp/terraform-provider-clean-google/google
github.com/hashicorp/terraform-provider-google/scripts imports
        github.com/hashicorp/terraform-provider-clean-google/google: cannot find module providing package github.com/hashicorp/terraform-provider-clean-google/google: module github.com/hashicorp/terraform-provider-clean-google/google: git ls-remote -q origin in /usr/local/google/home/danielgutowski/.gvm/pkgsets/go1.18.3/global/pkg/mod/cache/vcs/8a09e4807c89e0e733077bc133bab61829d1c43ee508c409ab431169c786365f: exit status 128:
        remote: Repository not found.
        fatal: repository 'https://github.com/hashicorp/terraform-provider-clean-google/' not found

this blocks running acceptance and unit tests

[kisieland]

@melinath PTAL at the above comment

[melinath]

The generate-diffs failure should be resolved by #6376 - try rebasing on main one more time.

[kisieland]

Yup, this fixed the main, I was able to rebase and fix some of mine misconfigurations and now both tests and lint are working!
@melinath Please take another look :)

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 232 insertions(+), 28 deletions(-))
Terraform Beta: Diff ( 5 files changed, 232 insertions(+), 28 deletions(-))
TF Validator: Diff ( 2 files changed, 54 insertions(+), 29 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2127
Passed tests 1889
Skipped tests: 226
Failed tests: 12

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccContainerNodePool_regionalAutoscaling|TestAccComputeInstance_networkPerformanceConfig|TestAccComputeInstance_soleTenantNodeAffinities|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccCloudRunService_cloudRunServiceStaticOutboundExample|TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample|TestAccCloudfunctions2function_cloudfunctions2BasicAuditlogsExample|TestAccCloudFunctions2Function_fullUpdate|TestAccActiveDirectoryPeering_activeDirectoryPeeringBasicExample|TestAccActiveDirectoryDomain_update|TestAccActiveDirectoryDomain_activeDirectoryDomainBasicExample

[modular-magician]

Tests passed during RECORDING mode:
TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[view]
TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample[view]
TestAccCloudfunctions2function_cloudfunctions2BasicAuditlogsExample[view]
TestAccCloudFunctions2Function_fullUpdate[view]
TestAccContainerNodePool_regionalAutoscaling[view]

Tests failed during RECORDING mode:
TestAccComputeInstance_soleTenantNodeAffinities[view]
TestAccComputeInstance_networkPerformanceConfig[view]
TestAccComputeGlobalForwardingRule_internalLoadBalancing[view]
TestAccActiveDirectoryPeering_activeDirectoryPeeringBasicExample[view]
TestAccCloudRunService_cloudRunServiceStaticOutboundExample[view]
TestAccActiveDirectoryDomain_update[view]
TestAccActiveDirectoryDomain_activeDirectoryDomainBasicExample[view]

Please fix these to complete your PR
View the build log or the debug log for each test

[melinath]

It looks like this maybe got recorded in a previous run and is now passing in VCR? But running a manual test just to be sure: https://ci-oss.hashicorp.engineering/buildConfiguration/GoogleCloudBeta_ProviderGoogleCloudBetaMmUpstream/322368 LGTM assuming that passes.

[melinath]

@kisieland could you read through https://github.com/GoogleCloudPlatform/magic-modules/blob/main/.ci/RELEASE_NOTES_GUIDE.md and format your release notes accordingly? They should be marked as enhancements, so check out that section, and there should be one block per release note so that they get parsed correctly by our automation. There are also some changes needed to match the style guide.

[kisieland]

@melinath updated the release notes PTAL.
I've also solved the merge conflict, but it seems that there is an issue on the main branch, because when I tried to re-run tests I received the following error (also on the main branch):

==> Checking source code against gofmt...
==> Checking that code complies with gofmt requirements...
go generate  ./...
go test  -timeout=30s $(go list ./... | grep -v github.com/hashicorp/terraform-provider-google/scripts)
# github.com/hashicorp/terraform-provider-google/google [github.com/hashicorp/terraform-provider-google/google.test]
google/resource_active_directory_domain_update_test.go:87:6: testAccCheckActiveDirectoryDomainDestroyProducer redeclared in this block
        google/resource_active_directory_domain_generated_test.go:61:6: other declaration of testAccCheckActiveDirectoryDomainDestroyProducer
?       github.com/hashicorp/terraform-provider-google  [no test files]
FAIL    github.com/hashicorp/terraform-provider-google/google [build failed]
?       github.com/hashicorp/terraform-provider-google/version  [no test files]
FAIL
make: *** [GNUmakefile:11: test] Error 2

PS. sorry for the late response, I was on 2 weeks vacation :)

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 185 insertions(+), 19 deletions(-))
Terraform Beta: Diff ( 3 files changed, 185 insertions(+), 19 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2140
Passed tests 1900
Skipped tests: 228
Failed tests: 12

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccSqlUser_mysqlDisabled|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccSqlDatabaseInstance_SqlServerAuditConfig|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange|TestAccComputeInstance_soleTenantNodeAffinities|TestAccComputeInstance_networkPerformanceConfig|TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccCloudFunctions2Function_fullUpdate|TestAccCloudRunService_cloudRunServiceStaticOutboundExample|TestAccCloudfunctions2function_cloudfunctions2BasicAuditlogsExample|TestAccCGCSnippet_eventarcWorkflowsExample

[modular-magician]

Tests passed during RECORDING mode:
TestAccSqlUser_mysqlDisabled[view]
TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[view]
TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRangeClone[view]
TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample[view]
TestAccCloudFunctions2Function_fullUpdate[view]
TestAccCloudfunctions2function_cloudfunctions2BasicAuditlogsExample[view]
TestAccCGCSnippet_eventarcWorkflowsExample[view]

Tests failed during RECORDING mode:
TestAccSqlDatabaseInstance_SqlServerAuditConfig[view]
TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange[view]
TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRangeReplica[view]
TestAccComputeInstance_soleTenantNodeAffinities[view]
TestAccComputeInstance_networkPerformanceConfig[view]
TestAccComputeGlobalForwardingRule_internalLoadBalancing[view]
TestAccCloudRunService_cloudRunServiceStaticOutboundExample[view]

Please fix these to complete your PR
View the build log or the debug log for each test

[melinath]

one more test run - https://ci-oss.hashicorp.engineering/buildConfiguration/GoogleCloud_ProviderGoogleCloudMmUpstream/328776 just to be paranoid :-) It looks like this should be fine - no (related) failures in the CI pipeline.

I'm not able to reproduce the testAccCheckActiveDirectoryDomainDestroyProducer issue

[melinath]

Ah - I just realized that since this is changing schemaNodePool, you'll need to add tests & docs for container_cluster as well, since it reuses this variable. Apologies for not catching this sooner!

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 296 insertions(+), 19 deletions(-))
Terraform Beta: Diff ( 4 files changed, 296 insertions(+), 19 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[kisieland]

I've added the test to container_cluster, but I did not see any mention of the nodepool autoscaling in the cluster documentation, so I did not add it there.
There are mentions of the cluster level autoscaling, which are something different from the one I am changing.

I've re-run the tests and those seem to work correctly. @melinath PTAL :)

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 299 insertions(+), 19 deletions(-))
Terraform Beta: Diff ( 4 files changed, 299 insertions(+), 19 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2148
Passed tests 1903
Skipped tests: 232
Failed tests: 13

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccSqlDatabaseInstance_SqlServerAuditConfig|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange|TestAccFirebaserulesRelease_BasicRelease|TestAccComputeInstance_soleTenantNodeAffinities|TestAccContainerCluster_withNodePoolCIA|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccCloudFunctions2Function_fullUpdate|TestAccCGCSnippet_eventarcWorkflowsExample|TestAccCloudRunService_cloudRunServiceStaticOutboundExample|TestAccCloudfunctions2function_cloudfunctions2BasicAuditlogsExample|TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample|TestAccSqlUser_mysqlDisabled|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample

[modular-magician]

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[view]
TestAccCloudFunctions2Function_fullUpdate[view]
TestAccCloudfunctions2function_cloudfunctions2BasicAuditlogsExample[view]
TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample[view]
TestAccSqlUser_mysqlDisabled[view]

Tests failed during RECORDING mode:
TestAccSqlDatabaseInstance_SqlServerAuditConfig[view]
TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange[view]
TestAccComputeInstance_soleTenantNodeAffinities[view]
TestAccContainerCluster_withNodePoolCIA[view]
TestAccComputeGlobalForwardingRule_internalLoadBalancing[view]
TestAccCGCSnippet_eventarcWorkflowsExample[view]
TestAccCloudRunService_cloudRunServiceStaticOutboundExample[view]
TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[view]

Please fix these to complete your PR
View the build log or the debug log for each test

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 299 insertions(+), 19 deletions(-))
Terraform Beta: Diff ( 4 files changed, 299 insertions(+), 19 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2148
Passed tests 1908
Skipped tests: 232
Failed tests: 8

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccContainerCluster_withNodePoolCIA|TestAccComputeInstance_soleTenantNodeAffinities|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccCloudRunService_cloudRunServiceStaticOutboundExample|TestAccSqlDatabaseInstance_SqlServerAuditConfig|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 302 insertions(+), 19 deletions(-))
Terraform Beta: Diff ( 4 files changed, 302 insertions(+), 19 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[kisieland]

I had a couple of hiccups with TestAccContainerCluster_withNodePoolCIA test, but it should pass now.
Btw. Thanks for editing the release notes :)

[modular-magician]

Tests analytics

Total tests: 2148
Passed tests 1908
Skipped tests: 232
Failed tests: 8

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccSqlDatabaseInstance_SqlServerAuditConfig|TestAccFirebaserulesRelease_BasicRelease|TestAccContainerCluster_withNodePoolCIA|TestAccComputeInstance_soleTenantNodeAffinities|TestAccComputeGlobalForwardingRule_internalLoadBalancing|TestAccCloudRunService_cloudRunServiceStaticOutboundExample|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample

[modular-magician]

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[view]
TestAccContainerCluster_withNodePoolCIA[view]

Tests failed during RECORDING mode:
TestAccSqlDatabaseInstance_SqlServerAuditConfig[view]
TestAccComputeInstance_soleTenantNodeAffinities[view]
TestAccComputeGlobalForwardingRule_internalLoadBalancing[view]
TestAccCloudRunService_cloudRunServiceStaticOutboundExample[view]
TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange[view]
TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[view]

Please fix these to complete your PR
View the build log or the debug log for each test

[melinath]

This looks good - running new tests manually once out of paranoia: https://ci-oss.hashicorp.engineering/buildConfiguration/GoogleCloudBeta_ProviderGoogleCloudBetaMmUpstream/331626

[kisieland]

np, take your time :)

[kisieland]

@melinath Any progress? :)

[melinath]

sorry for the delay, looks like tests passed