Added support persistence_config field to google_redis_instance resource. #6528

googlerjk · 2022-09-09T10:38:19Z

Put a description of what this PR is for here, along with any references to issues that this resolves or contributes to -->
Added support persistence_config field to 'google_redis_instance' resource.
Fixes this update

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

redis: Added `persistence_config` field to the `google_redis_instance` resource.

modular-magician · 2022-09-09T10:50:40Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 305 insertions(+), 14 deletions(-))
Terraform Beta: Diff ( 3 files changed, 305 insertions(+), 14 deletions(-))
TF Validator: Diff ( 3 files changed, 65 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 126 insertions(+))

modular-magician · 2022-09-09T11:54:10Z

Tests analytics

Total tests: 2171
Passed tests 1923
Skipped tests: 236
Failed tests: 12

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccRedisInstance_redisInstanceAuthEnabled|TestAccComputeInstance_soleTenantNodeAffinities|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccRedisInstance_regionFromLocation|TestAccRedisInstance_updateReadReplicasModeWithAutoSecondaryIp|TestAccRedisInstance_updateReadReplicasMode|TestAccRedisInstance_update|TestAccRedisInstance_redisInstanceFullWithPersistenceConfigExample|TestAccRedisInstance_redisInstanceFullExample|TestAccRedisInstance_redisInstanceBasicExample|TestAccRedisInstanceDatasource_basic|TestAccRedisInstance_downgradeRedisVersion

modular-magician · 2022-09-09T12:00:44Z

Tests passed during RECORDING mode:
TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[Debug log]

Tests failed during RECORDING mode:
TestAccRedisInstance_redisInstanceAuthEnabled[Error message] [Debug log]
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]
TestAccRedisInstance_regionFromLocation[Error message] [Debug log]
TestAccRedisInstance_updateReadReplicasModeWithAutoSecondaryIp[Error message] [Debug log]
TestAccRedisInstance_updateReadReplicasMode[Error message] [Debug log]
TestAccRedisInstance_update[Error message] [Debug log]
TestAccRedisInstance_redisInstanceFullWithPersistenceConfigExample[Error message] [Debug log]
TestAccRedisInstance_redisInstanceFullExample[Error message] [Debug log]
TestAccRedisInstance_redisInstanceBasicExample[Error message] [Debug log]
TestAccRedisInstanceDatasource_basic[Error message] [Debug log]
TestAccRedisInstance_downgradeRedisVersion[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2022-09-10T08:45:08Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 276 insertions(+), 14 deletions(-))
Terraform Beta: Diff ( 3 files changed, 276 insertions(+), 14 deletions(-))
TF Validator: Diff ( 3 files changed, 65 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 112 insertions(+))

modular-magician · 2022-09-10T09:53:39Z

Tests analytics

Total tests: 2171
Passed tests 1923
Skipped tests: 236
Failed tests: 12

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccRedisInstanceDatasource_basic|TestAccRedisInstance_redisInstanceAuthEnabled|TestAccRedisInstance_regionFromLocation|TestAccRedisInstance_updateReadReplicasModeWithAutoSecondaryIp|TestAccRedisInstance_update|TestAccRedisInstance_redisInstanceFullWithPersistenceConfigExample|TestAccRedisInstance_redisInstanceFullExample|TestAccRedisInstance_downgradeRedisVersion|TestAccRedisInstance_updateReadReplicasMode|TestAccRedisInstance_redisInstanceBasicExample|TestAccComputeInstance_soleTenantNodeAffinities|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample

modular-magician · 2022-09-10T10:00:38Z

Tests passed during RECORDING mode:
TestAccRedisInstance_redisInstanceFullWithPersistenceConfigExample[Debug log]
TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[Debug log]

Tests failed during RECORDING mode:
TestAccRedisInstanceDatasource_basic[Error message] [Debug log]
TestAccRedisInstance_redisInstanceAuthEnabled[Error message] [Debug log]
TestAccRedisInstance_regionFromLocation[Error message] [Debug log]
TestAccRedisInstance_updateReadReplicasModeWithAutoSecondaryIp[Error message] [Debug log]
TestAccRedisInstance_update[Error message] [Debug log]
TestAccRedisInstance_redisInstanceFullExample[Error message] [Debug log]
TestAccRedisInstance_downgradeRedisVersion[Error message] [Debug log]
TestAccRedisInstance_updateReadReplicasMode[Error message] [Debug log]
TestAccRedisInstance_redisInstanceBasicExample[Error message] [Debug log]
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2022-09-12T21:55:45Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 281 insertions(+), 14 deletions(-))
Terraform Beta: Diff ( 3 files changed, 281 insertions(+), 14 deletions(-))
TF Validator: Diff ( 3 files changed, 65 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 113 insertions(+))

modular-magician · 2022-09-12T23:03:28Z

Tests analytics

Total tests: 2172
Passed tests 1921
Skipped tests: 237
Failed tests: 14

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccRedisInstance_redisInstanceFullWithPersistenceConfigExample|TestAccRedisInstance_updateReadReplicasMode|TestAccRedisInstance_update|TestAccRedisInstance_updateReadReplicasModeWithAutoSecondaryIp|TestAccRedisInstance_redisInstanceAuthEnabled|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccFirebaserulesRelease_BasicRelease|TestAccComputeInstance_soleTenantNodeAffinities|TestAccCloudFunctionsFunction_vpcConnector|TestAccCloudRunService_cloudRunServiceStaticOutboundExample|TestAccAppEngineStandardAppVersion_update|TestAccVPCAccessConnector_cloudrunVPCAccessConnectorExample|TestAccVPCAccessConnector_vpcAccessConnectorSharedVPCExample|TestAccVPCAccessConnector_vpcAccessConnectorExample

modular-magician · 2022-09-12T23:18:45Z

Tests passed during RECORDING mode:
TestAccRedisInstance_updateReadReplicasMode[Debug log]
TestAccRedisInstance_update[Debug log]
TestAccRedisInstance_updateReadReplicasModeWithAutoSecondaryIp[Debug log]
TestAccRedisInstance_redisInstanceAuthEnabled[Debug log]
TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[Debug log]
TestAccFirebaserulesRelease_BasicRelease[Debug log]

Tests failed during RECORDING mode:
TestAccRedisInstance_redisInstanceFullWithPersistenceConfigExample[Error message] [Debug log]
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]
TestAccCloudFunctionsFunction_vpcConnector[Error message] [Debug log]
TestAccCloudRunService_cloudRunServiceStaticOutboundExample[Error message] [Debug log]
TestAccAppEngineStandardAppVersion_update[Error message] [Debug log]
TestAccVPCAccessConnector_cloudrunVPCAccessConnectorExample[Error message] [Debug log]
TestAccVPCAccessConnector_vpcAccessConnectorSharedVPCExample[Error message] [Debug log]
TestAccVPCAccessConnector_vpcAccessConnectorExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

c2thorn · 2022-09-13T15:14:58Z

rdb_snapshot_start_time needs to default to api as well?

modular-magician · 2022-09-13T19:48:33Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 282 insertions(+), 14 deletions(-))
Terraform Beta: Diff ( 3 files changed, 282 insertions(+), 14 deletions(-))
TF Validator: Diff ( 3 files changed, 65 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 113 insertions(+))

modular-magician · 2022-09-13T20:56:33Z

Tests analytics

Total tests: 2172
Passed tests 1924
Skipped tests: 238
Failed tests: 10

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccVPCAccessConnector_vpcAccessConnectorExample|TestAccVPCAccessConnector_vpcAccessConnectorSharedVPCExample|TestAccVPCAccessConnector_cloudrunVPCAccessConnectorExample|TestAccComputeForwardingRule_update|TestAccComputeInstance_soleTenantNodeAffinities|TestAccCloudFunctionsFunction_vpcConnector|TestAccCloudRunService_cloudRunServiceStaticOutboundExample|TestAccCGCSnippet_eventarcWorkflowsExample|TestAccAppEngineStandardAppVersion_update|TestAccRedisInstance_redisInstanceFullWithPersistenceConfigExample

modular-magician · 2022-09-13T21:03:05Z

Tests passed during RECORDING mode:
TestAccComputeForwardingRule_update[Debug log]
TestAccRedisInstance_redisInstanceFullWithPersistenceConfigExample[Debug log]

Tests failed during RECORDING mode:
TestAccVPCAccessConnector_vpcAccessConnectorExample[Error message] [Debug log]
TestAccVPCAccessConnector_vpcAccessConnectorSharedVPCExample[Error message] [Debug log]
TestAccVPCAccessConnector_cloudrunVPCAccessConnectorExample[Error message] [Debug log]
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]
TestAccCloudFunctionsFunction_vpcConnector[Error message] [Debug log]
TestAccCloudRunService_cloudRunServiceStaticOutboundExample[Error message] [Debug log]
TestAccCGCSnippet_eventarcWorkflowsExample[Error message] [Debug log]
TestAccAppEngineStandardAppVersion_update[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

c2thorn · 2022-09-14T16:23:58Z

mmv1/products/redis/api.yaml

+            description: |
+              Optional. Controls whether Persistence features are enabled. If not provided, the existing value will be used.
+
+              - PERSISTENCE_MODE_UNSPECIFIED:	Not set.


Can we remove the PERSISTENCE_MODE_UNSPECIFIED and SNAPSHOT_PERIOD_UNSPECIFIED values/references?

modular-magician · 2022-09-14T21:54:05Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 278 insertions(+), 14 deletions(-))
Terraform Beta: Diff ( 3 files changed, 278 insertions(+), 14 deletions(-))
TF Validator: Diff ( 3 files changed, 65 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 113 insertions(+))

modular-magician · 2022-09-14T22:46:37Z

Tests analytics

Total tests: 2172
Passed tests 1931
Skipped tests: 238
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccComputeInstance_soleTenantNodeAffinities|TestAccComputeForwardingRule_update|TestAccCGCSnippet_eventarcWorkflowsExample

modular-magician · 2022-09-14T22:51:53Z

Tests passed during RECORDING mode:
TestAccComputeForwardingRule_update[Debug log]

Tests failed during RECORDING mode:
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]
TestAccCGCSnippet_eventarcWorkflowsExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

googlerjk · 2022-10-11T07:18:37Z

Ill see what happens when i do.

…

On Wed, Sep 14, 2022 at 9:24 AM Cameron Thornton ***@***.***> wrote: ***@***.**** requested changes on this pull request. ------------------------------ In mmv1/products/redis/api.yaml <#6528 (comment)> : > @@ -143,6 +143,57 @@ objects: The ID of the instance or a fully qualified identifier for the instance. required: true input: true + - !ruby/object:Api::Type::NestedObject + name: persistenceConfig + description: Maintenance policy for an instance. + properties: + - !ruby/object:Api::Type::Enum + name: 'persistenceMode' + required: true + description: | + Optional. Controls whether Persistence features are enabled. If not provided, the existing value will be used. + + - PERSISTENCE_MODE_UNSPECIFIED: Not set. Can we remove the PERSISTENCE_MODE_UNSPECIFIED and SNAPSHOT_PERIOD_UNSPECIFIED values/references? — Reply to this email directly, view it on GitHub <#6528 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AY7OLKFFWK4AQGWR5T2WY53V6H32ZANCNFSM6AAAAAAQIRZJAU> . You are receiving this because you were assigned.Message ID: ***@***.***>

jcanseco · 2022-10-20T21:33:20Z

Hi @googlerjk @c2thorn. Quick question: Is the rdb_snapshot_period field supposed to be optional, not required? It's optional in the API docs. Just want to check to make sure I understand correctly.

c2thorn · 2022-10-20T21:54:28Z

Hi @googlerjk @c2thorn. Quick question: Is the rdb_snapshot_period field supposed to be optional, not required? It's optional in the API docs. Just want to check to make sure I understand correctly.

Looks like a miss on my review. Our own documentation states it as optional. Luckily required -> optional is a non-breaking change. @googlerjk Can you correct this in a new PR? @c2thorn sure thing.

jcanseco · 2022-10-20T22:03:49Z

Great, thank you for confirming! Do you want me to file an issue?

c2thorn · 2022-10-21T16:13:21Z

@jcanseco that would be helpful, thank you!

jcanseco · 2022-10-21T17:17:54Z

Done: hashicorp/terraform-provider-google#12854

draft of a basic instance iteration with persistence config

3dd2c31

googlerjk requested a review from c2thorn September 9, 2022 10:38

googlerjk self-assigned this Sep 9, 2022

googlerjk added 2 commits September 10, 2022 08:26

minimal configuration update

2234194

yaml cleanup

d48ce8e

googlerjk marked this pull request as ready for review September 12, 2022 19:29

fields set to default from api

12c6906

googlerjk added 2 commits September 13, 2022 19:24

fields set to default from api

ba29f43

fields set to default from api

ec67111

c2thorn requested changes Sep 14, 2022

View reviewed changes

invalid enums removed

cca05bf

modular-magician requested a review from c2thorn September 14, 2022 21:43

c2thorn approved these changes Sep 15, 2022

View reviewed changes

c2thorn merged commit e3f8828 into GoogleCloudPlatform:main Sep 15, 2022

c2thorn mentioned this pull request Oct 3, 2022

Add support for RBD snapshots in google_redis_instance hashicorp/terraform-provider-google#11197

Closed

jcanseco mentioned this pull request Oct 21, 2022

google_redis_instance rdb_snapshot_period shoud be optional hashicorp/terraform-provider-google#12854

Closed

rileykarson mentioned this pull request Feb 8, 2023

Added support for persistence_config field to google_redis_instance resource. #6729

Closed

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added support persistence_config field to google_redis_instance resource. #6528

Added support persistence_config field to google_redis_instance resource. #6528

googlerjk commented Sep 9, 2022 •

edited

Loading

modular-magician commented Sep 9, 2022

modular-magician commented Sep 9, 2022

modular-magician commented Sep 9, 2022

modular-magician commented Sep 10, 2022

modular-magician commented Sep 10, 2022

modular-magician commented Sep 10, 2022

modular-magician commented Sep 12, 2022

modular-magician commented Sep 12, 2022

modular-magician commented Sep 12, 2022

c2thorn commented Sep 13, 2022

modular-magician commented Sep 13, 2022

modular-magician commented Sep 13, 2022

modular-magician commented Sep 13, 2022

c2thorn Sep 14, 2022

googlerjk Sep 15, 2022

modular-magician commented Sep 14, 2022

modular-magician commented Sep 14, 2022

modular-magician commented Sep 14, 2022

googlerjk commented Oct 11, 2022 via email

jcanseco commented Oct 20, 2022

c2thorn commented Oct 20, 2022 •

edited by googlerjk

Loading

jcanseco commented Oct 20, 2022

c2thorn commented Oct 21, 2022

jcanseco commented Oct 21, 2022

Added support persistence_config field to google_redis_instance resource. #6528

Added support persistence_config field to google_redis_instance resource. #6528

Conversation

googlerjk commented Sep 9, 2022 • edited Loading

modular-magician commented Sep 9, 2022

Diff report:

modular-magician commented Sep 9, 2022

Tests analytics

Action taken

modular-magician commented Sep 9, 2022

modular-magician commented Sep 10, 2022

Diff report:

modular-magician commented Sep 10, 2022

Tests analytics

Action taken

modular-magician commented Sep 10, 2022

modular-magician commented Sep 12, 2022

Diff report:

modular-magician commented Sep 12, 2022

Tests analytics

Action taken

modular-magician commented Sep 12, 2022

c2thorn commented Sep 13, 2022

modular-magician commented Sep 13, 2022

Diff report:

modular-magician commented Sep 13, 2022

Tests analytics

Action taken

modular-magician commented Sep 13, 2022

c2thorn Sep 14, 2022

Choose a reason for hiding this comment

googlerjk Sep 15, 2022

Choose a reason for hiding this comment

modular-magician commented Sep 14, 2022

Diff report:

modular-magician commented Sep 14, 2022

Tests analytics

Action taken

modular-magician commented Sep 14, 2022

googlerjk commented Oct 11, 2022 via email

jcanseco commented Oct 20, 2022

c2thorn commented Oct 20, 2022 • edited by googlerjk Loading

jcanseco commented Oct 20, 2022

c2thorn commented Oct 21, 2022

jcanseco commented Oct 21, 2022

googlerjk commented Sep 9, 2022 •

edited

Loading

c2thorn commented Oct 20, 2022 •

edited by googlerjk

Loading