Fix Monitoring Test

[ScottSuarez]

unblocks #6468
Release Note Template for Downstream PRs (will be copied)

[modular-magician]

Hi there, I'm the modular magician!

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field banana_mode no longer exists on resource_x - reference
• Resource resource_y no longer exists - reference

If you believe the detection is incorrect, please raise it with your reviewer. If you intend to make the change you will likely need to await a major release window.

Diff Report:

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 14 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 1 file changed, 18 insertions(+), 3 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2171
Passed tests 1924
Skipped tests: 238
Failed tests: 9

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccContainerCluster_withMonitoringConfig|TestAccComputeInstance_soleTenantNodeAffinities|TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample|TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample|TestAccRedisInstance_redisInstanceAuthEnabled|TestAccRedisInstance_updateReadReplicasModeWithAutoSecondaryIp|TestAccRedisInstance_updateReadReplicasMode|TestAccRedisInstance_update

[modular-magician]

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample[Debug log]
TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample[Debug log]
TestAccRedisInstance_redisInstanceAuthEnabled[Debug log]
TestAccRedisInstance_updateReadReplicasModeWithAutoSecondaryIp[Debug log]
TestAccRedisInstance_updateReadReplicasMode[Debug log]
TestAccRedisInstance_update[Debug log]

Tests failed during RECORDING mode:
TestAccContainerCluster_withMonitoringConfig[Error message] [Debug log]
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 22 insertions(+), 8 deletions(-))
Terraform Beta: Diff ( 1 file changed, 46 insertions(+), 24 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2172
Passed tests 1927
Skipped tests: 238
Failed tests: 7

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccContainerCluster_withMonitoringConfig|TestAccComputeInstance_soleTenantNodeAffinities|TestAccCGCSnippet_eventarcWorkflowsExample|TestAccRedisInstance_redisInstanceAuthEnabled|TestAccRedisInstance_updateReadReplicasMode|TestAccRedisInstance_update|TestAccRedisInstance_updateReadReplicasModeWithAutoSecondaryIp

[modular-magician]

Tests passed during RECORDING mode:
TestAccContainerCluster_withMonitoringConfig[Debug log]
TestAccRedisInstance_redisInstanceAuthEnabled[Debug log]
TestAccRedisInstance_updateReadReplicasMode[Debug log]
TestAccRedisInstance_update[Debug log]
TestAccRedisInstance_updateReadReplicasModeWithAutoSecondaryIp[Debug log]

Tests failed during RECORDING mode:
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]
TestAccCGCSnippet_eventarcWorkflowsExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

[renescheepers]

@ScottSuarez it should still test the monitoring config for Kubernetes version which don't expose control plane metrics. Only APISERVER, CONTROLLER_MANAGER, and SCHEDULER are unsupported in older versions.

func testAccContainerCluster_withMonitoringConfigUpdated(name string) string {
	return fmt.Sprintf(`
resource "google_container_cluster" "primary" {
name               = "%s"
location           = "us-central1-a"
initial_node_count = 1
monitoring_config {
		enable_components = [ "SYSTEM_COMPONENTS",  "WORKLOADS" ]
}
}
`, name)
}

[melinath]

lgtm - one question & one whitespace cleanup request

[ScottSuarez]

@ScottSuarez it should still test the monitoring config for Kubernetes version which don't expose control plane metrics. Only APISERVER, CONTROLLER_MANAGER, and SCHEDULER are unsupported in older versions.

I've checked in this change for now. It should unblock your change. Could you make improvements with test within your PR to better cover these scenarios. Thanks for any help and expertise you can provide.

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 22 insertions(+), 8 deletions(-))
Terraform Beta: Diff ( 1 file changed, 46 insertions(+), 24 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2174
Passed tests 1933
Skipped tests: 238
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccComputeInstance_soleTenantNodeAffinities|TestAccComputeForwardingRule_update

[modular-magician]

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccComputeForwardingRule_update[Debug log]

Tests failed during RECORDING mode:
TestAccComputeInstance_soleTenantNodeAffinities[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test