make vm_count in google_compute_resource_policy as optional

[Timus1712]

fixes hashicorp/terraform-provider-google#11483

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: Made `vm_count` in `google_compute_resource_policy` optional

[Timus1712]

TestAccComputeResourcePolicy_attached is failing (without clear error) but it's also is failing on main branch.

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @c2thorn, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

---

Your assigned reviewer will help review your code by:

• Ensuring it's backwards compatible, covers common error cases, etc.
• Summarizing the change into a user-facing changelog note.
• Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

---

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 2 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 1 file changed, 2 insertions(+), 2 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2186
Passed tests 1945
Skipped tests: 239
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccComputeForwardingRule_update|TestAccDataSourceGoogleServiceAccountIdToken_basic

[modular-magician]

Tests passed during RECORDING mode:
TestAccComputeForwardingRule_update[Debug log]
TestAccDataSourceGoogleServiceAccountIdToken_basic[Debug log]

All tests passed
View the build log or the debug log for each test

[c2thorn]

From what I understand the at_least_one_of restriction actually allowed both vm_count and availability_domain_count to be set in the same config. Changing this to conflicts now introduces a new restriction that would make configs that did that invalid, thus a breaking change.

Could these fields absolutely not both be set? I would lean towards removing the restrictions entirely and letting the API handle the validation.

[Timus1712]

These 2 fields can't be set (there is API validation for this). But you are right, it will be breaking change from TF perspective and right now it's better to remove all restrictions and rely on API validation.

Commit was updated.

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 2 deletions(-))
Terraform Beta: Diff ( 1 file changed, 2 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2191
Passed tests 1952
Skipped tests: 239
Failed tests: 0

All tests passed in REPLAYING mode
View the build log