tfv: Fix GetOk field name in hand written iam files

[iyabchen]

b/255831148
terraform validator: GetOk() function should not have {{}} within the parameter.

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

TF Validator: Diff ( 7 files changed, 8 insertions(+), 8 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2210
Passed tests 1971
Skipped tests: 239
Failed tests: 0

All tests passed in REPLAYING mode
View the build log

[melinath]

these changes seem reasonable - it would be great to add tests for these resources to make sure they're actually working otherwise.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 111 insertions(+))
Terraform Beta: Diff ( 1 file changed, 122 insertions(+))
TF Validator: Diff ( 20 files changed, 586 insertions(+), 494 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2210
Passed tests 1971
Skipped tests: 239
Failed tests: 0

All tests passed in REPLAYING mode
View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 112 insertions(+))
Terraform Beta: Diff ( 1 file changed, 124 insertions(+))
TF Validator: Diff ( 10 files changed, 248 insertions(+), 10 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2235
Passed tests 1992
Skipped tests: 241
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccComputeForwardingRule_update

[modular-magician]

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccComputeForwardingRule_update[Debug log]

All tests passed
View the build log or the debug log for each test

[iyabchen]

these changes seem reasonable - it would be great to add tests for these resources to make sure they're actually working otherwise.

Test added, generating a new file to test the FullFetchResource. Created mmv1/third_party/terraform/utils/config_test_utils.go.erb to accept the test server as parameter, so it can mock the iam api fetch.

[melinath]

💯 this is really cool! Love that we have a pattern to directly unit test the fetch behavior - and that it will automatically cover all IAM resources.