Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firebase hosting siteconfig #6790

Conversation

rainshen49
Copy link
Contributor

Add resource google_firebase_hosting_site_config

If this PR is for Terraform, I acknowledge that I have:

Release Note Template for Downstream PRs (will be copied)

`google_firebase_hosting_site_config`

@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @rileykarson, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

  • Ensuring it's backwards compatible, covers common error cases, etc.
  • Summarizing the change into a user-facing changelog note.
  • Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.


@rainshen49
Copy link
Contributor Author

This PR is blocked on #6598, putting in draft state for now

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 260 insertions(+))
Terraform Beta: Diff ( 10 files changed, 1348 insertions(+), 2 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2221
Passed tests 1976
Skipped tests: 239
Failed tests: 6

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccFirebaserulesRelease_BasicRelease|TestAccFirebaseHostingSite_firebasehostingSiteUpdate|TestAccFirebaseHostingSite_firebasehostingSiteFullExample|TestAccFirebaseHostingSite_firebasehostingSiteBasicExample|TestAccFirebaseHostingSiteConfig_firebasehostingSiteconfigFullExample|TestAccFirebaseHostingSiteConfig_firebasehostingSiteconfigBasicExample

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccFirebaseHostingSite_firebasehostingSiteUpdate[Debug log]
TestAccFirebaseHostingSite_firebasehostingSiteFullExample[Debug log]
TestAccFirebaseHostingSite_firebasehostingSiteBasicExample[Debug log]
TestAccFirebaseHostingSiteConfig_firebasehostingSiteconfigFullExample[Debug log]
TestAccFirebaseHostingSiteConfig_firebasehostingSiteconfigBasicExample[Debug log]

All tests passed
View the build log or the debug log for each test

@rainshen49 rainshen49 force-pushed the firebase-hosting-siteconfig branch 2 times, most recently from 1cc58d5 to 309f733 Compare November 7, 2022 19:34
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 130 insertions(+))
Terraform Beta: Diff ( 4 files changed, 545 insertions(+), 2 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@rainshen49 rainshen49 force-pushed the firebase-hosting-siteconfig branch from 309f733 to 6d3c8ac Compare November 7, 2022 19:48
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 130 insertions(+))
Terraform Beta: Diff ( 4 files changed, 545 insertions(+), 2 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2221
Passed tests 1981
Skipped tests: 239
Failed tests: 1

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccFirebaserulesRelease_BasicRelease

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]

All tests passed
View the build log or the debug log for each test

@rainshen49 rainshen49 marked this pull request as ready for review November 7, 2022 20:47
@rainshen49 rainshen49 force-pushed the firebase-hosting-siteconfig branch from 620a119 to f9a98da Compare November 8, 2022 13:56
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 126 insertions(+))
Terraform Beta: Diff ( 4 files changed, 537 insertions(+), 2 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2227
Passed tests 1987
Skipped tests: 240
Failed tests: 0

All tests passed in REPLAYING mode
View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 124 insertions(+))
Terraform Beta: Diff ( 4 files changed, 514 insertions(+), 2 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2237
Passed tests 1995
Skipped tests: 241
Failed tests: 1

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccComputeForwardingRule_update

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccComputeForwardingRule_update[Debug log]

All tests passed
View the build log or the debug log for each test

@rainshen49 rainshen49 force-pushed the firebase-hosting-siteconfig branch from 6a4739c to a7e9a82 Compare November 11, 2022 17:09
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 115 insertions(+))
Terraform Beta: Diff ( 4 files changed, 494 insertions(+), 2 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2245
Passed tests 2004
Skipped tests: 241
Failed tests: 0

All tests passed in REPLAYING mode
View the build log

Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a pass, comments inline!

Any idea why the config methods don't show up in cloud.google.com? I checked both prod & staging and they're not there, although they appear in discovery docs.

description: The default URL for the site in the form of https://{name}.web.app
- !ruby/object:Api::Resource
name: 'SiteConfig'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind adding references linking to https://firebase.devsite.corp.google.com/docs/reference/hosting/rest/v1beta1/projects.sites? Thanks!

getConfig would be preferred, but it doesn't seem to appear in c.g.c docs yet.

create_url: sites/{{site_id}}/config?update_mask=maxVersions,cloudLoggingEnabled # SiteConfig is created as part of Site creation, treat as an update
create_verb: :PATCH
update_verb: :PATCH
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given we support update we'll need a handwritten update test (https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/third_party/terraform/README.md#update-tests). I'm seeing our current generated resource documentation doesn't say to do so. I'll fix that.

test_env_vars:
project_id: :PROJECT_NAME
- !ruby/object:Provider::Terraform::Examples
name: "firebasehosting_siteconfig_full"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Given how small the resource is, let's just consolidate the _full test into the basic test.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since SiteConfig is a singleton child of Site, do you mean to have two Sites in one file? Which one should be the primary_resource_id then?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can just test all the fields in _basic and delete the _full example!

@rainshen49
Copy link
Contributor Author

Good callout on the public docs. I just learned that SiteConfig is semi-internal/deprecated. I'm going to close this PR for now.

@rainshen49 rainshen49 closed this Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants