-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for network_firewall_policy_rule and region_network_firewall_policy_rule #6799
Conversation
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 7 files changed, 2297 insertions(+), 31 deletions(-)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccComputeRegionNetworkFirewallPolicyRule_RegionalHandWritten|TestAccComputeNetworkFirewallPolicyRule_GlobalHandWritten|TestAccComputeForwardingRule_update |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 7 files changed, 2297 insertions(+), 31 deletions(-)) |
Tests analyticsTotal tests: All tests passed in REPLAYING mode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made a pass, comments inline!
tpgtools/overrides/compute/samples/networkfirewallpolicyrule/global.tf.tmpl
Show resolved
Hide resolved
tpgtools/overrides/compute/samples/networkfirewallpolicyrule/global.tf.tmpl
Show resolved
Hide resolved
tpgtools/overrides/compute/samples/networkfirewallpolicyrule/global_update.tf.tmpl
Show resolved
Hide resolved
tpgtools/overrides/compute/samples/networkfirewallpolicyrule/global.tf.tmpl
Show resolved
Hide resolved
setting to draft while changes are committed to DCL |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 7 files changed, 2266 insertions(+)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccFirebaserulesRelease_BasicRelease |
I tested in PR #6819 downstream changes from DCL 1.26.4 and there doesn't seem to be any. So I figured I'd add it in here. Let me know if I should keep the upgrade to 1.26.4 in a separate PR. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 9 files changed, 2293 insertions(+), 5 deletions(-)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccComputeRegionNetworkFirewallPolicyRule_RegionalHandWritten|TestAccComputeNetworkFirewallPolicyRule_GlobalHandWritten|TestAccComputeForwardingRule_update|TestAccComputeGlobalForwardingRule_labels |
Tests passed during RECORDING mode: All tests passed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM- there are no changes from DCL out of the ones made for change, so doing the upgrade in this PR is 👍
…all_policy_rule (GoogleCloudPlatform#6799) Co-authored-by: Ghaleb Al-habian <galhabian@google.com>
…all_policy_rule (GoogleCloudPlatform#6799) Co-authored-by: Ghaleb Al-habian <galhabian@google.com>
…all_policy_rule (GoogleCloudPlatform#6799) Co-authored-by: Ghaleb Al-habian <galhabian@google.com>
This PR adds support for the network_firewall_policy_rule resource, and its regional counterpart (region_network_firewall_policy_rule). These resources have been integrated into the DCL already and requires DCL v1.26 .
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)