Add support for Beyondcorp AppConnector resource

[palramanathan]

Add terraform support for BeyondCorp AppConnector resource (https://cloud.google.com/beyondcorp/docs/reference/rest/v1/projects.locations.appConnectors) and AppGateway resource(https://cloud.google.com/beyondcorp/docs/reference/rest/v1/projects.locations.appGateways). Adding API and Terraforms yamls and couple of examples.

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_beyondcorp_app_connector`

`google_beyondcorp_app_gateway`

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @slevenick, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

---

Your assigned reviewer will help review your code by:

• Ensuring it's backwards compatible, covers common error cases, etc.
• Summarizing the change into a user-facing changelog note.
• Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

---

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 10 files changed, 1728 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 10 files changed, 1728 insertions(+), 3 deletions(-))
TF Validator: Diff ( 7 files changed, 494 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 8 files changed, 234 insertions(+))

[modular-magician]

Tests analytics

Total tests: 2237
Passed tests 1991
Skipped tests: 241
Failed tests: 5

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccBeyondcorpAppConnector_beyondcorpAppConnectorBasicExample|TestAccBeyondcorpAppConnector_beyondcorpAppConnectorFullExample|TestAccBeyondcorpAppConnectorIamPolicyGenerated|TestAccBeyondcorpAppConnectorIamMemberGenerated|TestAccBeyondcorpAppConnectorIamBindingGenerated

[modular-magician]

Tests failed during RECORDING mode:
TestAccBeyondcorpAppConnector_beyondcorpAppConnectorBasicExample[Error message] [Debug log]
TestAccBeyondcorpAppConnector_beyondcorpAppConnectorFullExample[Error message] [Debug log]
TestAccBeyondcorpAppConnectorIamPolicyGenerated[Error message] [Debug log]
TestAccBeyondcorpAppConnectorIamMemberGenerated[Error message] [Debug log]
TestAccBeyondcorpAppConnectorIamBindingGenerated[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 7 files changed, 1093 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 7 files changed, 1093 insertions(+), 2 deletions(-))
TF Validator: Diff ( 4 files changed, 145 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 8 files changed, 234 insertions(+))

[modular-magician]

Tests analytics

Total tests: 2234
Passed tests 1989
Skipped tests: 241
Failed tests: 4

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccComputeForwardingRule_update|TestAccBeyondcorpAppConnector_beyondcorpAppConnectorFullExample|TestAccBeyondcorpAppConnector_beyondcorpAppConnectorBasicExample

[modular-magician]

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccComputeForwardingRule_update[Debug log]
TestAccBeyondcorpAppConnector_beyondcorpAppConnectorFullExample[Debug log]
TestAccBeyondcorpAppConnector_beyondcorpAppConnectorBasicExample[Debug log]

All tests passed
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 11 files changed, 2078 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 11 files changed, 2078 insertions(+), 2 deletions(-))
TF Validator: Diff ( 5 files changed, 255 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 16 files changed, 453 insertions(+))

[modular-magician]

Tests analytics

Total tests: 2239
Passed tests 1996
Skipped tests: 241
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccBeyondcorpAppGateway_beyondcorpAppGatewayFullExample|TestAccBeyondcorpAppGateway_beyondcorpAppGatewayBasicExample

[modular-magician]

Tests passed during RECORDING mode:
TestAccBeyondcorpAppGateway_beyondcorpAppGatewayFullExample[Debug log]
TestAccBeyondcorpAppGateway_beyondcorpAppGatewayBasicExample[Debug log]

All tests passed
View the build log or the debug log for each test

[slevenick]

Overall looks reasonable, just some notes on cleaning up the api.yaml file

Additionally, you've included info on using PATCH and an update mask to update the resources, can you add a handwritten update test to make sure this works correctly?

[slevenick]

delete & update URL should be redundant, they can generally be derived from self_link & base_url as long as they are standard (which these are)

[palramanathan]

Removed in both resources.

[slevenick]

Are these output only fields useful? We try to omit them when we don't expect any user to use them, like create & update time

[palramanathan]

Ok, I was trying to mimic what the API returns, but if terraform standard is to omit fields users won't use, I will remove a few fields from the response (uid, create_time and update_time).

[slevenick]

You can delete these

[palramanathan]

Done.

[slevenick]

Unneeded, GA is the "highest" version

[palramanathan]

Removed.

[palramanathan]

Thanks for the review! I will address the comments and update the PR.

[palramanathan]

Removed in both resources.

[palramanathan]

Done.

[palramanathan]

Ok, I was trying to mimic what the API returns, but if terraform standard is to omit fields users won't use, I will remove a few fields from the response (uid, create_time and update_time).

[palramanathan]

Removed.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 12 files changed, 1926 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 12 files changed, 1926 insertions(+), 2 deletions(-))
TF Validator: Diff ( 5 files changed, 235 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 16 files changed, 453 insertions(+))

[modular-magician]

Tests analytics

Total tests: 2240
Passed tests 1994
Skipped tests: 241
Failed tests: 5

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccBeyondcorpAppGateway_beyondcorpAppGatewayFullExample|TestAccBeyondcorpAppGateway_beyondcorpAppGatewayBasicExample|TestAccBeyondcorpAppConnector_beyondcorpAppConnectorUpdateExample|TestAccBeyondcorpAppConnector_beyondcorpAppConnectorBasicExample|TestAccBeyondcorpAppConnector_beyondcorpAppConnectorFullExample

[modular-magician]

Tests passed during RECORDING mode:
TestAccBeyondcorpAppGateway_beyondcorpAppGatewayFullExample[Debug log]
TestAccBeyondcorpAppGateway_beyondcorpAppGatewayBasicExample[Debug log]
TestAccBeyondcorpAppConnector_beyondcorpAppConnectorUpdateExample[Debug log]
TestAccBeyondcorpAppConnector_beyondcorpAppConnectorBasicExample[Debug log]
TestAccBeyondcorpAppConnector_beyondcorpAppConnectorFullExample[Debug log]

All tests passed
View the build log or the debug log for each test

[slevenick]

Thanks looks good!