-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Beyondcorp AppConnector resource #6801
Add support for Beyondcorp AppConnector resource #6801
Conversation
Hello! I am a robot who works on Magic Modules PRs. I've detected that you're a community contributor. @slevenick, a repository maintainer, has been assigned to assist you and help review your changes. ❓ First time contributing? Click here for more detailsYour assigned reviewer will help review your code by:
You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails. If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox. |
dcd59a6
to
20712f0
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 10 files changed, 1728 insertions(+), 3 deletions(-)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccBeyondcorpAppConnector_beyondcorpAppConnectorBasicExample|TestAccBeyondcorpAppConnector_beyondcorpAppConnectorFullExample|TestAccBeyondcorpAppConnectorIamPolicyGenerated|TestAccBeyondcorpAppConnectorIamMemberGenerated|TestAccBeyondcorpAppConnectorIamBindingGenerated |
Tests failed during RECORDING mode: Please fix these to complete your PR |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 7 files changed, 1093 insertions(+), 2 deletions(-)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccFirebaserulesRelease_BasicRelease|TestAccComputeForwardingRule_update|TestAccBeyondcorpAppConnector_beyondcorpAppConnectorFullExample|TestAccBeyondcorpAppConnector_beyondcorpAppConnectorBasicExample |
Tests passed during RECORDING mode: All tests passed |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 11 files changed, 2078 insertions(+), 2 deletions(-)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccBeyondcorpAppGateway_beyondcorpAppGatewayFullExample|TestAccBeyondcorpAppGateway_beyondcorpAppGatewayBasicExample |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks reasonable, just some notes on cleaning up the api.yaml file
Additionally, you've included info on using PATCH and an update mask to update the resources, can you add a handwritten update test to make sure this works correctly?
mmv1/products/beyondcorp/api.yaml
Outdated
base_url: projects/{{project}}/locations/{{region}}/appConnectors | ||
self_link: projects/{{project}}/locations/{{region}}/appConnectors/{{name}} | ||
create_url: projects/{{project}}/locations/{{region}}/appConnectors?app_connector_id={{name}} | ||
delete_url: projects/{{project}}/locations/{{region}}/appConnectors/{{name}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete & update URL should be redundant, they can generally be derived from self_link & base_url as long as they are standard (which these are)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed in both resources.
mmv1/products/beyondcorp/api.yaml
Outdated
description: | | ||
Email address of the service account. | ||
- !ruby/object:Api::Type::Time | ||
name: 'createTime' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these output only fields useful? We try to omit them when we don't expect any user to use them, like create & update time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I was trying to mimic what the API returns, but if terraform standard is to omit fields users won't use, I will remove a few fields from the response (uid, create_time and update_time).
mmv1/products/beyondcorp/api.yaml
Outdated
update_url: projects/{{project}}/locations/{{region}}/appConnectors/{{name}} | ||
update_verb: :PATCH | ||
update_mask: true | ||
# iam_policy: !ruby/object:Api::Resource::IamPolicy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can delete these
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
mmv1/products/beyondcorp/api.yaml
Outdated
A BeyondCorp AppGateway resource represents a BeyondCorp protected AppGateway to a remote application. It creates | ||
all the necessary GCP components needed for creating a BeyondCorp protected AppGateway. Multiple connectors can be | ||
authorised for a single AppGateway. | ||
min_version: ga |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unneeded, GA is the "highest" version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review! I will address the comments and update the PR.
mmv1/products/beyondcorp/api.yaml
Outdated
base_url: projects/{{project}}/locations/{{region}}/appConnectors | ||
self_link: projects/{{project}}/locations/{{region}}/appConnectors/{{name}} | ||
create_url: projects/{{project}}/locations/{{region}}/appConnectors?app_connector_id={{name}} | ||
delete_url: projects/{{project}}/locations/{{region}}/appConnectors/{{name}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed in both resources.
mmv1/products/beyondcorp/api.yaml
Outdated
update_url: projects/{{project}}/locations/{{region}}/appConnectors/{{name}} | ||
update_verb: :PATCH | ||
update_mask: true | ||
# iam_policy: !ruby/object:Api::Resource::IamPolicy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
mmv1/products/beyondcorp/api.yaml
Outdated
description: | | ||
Email address of the service account. | ||
- !ruby/object:Api::Type::Time | ||
name: 'createTime' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I was trying to mimic what the API returns, but if terraform standard is to omit fields users won't use, I will remove a few fields from the response (uid, create_time and update_time).
mmv1/products/beyondcorp/api.yaml
Outdated
A BeyondCorp AppGateway resource represents a BeyondCorp protected AppGateway to a remote application. It creates | ||
all the necessary GCP components needed for creating a BeyondCorp protected AppGateway. Multiple connectors can be | ||
authorised for a single AppGateway. | ||
min_version: ga |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed.
2. Setting appGateway resoruce to be non updatable. 3. Added a test to verify update/patch ot app connector
eb7a7e4
to
c76750c
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 12 files changed, 1926 insertions(+), 2 deletions(-)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccBeyondcorpAppGateway_beyondcorpAppGatewayFullExample|TestAccBeyondcorpAppGateway_beyondcorpAppGatewayBasicExample|TestAccBeyondcorpAppConnector_beyondcorpAppConnectorUpdateExample|TestAccBeyondcorpAppConnector_beyondcorpAppConnectorBasicExample|TestAccBeyondcorpAppConnector_beyondcorpAppConnectorFullExample |
Tests passed during RECORDING mode: All tests passed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks looks good!
…#6801) * Add support for Beyondcorp AppConnector resource * Disabling IAM policy until policy bindings are fixed * Adding support for Beyondcorp AppGateway resource * 1. Addressing PR comments 2. Setting appGateway resoruce to be non updatable. 3. Added a test to verify update/patch ot app connector
…#6801) * Add support for Beyondcorp AppConnector resource * Disabling IAM policy until policy bindings are fixed * Adding support for Beyondcorp AppGateway resource * 1. Addressing PR comments 2. Setting appGateway resoruce to be non updatable. 3. Added a test to verify update/patch ot app connector
…#6801) * Add support for Beyondcorp AppConnector resource * Disabling IAM policy until policy bindings are fixed * Adding support for Beyondcorp AppGateway resource * 1. Addressing PR comments 2. Setting appGateway resoruce to be non updatable. 3. Added a test to verify update/patch ot app connector
Add terraform support for BeyondCorp AppConnector resource (https://cloud.google.com/beyondcorp/docs/reference/rest/v1/projects.locations.appConnectors) and AppGateway resource(https://cloud.google.com/beyondcorp/docs/reference/rest/v1/projects.locations.appGateways). Adding API and Terraforms yamls and couple of examples.
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)