-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bigtable: Add support for abandoning GC policy #6817
Bigtable: Add support for abandoning GC policy #6817
Conversation
Hello! I am a robot who works on Magic Modules PRs. I've detected that you're a community contributor. @megan07, a repository maintainer, has been assigned to assist you and help review your changes. ❓ First time contributing? Click here for more detailsYour assigned reviewer will help review your code by:
You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails. If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 160 insertions(+)) |
Tests analyticsTotal tests: All tests passed in REPLAYING mode |
@kimihrr, could you also take a look when you get a chance. It is optional for you. Thanks! |
Ping? |
Test skipped in VCR. Kicked off an independent run: https://ci-oss.hashicorp.engineering/buildConfiguration/GoogleCloudBeta_ProviderGoogleCloudBetaMmUpstream/353692 Tests passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall! Got a question regarding this feature: I assume after set "deletion_policy = ABANDON", deleting the instance will still delete the policy and leave no dangling resource?
Yes, deleting an instance or the parent table will cascade delete their child GC Policies. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Deleting a GC policy is not allowed in a replicated instance (an instance has more than one cluster).
Users who are running into this problem have to add an extra step to un-replicate the instance first before destroying all the resources.
With abandoning GC policy support, users can mark the GCP policy to be
ABANDON
. That way, the GC policy won't be deleted first, but will be deleted when the parent resource (table) is deleted.fixes b/257991134
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)