Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bigtable: Add support for abandoning GC policy #6817

Merged

Conversation

kevinsi4508
Copy link
Contributor

@kevinsi4508 kevinsi4508 commented Nov 11, 2022

Deleting a GC policy is not allowed in a replicated instance (an instance has more than one cluster).

Users who are running into this problem have to add an extra step to un-replicate the instance first before destroying all the resources.

With abandoning GC policy support, users can mark the GCP policy to be ABANDON. That way, the GC policy won't be deleted first, but will be deleted when the parent resource (table) is deleted.

fixes b/257991134

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

bigtable: added support for abandoning GC policy

@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @megan07, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

  • Ensuring it's backwards compatible, covers common error cases, etc.
  • Summarizing the change into a user-facing changelog note.
  • Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 160 insertions(+))
Terraform Beta: Diff ( 3 files changed, 160 insertions(+))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2244
Passed tests 2002
Skipped tests: 242
Failed tests: 0

All tests passed in REPLAYING mode
View the build log

@kevinsi4508
Copy link
Contributor Author

@kimihrr, could you also take a look when you get a chance. It is optional for you. Thanks!

@kevinsi4508
Copy link
Contributor Author

Ping?

@melinath melinath requested review from a team and shuyama1 and removed request for megan07 and a team November 16, 2022 16:18
@shuyama1
Copy link
Member

shuyama1 commented Nov 17, 2022

Test skipped in VCR. Kicked off an independent run: https://ci-oss.hashicorp.engineering/buildConfiguration/GoogleCloudBeta_ProviderGoogleCloudBetaMmUpstream/353692

Tests passed!

Copy link
Member

@shuyama1 shuyama1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall! Got a question regarding this feature: I assume after set "deletion_policy = ABANDON", deleting the instance will still delete the policy and leave no dangling resource?

@kevinsi4508
Copy link
Contributor Author

LGTM overall! Got a question regarding this feature: I assume after set "deletion_policy = ABANDON", deleting the instance will still delete the policy and leave no dangling resource?

Yes, deleting an instance or the parent table will cascade delete their child GC Policies.

Copy link
Member

@shuyama1 shuyama1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@shuyama1 shuyama1 merged commit b27f09d into GoogleCloudPlatform:main Nov 17, 2022
googlerjk pushed a commit to googlerjk/magic-modules that referenced this pull request Nov 22, 2022
googlerjk pushed a commit to googlerjk/magic-modules that referenced this pull request Nov 25, 2022
kimihrr pushed a commit to kimihrr/kimiah-magic-modules that referenced this pull request Dec 6, 2022
hao-nan-li pushed a commit to hao-nan-li/magic-modules that referenced this pull request Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants