-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Backup for GKE BackupPlan Resource (beta) #6845
Conversation
Hello! I am a robot who works on Magic Modules PRs. I've detected that you're a community contributor. @shuyama1, a repository maintainer, has been assigned to assist you and help review your changes. ❓ First time contributing? Click here for more detailsYour assigned reviewer will help review your code by:
You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails. If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 1 file changed, 404 insertions(+)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccGKEBackupBackupPlan_gkebackupBackupplanFullExample|TestAccGKEBackupBackupPlan_gkebackupBackupplanCmekExample|TestAccGKEBackupBackupPlan_gkebackupBackupplanAutopilotExample|TestAccGKEBackupBackupPlan_gkebackupBackupplanBasicExample |
Tests failed during RECORDING mode: Please fix these to complete your PR |
Enabled the API and rerun the tests |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 1 file changed, 404 insertions(+)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccGKEBackupBackupPlan_gkebackupBackupplanFullExample|TestAccGKEBackupBackupPlan_gkebackupBackupplanCmekExample|TestAccGKEBackupBackupPlan_gkebackupBackupplanAutopilotExample|TestAccGKEBackupBackupPlan_gkebackupBackupplanBasicExample |
Tests passed during RECORDING mode: All tests passed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume some of the fields in this resource are updatable? Did you test the update functionality locally? Would you mind adding update tests for those fields? Currently we only support update tests in handwritten and those test files are located at https://github.com/GoogleCloudPlatform/magic-modules/tree/main/mmv1/third_party/terraform/tests. Please let me know if you have any question!
Added in the handwritten update tests. I had previously manually tested update functionality thoroughly |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 519 insertions(+)) |
Tests analyticsTotal tests: Errors occurred during REPLAYING mode. Please fix them to complete your PR |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 518 insertions(+)) |
Tests analyticsTotal tests: Errors occurred during REPLAYING mode. Please fix them to complete your PR |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 405 insertions(+)) |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 409 insertions(+)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccGKEBackupBackupPlan_update|TestAccLoggingBucketConfigProject_cmekSettings |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccCloudFunctions2Function_fullUpdate|TestAccCloudfunctions2function_cloudfunctions2BasicAuditlogsExample|TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample|TestAccLoggingBucketConfigProject_cmekSettings |
Tests passed during RECORDING mode: All tests passed |
mmv1/third_party/terraform/tests/resource_gke_backup_backup_plan_test.go.erb
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/tests/resource_gke_backup_backup_plan_test.go.erb
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/tests/resource_gke_backup_backup_plan_test.go.erb
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/tests/resource_gke_backup_backup_plan_test.go.erb
Outdated
Show resolved
Hide resolved
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 408 insertions(+)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccLoggingBucketConfigProject_cmekSettings|TestAccGKEBackupBackupPlan_update|TestAccGKEBackupBackupPlan_gkebackupBackupplanFullExample|TestAccGKEBackupBackupPlan_gkebackupBackupplanAutopilotExample|TestAccGKEBackupBackupPlan_gkebackupBackupplanCmekExample|TestAccGKEBackupBackupPlan_gkebackupBackupplanBasicExample|TestAccFirebaserulesRelease_BasicRelease |
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 405 insertions(+)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccGKEBackupBackupPlan_gkebackupBackupplanAutopilotExample|TestAccGKEBackupBackupPlan_update|TestAccGKEBackupBackupPlan_gkebackupBackupplanCmekExample|TestAccGKEBackupBackupPlan_gkebackupBackupplanFullExample|TestAccGKEBackupBackupPlan_gkebackupBackupplanBasicExample|TestAccFirebaserulesRelease_BasicRelease|TestAccLoggingBucketConfigProject_cmekSettings |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 405 insertions(+)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccGKEBackupBackupPlan_update|TestAccGKEBackupBackupPlan_gkebackupBackupplanFullExample|TestAccGKEBackupBackupPlan_gkebackupBackupplanCmekExample|TestAccGKEBackupBackupPlan_gkebackupBackupplanAutopilotExample|TestAccGKEBackupBackupPlan_gkebackupBackupplanBasicExample|TestAccLoggingBucketConfigProject_cmekSettings |
Tests passed during RECORDING mode: All tests passed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
Fixes hashicorp/terraform-provider-google#12634
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)