Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Backup for GKE BackupPlan Resource (beta) #6845

Merged
merged 14 commits into from
Dec 5, 2022
Merged

Add Backup for GKE BackupPlan Resource (beta) #6845

merged 14 commits into from
Dec 5, 2022

Conversation

neha-vellanki12
Copy link
Contributor

@neha-vellanki12 neha-vellanki12 commented Nov 18, 2022

Fixes hashicorp/terraform-provider-google#12634

If this PR is for Terraform, I acknowledge that I have:

  • [X ] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • [X ] Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • [ X] Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • [ X] Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • [X ] Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_gke_backup_backup_plan` (beta)

@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @shuyama1, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

  • Ensuring it's backwards compatible, covers common error cases, etc.
  • Summarizing the change into a user-facing changelog note.
  • Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 404 insertions(+))
Terraform Beta: Diff ( 7 files changed, 1977 insertions(+), 2 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 128 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2276
Passed tests 2028
Skipped tests: 244
Failed tests: 4

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccGKEBackupBackupPlan_gkebackupBackupplanFullExample|TestAccGKEBackupBackupPlan_gkebackupBackupplanCmekExample|TestAccGKEBackupBackupPlan_gkebackupBackupplanAutopilotExample|TestAccGKEBackupBackupPlan_gkebackupBackupplanBasicExample

@modular-magician
Copy link
Collaborator

Tests failed during RECORDING mode:
TestAccGKEBackupBackupPlan_gkebackupBackupplanFullExample[Error message] [Debug log]
TestAccGKEBackupBackupPlan_gkebackupBackupplanCmekExample[Error message] [Debug log]
TestAccGKEBackupBackupPlan_gkebackupBackupplanAutopilotExample[Error message] [Debug log]
TestAccGKEBackupBackupPlan_gkebackupBackupplanBasicExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

@shuyama1
Copy link
Member

Enabled the API and rerun the tests
/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 404 insertions(+))
Terraform Beta: Diff ( 7 files changed, 1977 insertions(+), 2 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 128 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2276
Passed tests 2028
Skipped tests: 244
Failed tests: 4

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccGKEBackupBackupPlan_gkebackupBackupplanFullExample|TestAccGKEBackupBackupPlan_gkebackupBackupplanCmekExample|TestAccGKEBackupBackupPlan_gkebackupBackupplanAutopilotExample|TestAccGKEBackupBackupPlan_gkebackupBackupplanBasicExample

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccGKEBackupBackupPlan_gkebackupBackupplanFullExample[Debug log]
TestAccGKEBackupBackupPlan_gkebackupBackupplanCmekExample[Debug log]
TestAccGKEBackupBackupPlan_gkebackupBackupplanAutopilotExample[Debug log]
TestAccGKEBackupBackupPlan_gkebackupBackupplanBasicExample[Debug log]

All tests passed
View the build log or the debug log for each test

Copy link
Member

@shuyama1 shuyama1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume some of the fields in this resource are updatable? Did you test the update functionality locally? Would you mind adding update tests for those fields? Currently we only support update tests in handwritten and those test files are located at https://github.com/GoogleCloudPlatform/magic-modules/tree/main/mmv1/third_party/terraform/tests. Please let me know if you have any question!

@neha-vellanki12
Copy link
Contributor Author

Added in the handwritten update tests. I had previously manually tested update functionality thoroughly

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 519 insertions(+))
Terraform Beta: Diff ( 8 files changed, 2092 insertions(+), 2 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 128 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests 0
Skipped tests: 0
Failed tests: 0

Errors occurred during REPLAYING mode. Please fix them to complete your PR
View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 518 insertions(+))
Terraform Beta: Diff ( 8 files changed, 2091 insertions(+), 2 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 128 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests 0
Skipped tests: 0
Failed tests: 0

Errors occurred during REPLAYING mode. Please fix them to complete your PR
View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 405 insertions(+))
Terraform Beta: Diff ( 8 files changed, 2093 insertions(+), 2 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 128 insertions(+))

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 409 insertions(+))
Terraform Beta: Diff ( 8 files changed, 2103 insertions(+), 2 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 129 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2286
Passed tests 2040
Skipped tests: 244
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccGKEBackupBackupPlan_update|TestAccLoggingBucketConfigProject_cmekSettings

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccGKEBackupBackupPlan_update[Debug log]
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]

All tests passed
View the build log or the debug log for each test

mmv1/products/gkebackup/api.yaml Show resolved Hide resolved
mmv1/products/gkebackup/api.yaml Outdated Show resolved Hide resolved
mmv1/products/gkebackup/api.yaml Outdated Show resolved Hide resolved
mmv1/products/gkebackup/api.yaml Show resolved Hide resolved
mmv1/products/gkebackup/api.yaml Show resolved Hide resolved
mmv1/products/gkebackup/api.yaml Outdated Show resolved Hide resolved
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2307
Passed tests 2059
Skipped tests: 244
Failed tests: 4

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccCloudFunctions2Function_fullUpdate|TestAccCloudfunctions2function_cloudfunctions2BasicAuditlogsExample|TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample|TestAccLoggingBucketConfigProject_cmekSettings

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccCloudFunctions2Function_fullUpdate[Debug log]
TestAccCloudfunctions2function_cloudfunctions2BasicAuditlogsExample[Debug log]
TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample[Debug log]
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]

All tests passed
View the build log or the debug log for each test

mmv1/products/gkebackup/api.yaml Outdated Show resolved Hide resolved
mmv1/products/gkebackup/api.yaml Outdated Show resolved Hide resolved
mmv1/products/gkebackup/api.yaml Outdated Show resolved Hide resolved
mmv1/products/gkebackup/api.yaml Show resolved Hide resolved
mmv1/products/gkebackup/api.yaml Outdated Show resolved Hide resolved
mmv1/products/gkebackup/terraform.yaml Outdated Show resolved Hide resolved
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 408 insertions(+))
Terraform Beta: Diff ( 8 files changed, 2101 insertions(+), 2 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 129 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2323
Passed tests 2072
Skipped tests: 244
Failed tests: 7

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccLoggingBucketConfigProject_cmekSettings|TestAccGKEBackupBackupPlan_update|TestAccGKEBackupBackupPlan_gkebackupBackupplanFullExample|TestAccGKEBackupBackupPlan_gkebackupBackupplanAutopilotExample|TestAccGKEBackupBackupPlan_gkebackupBackupplanCmekExample|TestAccGKEBackupBackupPlan_gkebackupBackupplanBasicExample|TestAccFirebaserulesRelease_BasicRelease

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]
TestAccGKEBackupBackupPlan_update[Debug log]
TestAccGKEBackupBackupPlan_gkebackupBackupplanFullExample[Debug log]
TestAccGKEBackupBackupPlan_gkebackupBackupplanCmekExample[Debug log]
TestAccGKEBackupBackupPlan_gkebackupBackupplanBasicExample[Debug log]
TestAccFirebaserulesRelease_BasicRelease[Debug log]

Tests failed during RECORDING mode:
TestAccGKEBackupBackupPlan_gkebackupBackupplanAutopilotExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 405 insertions(+))
Terraform Beta: Diff ( 8 files changed, 2086 insertions(+), 2 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 129 insertions(+))

@shuyama1 shuyama1 removed the request for review from rileykarson December 5, 2022 05:24
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2323
Passed tests 2072
Skipped tests: 244
Failed tests: 7

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccGKEBackupBackupPlan_gkebackupBackupplanAutopilotExample|TestAccGKEBackupBackupPlan_update|TestAccGKEBackupBackupPlan_gkebackupBackupplanCmekExample|TestAccGKEBackupBackupPlan_gkebackupBackupplanFullExample|TestAccGKEBackupBackupPlan_gkebackupBackupplanBasicExample|TestAccFirebaserulesRelease_BasicRelease|TestAccLoggingBucketConfigProject_cmekSettings

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 405 insertions(+))
Terraform Beta: Diff ( 8 files changed, 2086 insertions(+), 2 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 129 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2323
Passed tests 2073
Skipped tests: 244
Failed tests: 6

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccGKEBackupBackupPlan_update|TestAccGKEBackupBackupPlan_gkebackupBackupplanFullExample|TestAccGKEBackupBackupPlan_gkebackupBackupplanCmekExample|TestAccGKEBackupBackupPlan_gkebackupBackupplanAutopilotExample|TestAccGKEBackupBackupPlan_gkebackupBackupplanBasicExample|TestAccLoggingBucketConfigProject_cmekSettings

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccGKEBackupBackupPlan_update[Debug log]
TestAccGKEBackupBackupPlan_gkebackupBackupplanFullExample[Debug log]
TestAccGKEBackupBackupPlan_gkebackupBackupplanCmekExample[Debug log]
TestAccGKEBackupBackupPlan_gkebackupBackupplanAutopilotExample[Debug log]
TestAccGKEBackupBackupPlan_gkebackupBackupplanBasicExample[Debug log]
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]

All tests passed
View the build log or the debug log for each test

Copy link
Member

@shuyama1 shuyama1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support "Backup for GKE"
4 participants