-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Datastream check private connection state after create and update #6862
Datastream check private connection state after create and update #6862
Conversation
Oops! It looks like no changelog entry is attached to this PR. Please include a release note block in the PR body, as described in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md:
|
Hello! I am a robot who works on Magic Modules PRs. I've detected that you're a community contributor. @melinath, a repository maintainer, has been assigned to assist you and help review your changes. ❓ First time contributing? Click here for more detailsYour assigned reviewer will help review your code by:
You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails. If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox. |
Oops! It looks like no changelog entry is attached to this PR. Please include a release note block in the PR body, as described in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md:
|
Oops! It looks like no changelog entry is attached to this PR. Please include a release note block in the PR body, as described in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md:
|
TESTED= |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 113 insertions(+)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccFirebaserulesRelease_BasicRelease|TestAccDatastreamPrivateConnection_datastreamPrivateConnectionFullExample|TestAccDatastreamConnectionProfile_datastreamConnectionProfileBigqueryPrivateConnectionExample|TestAccLoggingBucketConfigProject_cmekSettings |
Tests passed during RECORDING mode: All tests passed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it might be possible to test this using a TestCheckFunc to make sure that after creation, the state
field is set to CREATED
. Right now I assume (?) that check would fail because the connection would still be CREATING
Oops! It looks like no changelog entry is attached to this PR. Please include a release note block in the PR body, as described in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md:
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 117 insertions(+)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccLoggingBucketConfigProject_cmekSettings|TestAccDatastreamPrivateConnection_datastreamPrivateConnectionFullExample|TestAccFirebaserulesRelease_BasicRelease|TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample|TestAccCloudfunctions2function_cloudfunctions2BasicAuditlogsExample|TestAccCloudFunctions2Function_fullUpdate |
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
VCR failures are unrelated |
…ogleCloudPlatform#6862) * Add desired state field to make sure PC is created in CREATED - b/260057913 * Revert virtual field * Add state field check to make sure PC is created in CREATED - b/260057913 * Add error details and message in failure cases. * Fix message formatting * Added a post import impl
…ogleCloudPlatform#6862) * Add desired state field to make sure PC is created in CREATED - b/260057913 * Revert virtual field * Add state field check to make sure PC is created in CREATED - b/260057913 * Add error details and message in failure cases. * Fix message formatting * Added a post import impl
…ogleCloudPlatform#6862) * Add desired state field to make sure PC is created in CREATED - b/260057913 * Revert virtual field * Add state field check to make sure PC is created in CREATED - b/260057913 * Add error details and message in failure cases. * Fix message formatting * Added a post import impl
Datastream Private Connection resources create operation can finish successfully when the actual resource fails.
To solve that in TF, we will add a custom post create code (this only happens in create) that will verify the resource state after creation.