Add validation for IAM members.

[trodge]

fixes b/241955990

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

iam: Added plan-time validation for IAM members

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @shuyama1, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

---

Your assigned reviewer will help review your code by:

• Ensuring it's backwards compatible, covers common error cases, etc.
• Summarizing the change into a user-facing changelog note.
• Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

---

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 30 insertions(+), 7 deletions(-))
Terraform Beta: Diff ( 3 files changed, 30 insertions(+), 7 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2302
Passed tests 2056
Skipped tests: 244
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccLoggingBucketConfigProject_cmekSettings|TestAccComputeForwardingRule_update

[modular-magician]

Tests passed during RECORDING mode:
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]
TestAccComputeForwardingRule_update[Debug log]

All tests passed
View the build log or the debug log for each test

[shuyama1]

@trodge Would you mind modifying the release note following Release Notes Guide?
Is there a github issue or internal ticket that this PR resolves? If so, please link it in the PR description.

[shuyama1]

LGTM! Thanks! Do you think if it's possible that we add some tests on it?

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 7 files changed, 141 insertions(+), 17 deletions(-))
Terraform Beta: Diff ( 7 files changed, 141 insertions(+), 17 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2332
Passed tests 2081
Skipped tests: 244
Failed tests: 7

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccProjectIamMember_invalidMembers|TestAccProjectIamBinding_invalidMembers|TestAccFirebaserulesRelease_BasicRelease|TestAccProjectIamPolicy_invalidMembers|TestAccDataSourceGoogleServiceAccountIdToken_basic|TestAccLoggingBucketConfigProject_cmekSettings|TestAccStorageBucketIamPolicy

[modular-magician]

Tests passed during RECORDING mode:
TestAccProjectIamMember_invalidMembers[Debug log]
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccDataSourceGoogleServiceAccountIdToken_basic[Debug log]
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]
TestAccStorageBucketIamPolicy[Debug log]

Tests failed during RECORDING mode:
TestAccProjectIamBinding_invalidMembers[Error message] [Debug log]
TestAccProjectIamPolicy_invalidMembers[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 7 files changed, 141 insertions(+), 17 deletions(-))
Terraform Beta: Diff ( 7 files changed, 141 insertions(+), 17 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2332
Passed tests 2085
Skipped tests: 244
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccProjectIamBinding_invalidMembers|TestAccLoggingBucketConfigProject_cmekSettings|TestAccProjectIamPolicy_invalidMembers

[modular-magician]

Tests passed during RECORDING mode:
TestAccProjectIamBinding_invalidMembers[Debug log]
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]
TestAccProjectIamPolicy_invalidMembers[Debug log]

All tests passed
View the build log or the debug log for each test

[drebes]

Does this validate correctly the new principal formats defined by workload identity federation and workforce identity federation? Couldn't find any of them on the tests.

[trodge]

Does this validate correctly the new principal formats defined by workload identity federation and workforce identity federation? Couldn't find any of them on the tests.

It should handle these fine as long as they match the regex .+:.+.

[shuyama1]

LGTM! I was thinking unit tests, something like https://github.com/GoogleCloudPlatform/magic-modules/blob/07fb63681124e8690bfaeb358a46c97d77adeb8d/mmv1/third_party/terraform/utils/validation_test.go
But acceptance tests totally work! Thanks for adding them!