[Terraform] [WIP] autogenerate resource_dns_managed_zone

[drebes]

This is my first attempt on generating resource_dns_managed_zone using magic-modules.

As the module is generating only against the v1 version of the API for now, which does not support update/patch on the resource, the autogenerated tests are not testing update. I also didn't include support for RecordSets yet, as that will be more complex and I wanted to start simple.

I'm still trying to figure out how testing works, for example, how can my autogenerated tests be against a zone like "tf-acctest-%s.hashicorptest.com.", but not have that domain showing up in the generated docs.

---

[all]

Add labels and updates to DNS managed zone

[terraform]

Start autogenerating resource_dns_managed_zone

[terraform-beta]

[ansible]

[inspec]

[danawillow]

Awesome, thanks so much for doing this!

We probably want to keep resource_dns_managed_zone_test, or at the very least remove the basic test and leave the update test, or something like that- since the autogenerated tests don't test update yet. The v1 API actually does have support for update; it's just not documented. I filed a bug internally about that.

Also, adding fields in api.yaml will also update the non-terraform providers. Can you make sure they have descriptions in the PR description so that their generated PRs will have names? Once that's done I'll go ahead and trigger the magician (in the future it should trigger automatically on your PRs, but it doesn't for the first one from an individual).

[drebes]

I've pushed updates with the requested changes, can you take a second look?

[danawillow]

Looks good! I'll go ahead and modify the PR description so you can see what I was talking about, and then I'll start the magician run.

[danawillow]

Ah, since you added a new field you also need to add version_added into dns/ansible.yaml. Here's an example of how to do it for an individual field: https://github.com/GoogleCloudPlatform/magic-modules/blob/master/products/compute/ansible.yaml#L114. 2.8 is the value you want.

[drebes]

Done, removed the references to PATCH but updates now are done with PUT instead.

[drebes]

I see that the generated code is now updating the resource with PUT, wouldn't it be better to do it with PATCH if the API supports it? Also, for some reason the ForceNew for name and dnsName are gone.

[danawillow]

I don't think there's much of a difference. If you think PATCH is better, then you're welcome to add it back with a comment explaining why :)

Adding an input: true on name/dnsname should add the ForceNew back.

[modular-magician]

I am a robot that works on MagicModules PRs!

I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#107
depends: hashicorp/terraform-provider-google#2428
depends: modular-magician/ansible#128

[drebes]

I checked through the API and this is required for creation.

[drebes]

In the end I also reverted the previous changes so that only the description and labels get updated, through PATCH. PATCH semantics is much cleaner as the request will have only the fields that change, and I confirmed that gcloud is also PATCHing these fields on update. The generated code is also easy to follow.

[drebes]

And now the generated code passes the acceptance tests:

$ make testacc TESTARGS='-run=TestAccDnsManagedZone_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test $(go list ./... |grep -v 'vendor') -v -run=TestAccDnsManagedZone_ -timeout 120m
?   	github.com/terraform-providers/terraform-provider-google	[no test files]
=== RUN   TestAccDnsManagedZone_basic
=== PAUSE TestAccDnsManagedZone_basic
=== RUN   TestAccDnsManagedZone_update
=== PAUSE TestAccDnsManagedZone_update
=== RUN   TestAccDnsManagedZone_importWithProject
=== PAUSE TestAccDnsManagedZone_importWithProject
=== CONT  TestAccDnsManagedZone_basic
=== CONT  TestAccDnsManagedZone_importWithProject
=== CONT  TestAccDnsManagedZone_update
--- PASS: TestAccDnsManagedZone_importWithProject (7.04s)
--- PASS: TestAccDnsManagedZone_basic (7.09s)
--- PASS: TestAccDnsManagedZone_update (9.25s)
PASS
ok  	github.com/terraform-providers/terraform-provider-google/google	9.289s
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-google/scripts	(cached) [no tests to run]

[modular-magician]

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit 95e7e1f) have been included in your existing downstream PRs.

[danawillow]

I just tried running the magician again and it looks like the PR has merge conflicts. Mind fixing those and letting me know once you have?

[drebes]

I just rebased, can you check if that fixes the conflicts?

[modular-magician]

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit 124d2a2) have been included in your existing downstream PRs.

[danawillow]

LGTM, thanks for doing this!