-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
google_bigquery_connection - add missing output fields #6988
google_bigquery_connection - add missing output fields #6988
Conversation
Oops! It looks like you're using an unknown release-note type in your changelog entries:
Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md. |
Hello! I am a robot who works on Magic Modules PRs. I've detected that you're a community contributor. @rileykarson, a repository maintainer, has been assigned to assist you and help review your changes. ❓ First time contributing? Click here for more detailsYour assigned reviewer will help review your code by:
You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails. If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 78 insertions(+), 2 deletions(-)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccLoggingBucketConfigProject_cmekSettings|TestAccContainerCluster_withInvalidGatewayApiConfigChannel |
a8f1677
to
4341bab
Compare
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 123 insertions(+), 2 deletions(-)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccFirebaserulesRelease_BasicRelease|TestAccContainerCluster_withInvalidGatewayApiConfigChannel|TestAccBigqueryConnectionConnection_bigqueryConnectionCloudspannerAnalyticsExample|TestAccLoggingBucketConfigProject_cmekSettings |
Tests passed during RECORDING mode: All tests passed |
@rileykarson any movement on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I'm sorry! I think I missed the email when you updated before. My inbox has been a little out of control, sorry about that. Please feel free to reach out sooner!
Generally if it's been a week a notification got lost somewhere, so our robot recommends that as a guideline.
No worries, thanks for pushing this!
…On Fri, 27 Jan 2023 at 20:45 Riley Karson ***@***.***> wrote:
***@***.**** approved this pull request.
Oh, I'm sorry! I think I missed the email when you updated before. My
inbox has been a little out of control, sorry about that. Please feel free
to reach out sooner!
*Generally* if it's been a week a notification got lost somewhere, so our
robot recommends
<#6988 (comment)>
that as a guideline.
—
Reply to this email directly, view it on GitHub
<#6988 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIA2W7TPHNUPPWTWN4MAK33WUQJTHANCNFSM6AAAAAATCTTA5U>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)