feat(vertexai): add parameter `region` to `google_vertex_ai_featurestore_entitytype_feature` #6992

shotarok · 2022-12-19T00:41:51Z

fixes hashicorp/terraform-provider-google#13217.

This PR will make google_vertex_ai_featurestore_entitytype_feature always use regional endpoint corresponding to parent's region. This will prevent the error: "Cannot determine region: set in this resource, or set provider-level 'region' or 'zone'" from happening.

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

vertexai: made google_vertex_ai_featurestore_entitytype_feature always use regional corresponding to parent's region

…e_feature

modular-magician · 2022-12-19T00:42:52Z

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @roaks3, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

Ensuring it's backwards compatible, covers common error cases, etc.
Summarizing the change into a user-facing changelog note.
Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

modular-magician · 2022-12-19T00:57:55Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 33 insertions(+))
Terraform Beta: Diff ( 1 file changed, 33 insertions(+))
TF Validator: Diff ( 3 files changed, 18 insertions(+), 4 deletions(-))

modular-magician · 2022-12-19T01:38:04Z

Tests analytics

Total tests: 2354
Passed tests 2105
Skipped tests: 247
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccContainerCluster_withInvalidGatewayApiConfigChannel|TestAccLoggingBucketConfigProject_cmekSettings

modular-magician · 2022-12-19T01:39:13Z

Tests passed during RECORDING mode:
TestAccContainerCluster_withInvalidGatewayApiConfigChannel[Debug log]
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]

All tests passed
View the build log or the debug log for each test

roaks3

I made some comments here to make sure that this solution is correct, but I also left a comment on the issue that it is resolving. I'd like to confirm that this is not a breaking change, and does not have other implications.

roaks3 · 2023-01-04T15:54:42Z

mmv1/templates/terraform/custom_import/vertex_ai_featurestore_entitytype_feature.go.erb

+
+entitytype := d.Get("entitytype").(string)
+
+re := regexp.MustCompile("^projects/(.+)/locations/(.+)/featurestores/(.+)$")


Would we want to validate that the entity type also includes entityTypes/, or am I misunderstanding this logic?

The purpose of the regex is just to extract the <location> from projects/<project name>/locations/<location>/featurestores/<featurestore name>/entityTypes/<entitytype name>.

I didn't intend to validate the id of entity type here, but adding the validation sounds good to me. So I'll update the regex. Thanks!

I've updated it in 047a83b.

roaks3 · 2023-01-04T15:55:19Z

mmv1/templates/terraform/encoders/vertex_ai_featurestore_entitytype_feature.go.erb

@@ -0,0 +1,8 @@
+if v, ok := d.GetOk("entitytype"); ok {
+	re := regexp.MustCompile("projects/(.+)/locations/(.+)/featurestores/(.+)$")


Same question as above, do we need entityTypes?

I've updated it in 047a83b and fc0ff8c

mmv1/templates/terraform/extra_schema_entry/vertex_ai_featurestore_entitytype_feature.go.erb

mahvar · 2023-02-10T06:59:37Z

I face a similar issue using google_vertex_ai_endpoint:

Error: Cannot determine region: set in this resource, or set provider-level 'region' or 'zone'.

This is the version using:

Terraform v1.3.7
on darwin_arm64

provider registry.terraform.io/hashicorp/google v3.63.0
provider registry.terraform.io/hashicorp/google-beta v4.52.0

What's the remedy?

roaks3 · 2023-05-23T20:18:54Z

@shotarok lightly pinging this one. The PR has been open for quite a while now; could we try to move it forward or close it?

shotarok · 2023-05-23T20:50:19Z

@roaks3 (CC: @mahvar) Sorry for keeping this PR open for a long time. I'll check out this PR and the original issue too

mahvar · 2023-05-24T01:09:02Z

Thanks for the fix! We used it & cleaned up our configs really nicely!

…

On Tue, May 23, 2023 at 3:50 PM Shotaro Kohama ***@***.***> wrote: @roaks3 <https://github.com/roaks3> (CC: @mahvar <https://github.com/mahvar>) Sorry for keeping this PR open for a long time. I'll check out this PR and the original issue too — Reply to this email directly, view it on GitHub <#6992 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AH77W2I6Z5NSOYX6LCWLKYDXHUPJPANCNFSM6AAAAAATCZYPVM> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- Fereshteh Mahvar | Staff Medical Device Software Engineer - Google Health | ***@***.*** | +1 650-448-9653

shotarok · 2023-05-24T16:27:20Z

I haven't fixed the problem of the featurestore_entitytype_feature yet, but that's good to know the similar issue of google_vertex_ai_endpoint was resolved!

shotarok · 2023-06-02T04:06:49Z

@roaks3 I've updated the code and replied to the comments. Could you take a look when you have time?

I'd like to confirm that this is not a breaking change, and does not have other implications.

I believe this PR is a bug fix, not a breaking change as the issue labels indicate (hashicorp/terraform-provider-google#13217). Please let me know if there are any concerns.

[UPDATED] I pushed two additional commits because I found unintentional changes

modular-magician · 2023-06-06T15:57:44Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 33 insertions(+))
Terraform Beta: Diff ( 1 file changed, 33 insertions(+))
TF Conversion: Diff ( 3 files changed, 15 insertions(+), 3 deletions(-))

modular-magician · 2023-06-06T16:54:09Z

Tests analytics

Total tests: 2774
Passed tests 2483
Skipped tests: 285
Affected tests: 6

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccLoggingBucketConfigProject_cmekSettings|TestAccComputeFirewallPolicyRule_multipleRules|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccDataSourceAlloydbLocations_basic|TestAccDataSourceGoogleFirebaseAndroidAppConfig

Get to know how VCR tests work

modular-magician · 2023-06-06T17:08:28Z

Tests passed during RECORDING mode:
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example[Debug log]
TestAccDataSourceAlloydbLocations_basic[Debug log]
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Debug log]

Tests failed during RECORDING mode:
TestAccLoggingBucketConfigProject_cmekSettings[Error message] [Debug log]
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

…ore_entitytype_feature` (GoogleCloudPlatform#6992) * feat: add parameter region to google_vertex_ai_featurestore_entitytype_feature * feat: update code to use tpgresource and transport_tpg * fix: update a description of the field * refactor: update regex to validate id of an entity type * fix: remove an no longer used yaml file * fix: fix the files to update the regex

feat: add parameter region to google_vertex_ai_featurestore_entitytyp…

74e14d8

…e_feature

modular-magician requested a review from roaks3 December 19, 2022 00:42

shotarok marked this pull request as ready for review December 19, 2022 01:41

roaks3 reviewed Jan 4, 2023

View reviewed changes

shotarok added 2 commits June 1, 2023 20:22

Merge branch 'main' into extract-region-from-entitytype-on-feature

8c70050

feat: update code to use tpgresource and transport_tpg

ff09243

modular-magician requested a review from roaks3 June 2, 2023 03:35

modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Jun 2, 2023

shotarok added 2 commits June 1, 2023 20:36

fix: update a description of the field

4447948

refactor: update regex to validate id of an entity type

047a83b

shotarok added 2 commits June 1, 2023 21:08

fix: remove an no longer used yaml file

4d61f58

fix: fix the files to update the regex

fc0ff8c

rileykarson mentioned this pull request Jun 5, 2023

google_vertex_ai_featurestore_entitytype_feature: Cannot determine region: set in this resource, or set provider-level 'region' or 'zone' hashicorp/terraform-provider-google#13217

Closed

modular-magician removed the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Jun 6, 2023

roaks3 approved these changes Jun 7, 2023

View reviewed changes

roaks3 merged commit 52c5905 into GoogleCloudPlatform:main Jun 7, 2023

modular-magician mentioned this pull request Jun 7, 2023

feat(vertexai): add parameter region to google_vertex_ai_featurestore_entitytype_feature hashicorp/terraform-provider-google-beta#5739

Merged

5 tasks

shotarok deleted the extract-region-from-entitytype-on-feature branch June 12, 2023 20:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(vertexai): add parameter `region` to `google_vertex_ai_featurestore_entitytype_feature` #6992

feat(vertexai): add parameter `region` to `google_vertex_ai_featurestore_entitytype_feature` #6992

shotarok commented Dec 19, 2022 •

edited

Loading

modular-magician commented Dec 19, 2022

modular-magician commented Dec 19, 2022

modular-magician commented Dec 19, 2022

modular-magician commented Dec 19, 2022

roaks3 left a comment

roaks3 Jan 4, 2023

shotarok Jun 2, 2023

shotarok Jun 2, 2023

roaks3 Jan 4, 2023

shotarok Jun 2, 2023 •

edited

Loading

mahvar commented Feb 10, 2023

roaks3 commented May 23, 2023

shotarok commented May 23, 2023

mahvar commented May 24, 2023 via email

shotarok commented May 24, 2023

shotarok commented Jun 2, 2023 •

edited

Loading

modular-magician commented Jun 6, 2023

modular-magician commented Jun 6, 2023

modular-magician commented Jun 6, 2023


		entitytype := d.Get("entitytype").(string)

		re := regexp.MustCompile("^projects/(.+)/locations/(.+)/featurestores/(.+)$")

		@@ -0,0 +1,8 @@
		if v, ok := d.GetOk("entitytype"); ok {
		re := regexp.MustCompile("projects/(.+)/locations/(.+)/featurestores/(.+)$")

feat(vertexai): add parameter region to google_vertex_ai_featurestore_entitytype_feature #6992

feat(vertexai): add parameter region to google_vertex_ai_featurestore_entitytype_feature #6992

Conversation

shotarok commented Dec 19, 2022 • edited Loading

modular-magician commented Dec 19, 2022

modular-magician commented Dec 19, 2022

Diff report

modular-magician commented Dec 19, 2022

Tests analytics

Action taken

modular-magician commented Dec 19, 2022

roaks3 left a comment

Choose a reason for hiding this comment

roaks3 Jan 4, 2023

Choose a reason for hiding this comment

shotarok Jun 2, 2023

Choose a reason for hiding this comment

shotarok Jun 2, 2023

Choose a reason for hiding this comment

roaks3 Jan 4, 2023

Choose a reason for hiding this comment

shotarok Jun 2, 2023 • edited Loading

Choose a reason for hiding this comment

mahvar commented Feb 10, 2023

roaks3 commented May 23, 2023

shotarok commented May 23, 2023

mahvar commented May 24, 2023 via email

shotarok commented May 24, 2023

shotarok commented Jun 2, 2023 • edited Loading

modular-magician commented Jun 6, 2023

Diff report

modular-magician commented Jun 6, 2023

Tests analytics

Action taken

modular-magician commented Jun 6, 2023

feat(vertexai): add parameter `region` to `google_vertex_ai_featurestore_entitytype_feature` #6992

feat(vertexai): add parameter `region` to `google_vertex_ai_featurestore_entitytype_feature` #6992

shotarok commented Dec 19, 2022 •

edited

Loading

shotarok Jun 2, 2023 •

edited

Loading

shotarok commented Jun 2, 2023 •

edited

Loading